[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Jochen Neumeister  changed:

   What|Removed |Added

 Status|In Progress |Closed
 Resolution|--- |FIXED

--- Comment #22 from Jochen Neumeister  ---
I'll close up here. If there are any problems with this P.R., please reopen.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

w.schwarzenf...@utanet.at changed:

   What|Removed |Added

 CC||w.schwarzenf...@utanet.at

--- Comment #21 from w.schwarzenf...@utanet.at ---
Is this still relevant?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Jochen Neumeister  changed:

   What|Removed |Added

 CC||jon...@freebsd.org

--- Comment #19 from Jochen Neumeister  ---
what is the current status?
Does ports-secteam have to be active here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

--- Comment #18 from Kubilay Kocak  ---
(In reply to Goran Mekić from comment #15)

@Goran, Andreas 

This issue is effectively resolved/closed, as the change has already been
committed, but is (apparently, still) pending MFH to the quarterll branch.

Please create a separate (new) issue to report any bugs against ansible ports,
including the attached patch, so it can be independently reviewed/analyzed.

If the bug(s) are related to or caused by this change, please include this
issue ID in the new issues 'See Also' field, and CC lifanov (as the original
committer).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

--- Comment #17 from Andreas Sommer  ---
Created attachment 195296
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=195296=edit
Fix symlinks to point to `ansible-${PYTHON_VER}` (not to `ansible`)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Andreas Sommer  changed:

   What|Removed |Added

 CC||andreas.sommer87@googlemail
   ||.com

--- Comment #16 from Andreas Sommer  ---
(In reply to Goran Mekić from comment #15)
I'll post a patch here in a minute to fix `ansible-playbook-3.6 -> ansible`
symlinks to correctly use `ansible-playbook-3.6 -> ansible-3.6`. Only fixes the
issue – the committer has to adapt PORTREVISION accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Goran Mekić  changed:

   What|Removed |Added

 CC||meka@tilda.center

--- Comment #15 from Goran Mekić  ---
When FLAVOR=py36 is chosen, all ansible-* files are symlinks to ansible, while
only ansible-3.6 exists

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Eitan Adler  changed:

   What|Removed |Added

 Attachment #193471|maintainer-approval?(ports- |maintainer-approval+
  Flags|sect...@freebsd.org)|

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

--- Comment #13 from Nikolai Lifanov  ---
The 2.3 and 2.4 versions include beta support for Python 3.
They were compatible with Python 3 already for easier testing.
There is a note to this effect in pkg-message.

Only Ansible 1 is not compatible with Python 3.

I'll MFH this and other commits. I previously was not MFH'ing them because
there was only a single sysutils/ansible ports and not ports tracking stable
branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

--- Comment #14 from Kubilay Kocak  ---
(In reply to Nikolai Lifanov from comment #13)

Ah gotcha. Thanks for clarifying :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Kubilay Kocak  changed:

   What|Removed |Added

   Keywords|needs-patch, needs-qa   |
 Status|Closed  |In Progress
 Resolution|FIXED   |---
 CC||ports-sect...@freebsd.org

--- Comment #12 from Kubilay Kocak  ---
Re-open for MFH (bugfix)

@Lifanov Also, the slave ports (ansible[23]) should have their USES=python
value limtied to 2.7 (as they dont support Python 3.x). Please merge all
commits if you could

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Kubilay Kocak  changed:

   What|Removed |Added

 Attachment #193471||maintainer-approval?(ports-
  Flags||sect...@freebsd.org)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Nikolai Lifanov  changed:

   What|Removed |Added

 Status|In Progress |Closed
 Resolution|--- |FIXED

--- Comment #11 from Nikolai Lifanov  ---
Committed, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

--- Comment #10 from commit-h...@freebsd.org ---
A commit references this bug:

Author: lifanov
Date: Fri May 18 13:45:41 UTC 2018
New revision: 470293
URL: https://svnweb.freebsd.org/changeset/ports/470293

Log:
  add tests and FLAVORS to Ansible ports

  Most of the work was done by koobs. Thank you!

  PR:   228268
  Submitted by: koobs
  Reported by:  Christopher Hall

Changes:
  head/UPDATING
  head/sysutils/ansible/Makefile
  head/sysutils/ansible1/Makefile
  head/sysutils/ansible23/Makefile
  head/sysutils/ansible24/Makefile

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Nikolai Lifanov  changed:

   What|Removed |Added

  Flags|maintainer-feedback?(lifano |maintainer-feedback+
   |v...@freebsd.org)  |

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Nikolai Lifanov  changed:

   What|Removed |Added

 Attachment #193424|0   |1
is obsolete||

--- Comment #9 from Nikolai Lifanov  ---
Created attachment 193471
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=193471=edit
patch v3

added py-nose dependency, nuked problematic test

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

--- Comment #8 from Nikolai Lifanov  ---
With small changes, enough tests pass with both Python 2 and 3 on Ansible 2.3,
2.4, and 2.5. I'm ready to commit this unless koobs would like to since he did
most of the work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

--- Comment #7 from Nikolai Lifanov  ---
Hi Christopher,

I'm still in the middle of testing the whole support matrix.
Thanks for providing the use case for FLAVORS!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

--- Comment #6 from Christopher Hall  ---
Hello Nikolai, Koobs

  Thanks for your help in working on this, several of our playbooks just fail
on Python2 Ansible and since other team members are using Mac or Linux (with
Python3) I did a quick patch and have so far experienced no problems.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Nikolai Lifanov  changed:

   What|Removed |Added

 Status|Open|In Progress

--- Comment #5 from Nikolai Lifanov  ---
Hi Christopher, koobs!

I removed the flavor support in r455231 to unbreak slave ports because:

1) Ansible is a tool and not a library, so it doesn't matter which interpreter
it's running with as long as it obeys PYTHON_DEFAULT
2) slave ports need to be adjusted with a unique suffix, and back then it was
impossible to set PKGNAMESUFFIX if using FLAVORS

To point #2, I think this has been fixed since, so it's worth revisiting the
issue. I'll make the conversion and get to testing!

Thanks koobs for the test target! This will make it a ton easier.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Kubilay Kocak  changed:

   What|Removed |Added

 Attachment #193420|0   |1
is obsolete||
 CC||ko...@freebsd.org

--- Comment #4 from Kubilay Kocak  ---
Created attachment 193424
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=193424=edit
patch v2

- Use PYTHON_PKGNAMEPREFIX
- Enable USE_PYTHON=concurrent
- Add TEST_DEPENDS and test target

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

--- Comment #3 from Kubilay Kocak  ---
I have a patch in progress that adds TEST_DEPENDS and a test target to make QA
easier / more thorough

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"

[Bug 228268] sysutils/ansible: Fix multiple Python version (and flavor) support

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228268

Kubilay Kocak  changed:

   What|Removed |Added

   Keywords|easy|
 CC||pyt...@freebsd.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-python@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-python
To unsubscribe, send any mail to "freebsd-python-unsubscr...@freebsd.org"