9-STABLE buildworld compile error

2013-04-02 Thread Dmitry Luhtionov
When I put MALLOC_PRODUCTION=yes in /etc/make/conf, make buildworld hangs
with error
/usr/src/lib/libc/stdlib/
malloc.c:126:1: error: MALLOC_PRODUCTION redefined
command-line: error: this is the location of the previous definition

This is a patch, which avoid this error

--- /usr/src/lib/libc/stdlib/Makefile.inc.orig2012-12-04
11:53:28.0 +0200
+++ /usr/src/lib/libc/stdlib/Makefile.inc2013-04-02 14:14:35.0
+0300
@@ -51,7 +51,3 @@
 malloc.3 realloc.3 malloc.3 reallocf.3 malloc.3 malloc_usable_size.3
 MLINKS+=tsearch.3 tdelete.3 tsearch.3 tfind.3 tsearch.3 twalk.3

-.if defined(MALLOC_PRODUCTION)
-CFLAGS+=-DMALLOC_PRODUCTION
-.endif
-
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: 9-STABLE buildworld compile error

2013-04-02 Thread Ian Lepore
On Tue, 2013-04-02 at 14:28 +0300, Dmitry Luhtionov wrote:
 When I put MALLOC_PRODUCTION=yes in /etc/make/conf, make buildworld hangs
 with error
 /usr/src/lib/libc/stdlib/
 malloc.c:126:1: error: MALLOC_PRODUCTION redefined
 command-line: error: this is the location of the previous definition
 
 This is a patch, which avoid this error
 
 --- /usr/src/lib/libc/stdlib/Makefile.inc.orig2012-12-04
 11:53:28.0 +0200
 +++ /usr/src/lib/libc/stdlib/Makefile.inc2013-04-02 14:14:35.0
 +0300
 @@ -51,7 +51,3 @@
  malloc.3 realloc.3 malloc.3 reallocf.3 malloc.3 malloc_usable_size.3
  MLINKS+=tsearch.3 tdelete.3 tsearch.3 tfind.3 tsearch.3 twalk.3
 
 -.if defined(MALLOC_PRODUCTION)
 -CFLAGS+=-DMALLOC_PRODUCTION
 -.endif
 -

That's because MALLOC_PRODUCTION is already defined in -stable.  

The right fix would be to remove it from your make.conf, because it's no
longer necessary in -current either -- the performance problems that
originally led to the advice to put MALLOC_PRODUCTION in make.conf for
-current have been fixed.

-- Ian


___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org