Re: FreeBSD Security Advisory FreeBSD-SA-10:10.openssl

2010-12-03 Thread Paul Mather
On Dec 2, 2010, at 4:54 AM, Gareth de Vaux wrote:

 On Thu 2010-12-02 (00:05), jhell wrote:
 Try that with a ( make includes ) in that same directory and if it works
 then the advisory will have to be revised.
 
 Ah awesome, that works thanx.
 
 (I don't see why though, since it was only half complaining about
 a missing definition, even when I manually included dtls1.h. Also,
 I tried on a different system and the advisory instructions worked
 as is).

The advisory instructions worked as-is for me on a 7.3-RELEASE-p3 system but 
failed on my 8.1-STABLE systems.  However, a make buildworld followed by a 
make install in the appropriate directory work successfully on the 8.1-STABLE 
machines.

Cheers,

Paul.


___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: FreeBSD Security Advisory FreeBSD-SA-10:10.openssl

2010-12-02 Thread Gareth de Vaux
On Thu 2010-12-02 (00:05), jhell wrote:
 Try that with a ( make includes ) in that same directory and if it works
 then the advisory will have to be revised.

Ah awesome, that works thanx.

(I don't see why though, since it was only half complaining about
a missing definition, even when I manually included dtls1.h. Also,
I tried on a different system and the advisory instructions worked
as is).
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: FreeBSD Security Advisory FreeBSD-SA-10:10.openssl

2010-12-01 Thread Gareth de Vaux
On Mon 2010-11-29 (21:19), FreeBSD Security Advisories wrote:
 # cd /usr/src
 # patch  /path/to/patch
 # cd /usr/src/secure/lib/libssl
 # make obj  make depend  make  make install

Hi all, I'm following the instructions with:

# cvsup /etc/cvsup-src.conf
# rm -rf /usr/obj   
# cd /usr/src/secure/lib/libssl
# make obj  make depend  make

[ snip ]

cc -O -pipe  -DTERMIOS -DANSI_SOURCE 
-I/usr/src/secure/lib/libssl/../../../crypto/openssl 
-I/usr/src/secure/lib/libssl/../../../crypto/openssl/crypto 
-I/usr/obj/usr/src/secure/lib/libssl -DOPENSSL_THREADS -DDSO_DLFCN 
-DHAVE_DLFCN_H -DOPENSSL_NO_IDEA -DL_ENDIAN -DNO_IDEA -std=gnu99 
-fstack-protector  -c 
/usr/src/secure/lib/libssl/../../../crypto/openssl/ssl/d1_both.c
/usr/src/secure/lib/libssl/../../../crypto/openssl/ssl/d1_both.c: In function 
'dtls1_hm_fragment_new':
/usr/src/secure/lib/libssl/../../../crypto/openssl/ssl/d1_both.c:210: error: 
'hm_fragment' has no member named 'reassembly'

[ more hm_fragment.reassembly errors .. ]

*** Error code 1

Stop in /usr/src/secure/lib/libssl.


What's going on?

hm_fragment is (only) defined in /usr/src/crypto/openssl/ssl/dtls1.h:

typedef struct hm_fragment_st
{
struct hm_header_st msg_header;
unsigned char *fragment;
unsigned char *reassembly;
} hm_fragment;

which has that member and is sourced from the Makefiles.

The first existence complaint in d1_both.c is:

frag-reassembly = bitmask;

yet

frag-fragment = buf;

a few lines earlier is fine?
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: FreeBSD Security Advisory FreeBSD-SA-10:10.openssl

2010-12-01 Thread jhell
On 12/01/2010 12:53, Gareth de Vaux wrote:
 On Mon 2010-11-29 (21:19), FreeBSD Security Advisories wrote:
 # cd /usr/src
 # patch  /path/to/patch
 # cd /usr/src/secure/lib/libssl
 # make obj  make depend  make  make install
 
 Hi all, I'm following the instructions with:
 
 # cvsup /etc/cvsup-src.conf
 # rm -rf /usr/obj   
 # cd /usr/src/secure/lib/libssl
 # make obj  make depend  make
 
 [ snip ]
 
 cc -O -pipe  -DTERMIOS -DANSI_SOURCE 
 -I/usr/src/secure/lib/libssl/../../../crypto/openssl 
 -I/usr/src/secure/lib/libssl/../../../crypto/openssl/crypto 
 -I/usr/obj/usr/src/secure/lib/libssl -DOPENSSL_THREADS -DDSO_DLFCN 
 -DHAVE_DLFCN_H -DOPENSSL_NO_IDEA -DL_ENDIAN -DNO_IDEA -std=gnu99 
 -fstack-protector  -c 
 /usr/src/secure/lib/libssl/../../../crypto/openssl/ssl/d1_both.c
 /usr/src/secure/lib/libssl/../../../crypto/openssl/ssl/d1_both.c: In function 
 'dtls1_hm_fragment_new':
 /usr/src/secure/lib/libssl/../../../crypto/openssl/ssl/d1_both.c:210: error: 
 'hm_fragment' has no member named 'reassembly'
 
 [ more hm_fragment.reassembly errors .. ]
 
 *** Error code 1
 
 Stop in /usr/src/secure/lib/libssl.
 
 
 What's going on?
 
 hm_fragment is (only) defined in /usr/src/crypto/openssl/ssl/dtls1.h:
 
 typedef struct hm_fragment_st
   {
   struct hm_header_st msg_header;
   unsigned char *fragment;
   unsigned char *reassembly;
   } hm_fragment;
 
 which has that member and is sourced from the Makefiles.
 
 The first existence complaint in d1_both.c is:
 
 frag-reassembly = bitmask;
 
 yet
 
 frag-fragment = buf;
 
 a few lines earlier is fine?
 ___
 freebsd-stable@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-stable
 To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org

Try that with a ( make includes ) in that same directory and if it works
then the advisory will have to be revised.

so it should be

make obj
make depend
make includes
make  make install


If all else fails a buildworld would work for you...

Regards,

-- 

 jhell,v
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org