Re: devd rule wierd output

2019-09-08 Thread Nikos Vassiliadis 

On 2019-09-05 21:25, Warner Losh wrote:

Please file a PR.

Ideally, if you could connect to /var/run/devd.pipe before starting the
scrub and including the output on 10 and 12, that would be great.



Thanks!
Here's the PR:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240411

___
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"

Re: devd rule wierd output

2019-09-05 Thread Warner Losh 
On Thu, Sep 5, 2019 at 12:08 PM Nikos Vassiliadis  wrote:

> Hi,
>
> I have this in my devd rules:
> > notify 10 {
> > match "system"  "ZFS";
> > match "type""misc.fs.zfs.scrub_start";
> > action "touch /var/run/scrub_$pool_name; logger -t ZFS 'zpool
> $pool_name started scrubbing'";
> > };
>
> While this is working OK on FreeBSD-10, on FreeBSD-12 I noticed that
> $pool_name is different. FreeBSD-10:
> Sep  5 20:35:56 clio ZFS: zpool clio started scrubbing
> FreeBSD-12:
> Sep  5 20:47:35 aurora ZFS[1302]: zpool $aurora-os started scrubbing
>
> While it assigns the value, it weirdly includes a dollar sign
> at the front.
>
> Thoughts?
> Should I open a PR?
>

Please file a PR.

Ideally, if you could connect to /var/run/devd.pipe before starting the
scrub and including the output on 10 and 12, that would be great.

Warner
___
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"

devd rule wierd output

2019-09-05 Thread Nikos Vassiliadis 

Hi,

I have this in my devd rules:

notify 10 {
match "system"  "ZFS";
match "type""misc.fs.zfs.scrub_start";
action "touch /var/run/scrub_$pool_name; logger -t ZFS 'zpool $pool_name 
started scrubbing'";
};


While this is working OK on FreeBSD-10, on FreeBSD-12 I noticed that
$pool_name is different. FreeBSD-10:
Sep  5 20:35:56 clio ZFS: zpool clio started scrubbing
FreeBSD-12:
Sep  5 20:47:35 aurora ZFS[1302]: zpool $aurora-os started scrubbing

While it assigns the value, it weirdly includes a dollar sign
at the front.

Thoughts?
Should I open a PR?

Nikos
___
freebsd-stable@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to "freebsd-stable-unsubscr...@freebsd.org"