Re: net/mpd5, ppp, proxy-arp issues

2010-05-03 Thread Stefan Esser
Am 26.04.2010 18:02, schrieb Julian Elischer:
 On 4/26/10 1:11 AM, Stefan Esser wrote:
 I debugged this problem and prepared a patch for discussion, which
 later was committed by Max Laier (if memory serves me right). The
 message was added in order to identify further situations, where
 network domains are added after network interfaces have been
 initialized. This message ought to be informational right now, since
 the interface init is repeated whenever a network domain is added
 as part of above mentioned patch. Init order should be fixed, if
 this message is printed for compiled in drivers, but in case of a
 kernel module (like netgraph) that adds a domain, it is unadvoidable
 that the init order is reversed.

 Perhaps the message should be made conditional on the start-up of
 the kernel not having finished, or it should be completely removed,
 since time has shown, that the init order is correct in general.

 I'll remove that message (or make it conditional on bootverbose)
 unless there is opposition to this change ...
 please do..
 
 it's an unavoidable thing that domains added after boot
 are done after boot completes   :-)

Hmmm, I had a look at the code over the weekend and I'm not sure,
whether changes during the last 5 years did not break assumptions
and introduced bugs in if_attachdomain1() in /sys/net/if.c ...

The tests at the head of the function seem problematic, but will
need further analysis. I'll have to check the conditions under which
the TRY_LOCK may fail and the second if clause seems to prevent the
execution of the core of the function for KLDs (which would be BAD).

Since I'm travelling abroad and without access to the sources or a
test system for most of the week, I cannot perform these tests. But
I'd be very surprised, if the code still worked as I intended it
more than 5 years ago ...

I'll hold back any commits until I have been able to perform tests
(or somebody else looks into this and gets to a conclusion ...).

Best regards, STefan
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: net/mpd5, ppp, proxy-arp issues

2010-04-26 Thread Stefan Esser
Am 22.04.2010 20:43, schrieb Marin Atanasov:
 Hello,
 
 Thanks a lot for the patch, Qing!
 
 It works fine. However I've noticed one thing, after I start mpd5 and
 connect to my home network:
 
 kernel: WARNING: attempt to domain_add(netgraph) after domainfinalize()
 
 Not very sure if this is something to worry about or not?

There was a problem with the initialization order of network domains,
which caused kernel crashes with ISDN+INET6 some two years ago. The
reason was, that there was an implicit assumption, that all domains
were initialized when the network interfaces are initialized, with
NULL dereferences if domains are added (and relevant to a device)
after the device has been initialized.

I debugged this problem and prepared a patch for discussion, which
later was committed by Max Laier (if memory serves me right). The
message was added in order to identify further situations, where
network domains are added after network interfaces have been
initialized. This message ought to be informational right now, since
the interface init is repeated whenever a network domain is added
as part of above mentioned patch. Init order should be fixed, if
this message is printed for compiled in drivers, but in case of a
kernel module (like netgraph) that adds a domain, it is unadvoidable
that the init order is reversed.

Perhaps the message should be made conditional on the start-up of
the kernel not having finished, or it should be completely removed,
since time has shown, that the init order is correct in general.

I'll remove that message (or make it conditional on bootverbose)
unless there is opposition to this change ...

Regards, STefan
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: net/mpd5, ppp, proxy-arp issues

2010-04-26 Thread Julian Elischer

On 4/26/10 1:11 AM, Stefan Esser wrote:

Am 22.04.2010 20:43, schrieb Marin Atanasov:

Hello,

Thanks a lot for the patch, Qing!

It works fine. However I've noticed one thing, after I start mpd5 and
connect to my home network:

kernel: WARNING: attempt to domain_add(netgraph) after domainfinalize()

Not very sure if this is something to worry about or not?


There was a problem with the initialization order of network domains,
which caused kernel crashes with ISDN+INET6 some two years ago. The
reason was, that there was an implicit assumption, that all domains
were initialized when the network interfaces are initialized, with
NULL dereferences if domains are added (and relevant to a device)
after the device has been initialized.

I debugged this problem and prepared a patch for discussion, which
later was committed by Max Laier (if memory serves me right). The
message was added in order to identify further situations, where
network domains are added after network interfaces have been
initialized. This message ought to be informational right now, since
the interface init is repeated whenever a network domain is added
as part of above mentioned patch. Init order should be fixed, if
this message is printed for compiled in drivers, but in case of a
kernel module (like netgraph) that adds a domain, it is unadvoidable
that the init order is reversed.

Perhaps the message should be made conditional on the start-up of
the kernel not having finished, or it should be completely removed,
since time has shown, that the init order is correct in general.

I'll remove that message (or make it conditional on bootverbose)
unless there is opposition to this change ...

please do..

it's an unavoidable thing that domains added after boot
are done after boot completes   :-)


Regards, STefan
___
freebsd-...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org


___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: net/mpd5, ppp, proxy-arp issues

2010-04-22 Thread Marin Atanasov
Hello,

Thanks a lot for the patch, Qing!

It works fine. However I've noticed one thing, after I start mpd5 and
connect to my home network:

kernel: WARNING: attempt to domain_add(netgraph) after domainfinalize()

Not very sure if this is something to worry about or not?

Regards,
Marin

On Tue, Apr 20, 2010 at 11:03 AM, Qing Li qin...@freebsd.org wrote:

 
  I was using csup to track RELEN_8_0 branch. Currently I'm syncing to
  RELENG_8.
 
  If I understood you right, after getting the sources for RELENG_8, I need
 to
  apply the patch and then rebuild world?
 

 You only need to rebuild the kernel.

 -- Qing




-- 
Marin Atanasov Nikolov
dnaeon AT gmail DOT com
daemon AT unix-heaven DOT org
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: net/mpd5, ppp, proxy-arp issues

2010-04-20 Thread Marin Atanasov
Hello Qing,

Seems I've missed that thread, thank you for pointing it out.

I was using csup to track RELEN_8_0 branch. Currently I'm syncing to
RELENG_8.

If I understood you right, after getting the sources for RELENG_8, I need to
apply the patch and then rebuild world?

Thanks and regards,
Marin

On Mon, Apr 19, 2010 at 8:50 PM, Qing Li qin...@freebsd.org wrote:

 Have you seen this thread?

 http://lists.freebsd.org/pipermail/freebsd-net/2010-April/025128.html

 Quite a few fixes have gone into the -current and RELENG_8 branches.
 Please try sync-up to the latest code before applying the patch.

 -- Qing



 On Sun, Apr 18, 2010 at 11:53 PM, Marin Atanasov dna...@gmail.com wrote:
  Hi,
 
  I was setting up mpd5 from ports, but this proxy-arp issue still exists
 in
  8.0.
 
  uname -r
  8.0-RELEASE-p2
 
  I've attached the output from the mpd5 daemon, where you can still see
 that
  the issue is relevant.
 
  I've also tried to apply the patch, but it's no longer on that location.
  Something else to add - I've a dns server running on the same machine
 that
  mpd5 was set up. I'm not sure if this is caused by mpd5 daemon or the arp
  issue, but after a couple of start/stops of mpd5 the name resolving from
 the
  gateway machine is not possible, all other systems from the internal
 network
  are able to use the dns server on the gateway, but the gateway itself
  cannot.
 
  Restart of named, doesn't help either, so I had to completely reboot the
  machine, so that arp entries are flushed as well.
 
  Could you please have a look at the issue? If you need some additional
  information, please let me know.
 
  Regards,
  Marin
 
  On Wed, Dec 16, 2009 at 6:09 PM, Prokofiev S.P. pr...@skylinetele.com
  wrote:
 
  Thank you !
  The problem with proxy-arp has disappeared (FreeBSD 8-STABLE amd64 with
  mpd5).
 
  Please, somebody  fix  the bug kern/141285...
 
 
  Li, Qing wrote:
 
  Hi,
 
  Recently there have been several reports regarding issues with ppp,
 mpd5
  and proxy-arp configuration over the ppp links. I read through the
  various postings and the problems seem to be:
 
  1. Unable to add proxy-arp entries for the remote ppp clients.
 
  2. Log showing ifa_add_loopback_route: insertion failed causing
  some
  userland applications to fail.
 
  May I ask that you try applying patch
 
   
  http://people.freebsd.org/~qingli/ppp-proxy-arp-patch-121515.diffhttp://people.freebsd.org/%7Eqingli/ppp-proxy-arp-patch-121515.diff
 
  and report back if the patch fixes your problems. And if not, please
  describe what additional issues you are having.
 
  Thanks,
 
  -- Qing
 
 
  ___
  freebsd-...@freebsd.org mailing list
  http://lists.freebsd.org/mailman/listinfo/freebsd-net
  To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org
 
 
 
 
  ___
  freebsd-stable@freebsd.org mailing list
  http://lists.freebsd.org/mailman/listinfo/freebsd-stable
  To unsubscribe, send any mail to 
 freebsd-stable-unsubscr...@freebsd.org
 
 
 
  --
  Marin Atanasov Nikolov
  dnaeon AT gmail DOT com
  daemon AT unix-heaven DOT org
 




-- 
Marin Atanasov Nikolov
dnaeon AT gmail DOT com
daemon AT unix-heaven DOT org
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: net/mpd5, ppp, proxy-arp issues

2010-04-20 Thread Qing Li

 I was using csup to track RELEN_8_0 branch. Currently I'm syncing to
 RELENG_8.

 If I understood you right, after getting the sources for RELENG_8, I need to
 apply the patch and then rebuild world?


You only need to rebuild the kernel.

-- Qing
___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: net/mpd5, ppp, proxy-arp issues

2010-04-19 Thread Marin Atanasov
Hi,

I was setting up mpd5 from ports, but this proxy-arp issue still exists in
8.0.

 uname -r
8.0-RELEASE-p2

I've attached the output from the mpd5 daemon, where you can still see that
the issue is relevant.

I've also tried to apply the patch, but it's no longer on that location.
Something else to add - I've a dns server running on the same machine that
mpd5 was set up. I'm not sure if this is caused by mpd5 daemon or the arp
issue, but after a couple of start/stops of mpd5 the name resolving from the
gateway machine is not possible, all other systems from the internal network
are able to use the dns server on the gateway, but the gateway itself
cannot.

Restart of named, doesn't help either, so I had to completely reboot the
machine, so that arp entries are flushed as well.

Could you please have a look at the issue? If you need some additional
information, please let me know.

Regards,
Marin

On Wed, Dec 16, 2009 at 6:09 PM, Prokofiev S.P. pr...@skylinetele.comwrote:

 Thank you !
 The problem with proxy-arp has disappeared (FreeBSD 8-STABLE amd64 with
 mpd5).

 Please, somebody  fix  the bug kern/141285...


 Li, Qing wrote:

 Hi,

 Recently there have been several reports regarding issues with ppp, mpd5
 and proxy-arp configuration over the ppp links. I read through the
 various postings and the problems seem to be:

 1. Unable to add proxy-arp entries for the remote ppp clients.

 2. Log showing ifa_add_loopback_route: insertion failed causingsome
 userland applications to fail.

 May I ask that you try applying patch

  
 http://people.freebsd.org/~qingli/ppp-proxy-arp-patch-121515.diffhttp://people.freebsd.org/%7Eqingli/ppp-proxy-arp-patch-121515.diff

 and report back if the patch fixes your problems. And if not, please
 describe what additional issues you are having.

 Thanks,

 -- Qing


 ___
 freebsd-...@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-net
 To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org





 ___
 freebsd-stable@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-stable
 To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org




-- 
Marin Atanasov Nikolov
dnaeon AT gmail DOT com
daemon AT unix-heaven DOT org
# /usr/local/sbin/mpd5
Multi-link PPP daemon for FreeBSD
 
process 2295 started, version 5.5 (r...@domain 02:21 17-Apr-2010)
Usage: set user {name} {password} [{priv}]
CONSOLE: listening on 127.0.0.1 5005
web: listening on 0.0.0.0 5006
PPTP: waiting for connection on external-ip-here 1723
[L] [L-1] Accepting PPTP connection
[L-1] Link: OPEN event
[L-1] LCP: Open event
[L-1] LCP: state change Initial -- Starting
[L-1] LCP: LayerStart
[L-1] PPTP: attaching to peer's outgoing call
[L-1] Link: UP event
[L-1] LCP: Up event
[L-1] LCP: state change Starting -- Req-Sent
[L-1] LCP: SendConfigReq #1
[L-1]   ACFCOMP
[L-1]   PROTOCOMP
[L-1]   MRU 1500
[L-1]   MAGICNUM 102c4d22
[L-1]   AUTHPROTO CHAP MSOFTv2
[L-1]   MP MRRU 2048
[L-1]   MP SHORTSEQ
[L-1]   ENDPOINTDISC [802.1] 00 10 dc 10 55 3f
[L-1] LCP: rec'd Configure Reject #1 (Req-Sent)
[L-1]   MP MRRU 2048
[L-1]   MP SHORTSEQ
[L-1]   ENDPOINTDISC [802.1] 00 10 dc 10 55 3f
[L-1] LCP: SendConfigReq #2
[L-1]   ACFCOMP
[L-1]   PROTOCOMP
[L-1]   MRU 1500
[L-1]   MAGICNUM 102c4d22
[L-1]   AUTHPROTO CHAP MSOFTv2
[L-1] LCP: rec'd Configure Ack #2 (Req-Sent)
[L-1]   ACFCOMP
[L-1]   PROTOCOMP
[L-1]   MRU 1500
[L-1]   MAGICNUM 102c4d22
[L-1]   AUTHPROTO CHAP MSOFTv2
[L-1] LCP: state change Req-Sent -- Ack-Rcvd
[L-1] LCP: rec'd Configure Request #1 (Ack-Rcvd)
[L-1]   MRU 1400
[L-1]   MAGICNUM 7fe5744d
[L-1]   PROTOCOMP
[L-1]   ACFCOMP
[L-1]   CALLBACK 6
[L-1] LCP: SendConfigRej #1
[L-1]   CALLBACK 6
[L-1] LCP: rec'd Configure Request #2 (Ack-Rcvd)
[L-1]   MRU 1400
[L-1]   MAGICNUM 7fe5744d
[L-1]   PROTOCOMP
[L-1]   ACFCOMP
[L-1] LCP: SendConfigAck #2
[L-1]   MRU 1400
[L-1]   MAGICNUM 7fe5744d
[L-1]   PROTOCOMP
[L-1]   ACFCOMP
[L-1] LCP: state change Ack-Rcvd -- Opened
[L-1] LCP: auth: peer wants nothing, I want CHAP
[L-1] CHAP: sending CHALLENGE #1 len: 21
[L-1] LCP: LayerUp
[L-1] LCP: rec'd Ident #3 (Opened)
[L-1]   MESG: MSRASV5.10
[L-1] LCP: rec'd Ident #4 (Opened)
[L-1]   MESG: MSRAS-0-TSUNAMI
[L-1] CHAP: rec'd RESPONSE #1 len: 61
[L-1]   Name: mratest
[L-1] AUTH: Trying INTERNAL
[L-1] AUTH: INTERNAL returned: undefined
[L-1] CHAP: Auth return status: undefined
[L-1] CHAP: Response is valid
[L-1] CHAP: Reply message: S=8BE305F08FBAEB4E801B6201037B4B4AEB76A73B
[L-1] CHAP: sending SUCCESS #1 len: 46
[L-1] LCP: authorization successful
[L-1] Link: Matched action 'bundle B '
[L-1] Creating new bundle using template B.
[B-1] Bundle: Interface ng0 created
[L-1] Link: Join bundle B-1
[B-1] Bundle: Status update: up 1 link, total bandwidth 64000 bps
[B-1] IPCP: Open event
[B-1] IPCP: state change Initial -- Starting
[B-1] IPCP: LayerStart
[B-1] CCP: Open event

Re: net/mpd5, ppp, proxy-arp issues

2010-04-19 Thread Qing Li
Have you seen this thread?

http://lists.freebsd.org/pipermail/freebsd-net/2010-April/025128.html

Quite a few fixes have gone into the -current and RELENG_8 branches.
Please try sync-up to the latest code before applying the patch.

-- Qing



On Sun, Apr 18, 2010 at 11:53 PM, Marin Atanasov dna...@gmail.com wrote:
 Hi,

 I was setting up mpd5 from ports, but this proxy-arp issue still exists in
 8.0.

 uname -r
 8.0-RELEASE-p2

 I've attached the output from the mpd5 daemon, where you can still see that
 the issue is relevant.

 I've also tried to apply the patch, but it's no longer on that location.
 Something else to add - I've a dns server running on the same machine that
 mpd5 was set up. I'm not sure if this is caused by mpd5 daemon or the arp
 issue, but after a couple of start/stops of mpd5 the name resolving from the
 gateway machine is not possible, all other systems from the internal network
 are able to use the dns server on the gateway, but the gateway itself
 cannot.

 Restart of named, doesn't help either, so I had to completely reboot the
 machine, so that arp entries are flushed as well.

 Could you please have a look at the issue? If you need some additional
 information, please let me know.

 Regards,
 Marin

 On Wed, Dec 16, 2009 at 6:09 PM, Prokofiev S.P. pr...@skylinetele.com
 wrote:

 Thank you !
 The problem with proxy-arp has disappeared (FreeBSD 8-STABLE amd64 with
 mpd5).

 Please, somebody  fix  the bug kern/141285...


 Li, Qing wrote:

 Hi,

 Recently there have been several reports regarding issues with ppp, mpd5
 and proxy-arp configuration over the ppp links. I read through the
 various postings and the problems seem to be:

 1. Unable to add proxy-arp entries for the remote ppp clients.

 2. Log showing ifa_add_loopback_route: insertion failed causing    some
 userland applications to fail.

 May I ask that you try applying patch

  http://people.freebsd.org/~qingli/ppp-proxy-arp-patch-121515.diff

 and report back if the patch fixes your problems. And if not, please
 describe what additional issues you are having.

 Thanks,

 -- Qing


 ___
 freebsd-...@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-net
 To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org




 ___
 freebsd-stable@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-stable
 To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org



 --
 Marin Atanasov Nikolov
 dnaeon AT gmail DOT com
 daemon AT unix-heaven DOT org

___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


Re: net/mpd5, ppp, proxy-arp issues

2009-12-16 Thread Prokofiev S.P.

Thank you !
The problem with proxy-arp has disappeared (FreeBSD 8-STABLE amd64 with 
mpd5).


Please, somebody  fix  the bug kern/141285...


Li, Qing wrote:

Hi,

Recently there have been several reports regarding issues with ppp, mpd5
and proxy-arp configuration over the ppp links. I read through the
various postings and the problems seem to be:

1. Unable to add proxy-arp entries for the remote ppp clients.

2. Log showing ifa_add_loopback_route: insertion failed causing 
   some userland applications to fail.


May I ask that you try applying patch

  http://people.freebsd.org/~qingli/ppp-proxy-arp-patch-121515.diff

and report back if the patch fixes your problems. And if not, 
please describe what additional issues you are having.


Thanks,

-- Qing


___
freebsd-...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org


  


___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org


net/mpd5, ppp, proxy-arp issues

2009-12-15 Thread Li, Qing
Hi,

Recently there have been several reports regarding issues with ppp, mpd5
and proxy-arp configuration over the ppp links. I read through the
various postings and the problems seem to be:

1. Unable to add proxy-arp entries for the remote ppp clients.

2. Log showing ifa_add_loopback_route: insertion failed causing 
   some userland applications to fail.

May I ask that you try applying patch

  http://people.freebsd.org/~qingli/ppp-proxy-arp-patch-121515.diff

and report back if the patch fixes your problems. And if not, 
please describe what additional issues you are having.

Thanks,

-- Qing


___
freebsd-stable@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-stable
To unsubscribe, send any mail to freebsd-stable-unsubscr...@freebsd.org