[Differential] [Accepted] D1932: Remove the non-standard CC alias for c++

2015-05-26 Thread emaste (Ed Maste) 
emaste accepted this revision.

REPOSITORY
  rS FreeBSD src repository

BRANCH
  /head

REVISION DETAIL
  https://reviews.freebsd.org/D1932

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: dim, theraven, emaste
Cc: freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org

[Differential] [Updated, 8 lines] D1932: Remove the non-standard CC alias for c++

2015-05-26 Thread dim (Dimitry Andric) 
dim updated this revision to Diff 5715.
dim added a comment.
This revision now requires review to proceed.
Herald added a subscriber: imp.

Updated for changes in ObsoleteFiles.inc.


REPOSITORY
  rS FreeBSD src repository

CHANGES SINCE LAST UPDATE
  https://reviews.freebsd.org/D1932?vs=3900id=5715

BRANCH
  /head

REVISION DETAIL
  https://reviews.freebsd.org/D1932

AFFECTED FILES
  ObsoleteFiles.inc
  gnu/usr.bin/cc/c++/Makefile
  gnu/usr.bin/cc/cc/Makefile
  usr.bin/clang/clang/Makefile

CHANGE DETAILS
  diff --git a/usr.bin/clang/clang/Makefile b/usr.bin/clang/clang/Makefile
  --- a/usr.bin/clang/clang/Makefile
  +++ b/usr.bin/clang/clang/Makefile
  @@ -20,11 +20,9 @@
   .if ${MK_CLANG_IS_CC} != no
   LINKS+=  ${BINDIR}/clang ${BINDIR}/cc \
${BINDIR}/clang ${BINDIR}/c++ \
  - ${BINDIR}/clang ${BINDIR}/CC \
${BINDIR}/clang ${BINDIR}/cpp
   MLINKS+= clang.1 cc.1 \
clang.1 c++.1 \
  - clang.1 CC.1 \
clang.1 cpp.1
   .endif
   
  diff --git a/gnu/usr.bin/cc/cc/Makefile b/gnu/usr.bin/cc/cc/Makefile
  --- a/gnu/usr.bin/cc/cc/Makefile
  +++ b/gnu/usr.bin/cc/cc/Makefile
  @@ -16,7 +16,7 @@
   MLINKS=  gcc.1 g++.1
   .if ${MK_CLANG_IS_CC} == no
   LINKS=   ${BINDIR}/gcc ${BINDIR}/cc
  -MLINKS+= gcc.1 cc.1 gcc.1 c++.1 gcc.1 CC.1
  +MLINKS+= gcc.1 cc.1 gcc.1 c++.1 gcc.1
   .endif
   
   .include bsd.prog.mk
  diff --git a/gnu/usr.bin/cc/c++/Makefile b/gnu/usr.bin/cc/c++/Makefile
  --- a/gnu/usr.bin/cc/c++/Makefile
  +++ b/gnu/usr.bin/cc/c++/Makefile
  @@ -16,7 +16,6 @@
   
   .if ${MK_CLANG_IS_CC} == no
   LINKS=   ${BINDIR}/g++ ${BINDIR}/c++
  -LINKS+=  ${BINDIR}/g++ ${BINDIR}/CC
   .endif
   
   .include bsd.prog.mk
  diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc
  --- a/ObsoleteFiles.inc
  +++ b/ObsoleteFiles.inc
  @@ -38,6 +38,9 @@
   #   xargs -n1 | sort | uniq -d;
   # done
   
  +# 2015mmdd: Removed the non-standard CC alias for c++
  +OLD_FILES+=usr/bin/CC
  +OLD_FILES+=usr/share/man/man1/CC.1.gz
   # 20150525: new clang import which bumps version from 3.6.0 to 3.6.1.
   OLD_FILES+=usr/lib/clang/3.6.0/include/__stddef_max_align_t.h
   OLD_FILES+=usr/lib/clang/3.6.0/include/__wmmintrin_aes.h

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: dim, emaste, theraven
Cc: imp, freebsd-toolchain
diff --git a/usr.bin/clang/clang/Makefile b/usr.bin/clang/clang/Makefile
--- a/usr.bin/clang/clang/Makefile
+++ b/usr.bin/clang/clang/Makefile
@@ -20,11 +20,9 @@
 .if ${MK_CLANG_IS_CC} != no
 LINKS+=	${BINDIR}/clang ${BINDIR}/cc \
 	${BINDIR}/clang ${BINDIR}/c++ \
-	${BINDIR}/clang ${BINDIR}/CC \
 	${BINDIR}/clang ${BINDIR}/cpp
 MLINKS+= clang.1 cc.1 \
 	clang.1 c++.1 \
-	clang.1 CC.1 \
 	clang.1 cpp.1
 .endif
 
diff --git a/gnu/usr.bin/cc/cc/Makefile b/gnu/usr.bin/cc/cc/Makefile
--- a/gnu/usr.bin/cc/cc/Makefile
+++ b/gnu/usr.bin/cc/cc/Makefile
@@ -16,7 +16,7 @@
 MLINKS=	gcc.1 g++.1
 .if ${MK_CLANG_IS_CC} == no
 LINKS=	${BINDIR}/gcc ${BINDIR}/cc
-MLINKS+= gcc.1 cc.1 gcc.1 c++.1 gcc.1 CC.1
+MLINKS+= gcc.1 cc.1 gcc.1 c++.1 gcc.1
 .endif
 
 .include bsd.prog.mk
diff --git a/gnu/usr.bin/cc/c++/Makefile b/gnu/usr.bin/cc/c++/Makefile
--- a/gnu/usr.bin/cc/c++/Makefile
+++ b/gnu/usr.bin/cc/c++/Makefile
@@ -16,7 +16,6 @@
 
 .if ${MK_CLANG_IS_CC} == no
 LINKS=	${BINDIR}/g++ ${BINDIR}/c++
-LINKS+=	${BINDIR}/g++ ${BINDIR}/CC
 .endif
 
 .include bsd.prog.mk
diff --git a/ObsoleteFiles.inc b/ObsoleteFiles.inc
--- a/ObsoleteFiles.inc
+++ b/ObsoleteFiles.inc
@@ -38,6 +38,9 @@
 #   xargs -n1 | sort | uniq -d;
 # done
 
+# 2015mmdd: Removed the non-standard CC alias for c++
+OLD_FILES+=usr/bin/CC
+OLD_FILES+=usr/share/man/man1/CC.1.gz
 # 20150525: new clang import which bumps version from 3.6.0 to 3.6.1.
 OLD_FILES+=usr/lib/clang/3.6.0/include/__stddef_max_align_t.h
 OLD_FILES+=usr/lib/clang/3.6.0/include/__wmmintrin_aes.h

___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org

[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

2015-05-26 Thread imp (Warner Losh) 
imp added a comment.

CC has been an alias for the default C++ compiler the entire life FreeBSD has 
had a C++ compiler.

Sure, it isn't based on any standards but it is a very de-facto standard that 
many ports rely on.
FreeBSD isn't the only system to do this. Sun did this for years, as did SGI, 
and many other folks
that had a C++ compiler based on cfront. IIRC CC was a shell script front end 
for cfront in at least
the cfront 2.0 and 3.0 time frame. Many ISV's compilersr picked up on this 
de-facto standard and
have been providing the link for a long time.


REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D1932

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: dim, emaste, theraven
Cc: imp, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org

[Differential] [Requested Changes To] D1932: Remove the non-standard CC alias for c++

2015-05-26 Thread imp (Warner Losh) 
imp requested changes to this revision.
imp added a reviewer: imp.
imp added a comment.
This revision now requires changes to proceed.

So it is icky likely isn't a good enough reason.

Do a ports run w/o it causing any problems and prove me wrong...


REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D1932

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: dim, emaste, theraven, imp
Cc: imp, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org

[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

2015-05-26 Thread emaste (Ed Maste) 
emaste added a comment.

In https://reviews.freebsd.org/D1932#49686, @imp wrote:

 it is a very de-facto standard that many ports rely on.


Many ports will choose CC if it exists, but I'm not sure they rely on it. 
Autoconf and cmake builds will try a list and if they pick c++ next they'll be 
fine.
exp-run requested in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200475


REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D1932

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: dim, emaste, theraven, imp
Cc: imp, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org