Re: [package - head-amd64-default][games/simutrans] Failed for simutrans-120.2.2 in build

2017-07-28 Thread Tijl Coosemans 
On Fri, 28 Jul 2017 19:54:04 +0200 Dimitry Andric  wrote:
> On 28 Jul 2017, at 13:55, Tijl Coosemans  wrote:
>> 
>> On Thu, 27 Jul 2017 21:42:01 + pkg-fall...@freebsd.org wrote:  
> ...
>>> In file included from squirrel/squirrel/sqvm.cc:5:
>>> In file included from /usr/include/c++/v1/math.h:310:
>>> /usr/include/c++/v1/limits:149:85: error: expected expression
>>>_LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type max() _NOEXCEPT 
>>> {return type();}
>>> 
>>>^
>>> squirrel/squirrel/sqobject.h:131:24: note: expanded from macro 'type'
>>> #define type(obj) ((obj)._type)
>>>   ^  
>> 
>> Simutrans code defines 'type' as a macro.  Shouldn't libc++ headers use
>> _type or __type or something?  
> 
> No, the member name 'type' is used in many classes in the C++ standard
> library, for example all the traits in .  Programs should
> not attempt to redefine this, at least not as a macro.
> 
> Note that this also doesn't work with libstdc++, e.g.:
> 
> $ cat boom.cpp
> #define type "nope, this will not work"
> #include 
> 
> and then:
> 
> $ g++ -c boom.cpp
> boom.cpp:1:14: error: expected unqualified-id before string constant
>  #define type "nope, this will not work"
>   ^
> boom.cpp:1:14: error: expected class-name before string constant
>  #define type "nope, this will not work"
>   ^
> boom.cpp:1:14: error: expected '{' before string constant
> boom.cpp:1:14: error: expected class-name before string constant
>  #define type "nope, this will not work"
>   ^
> boom.cpp:1:14: error: expected '{' before string constant
> boom.cpp:1:14: error: expected class-name before string constant
>  #define type "nope, this will not work"
>   ^
> boom.cpp:1:14: error: expected '{' before string constant
> boom.cpp:1:14: error: expected class-name before string constant
>  #define type "nope, this will not work"
>   ^
> boom.cpp:1:14: error: expected '{' before string constant
> boom.cpp:1:14: error: expected unqualified-id before string constant
>  #define type "nope, this will not work"
>   ^
> In file included from boom.cpp:3:0:
> /usr/local/lib/gcc6/include/c++/type_traits:212:60: error: template argument 
> 1 is invalid
>  : public __is_void_helper::type>::type
> ^
> /usr/local/lib/gcc6/include/c++/type_traits:212:61: error: expected '{' 
> before '::' token
>  : public __is_void_helper::type>::type
>  ^~
> [...and lots more errors like this...]

The code does not include  or any of that C++11 stuff.  It
includes .  This works with libstdc++ because it doesn't have
, but it would also work when  was included, because
libstdc++ uses __type everywhere (and __enable_if and __is_arithmetic,
etc. where libc++ headers use enable_if and is_arithmetic).  The
libstdc++ way makes more sense.  You cannot expect C++98 code to know
about reserved identifiers in C++11 or C++11 code to know about reserved
identifiers in later standards.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 219484] cad/openvsp: Fails to build with lang/gcc6 or later on 10.3 (< 11.0)

2017-07-28 Thread bugzilla-noreply 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219484

Raphael Kubo da Costa  changed:

   What|Removed |Added

 Status|Open|Closed
   Assignee|freebsd-ports-bugs@FreeBSD. |rak...@freebsd.org
   |org |
   Keywords|needs-patch, needs-qa   |
  Flags|maintainer-feedback?(fernan |
   |do.apesteg...@gmail.com)|
 Resolution|--- |FIXED

--- Comment #21 from Raphael Kubo da Costa  ---
Committed, thank you. I've left out the PORTREVISION bump because the generated
code should remain the same (C++11 was being used before by working compilers,
and GCC 6 was just broken).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 219484] cad/openvsp: Fails to build with lang/gcc6 or later on 10.3 (< 11.0)

2017-07-28 Thread bugzilla-noreply 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219484

--- Comment #20 from commit-h...@freebsd.org ---
A commit references this bug:

Author: rakuco
Date: Fri Jul 28 21:45:45 UTC 2017
New revision: 446855
URL: https://svnweb.freebsd.org/changeset/ports/446855

Log:
  Explicitly build with -std=gnu++11.

  This fixes the build with GCC 6, which switched its default from -std=gnu++98
  to -std=gnu++14. With this switch, it added a `operator delete(void*,
size_t)'
  overload and uses it for all delete calls. This does not play well with
  dependencies built with other compilers (such as base clang), which use the
old
  operator delete overload and cause linking errors.

  PR:   219484
  Submitted by: fernando.apesteg...@gmail.com (maintainer)
  MFH:  2017Q3

Changes:
  head/cad/openvsp/Makefile

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 219484] cad/openvsp: Fails to build with lang/gcc6 or later on 10.3 (< 11.0)

2017-07-28 Thread bugzilla-noreply 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219484

fernando.apesteg...@gmail.com changed:

   What|Removed |Added

 Attachment #184778|0   |1
is obsolete||
 Attachment #184812||maintainer-approval+
  Flags||

--- Comment #19 from fernando.apesteg...@gmail.com ---
Created attachment 184812
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=184812=edit
patch to the ports tree

New simplified patch as suggested by rakuco@.

Bumping PORTREVISION.

Q/A:
 - portlint -AC: OK
 - poudriere ports for {10.3,11.0}{amd64,i386}: OK

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

Re: [package - head-amd64-default][games/simutrans] Failed for simutrans-120.2.2 in build

2017-07-28 Thread Dimitry Andric 
On 28 Jul 2017, at 13:55, Tijl Coosemans  wrote:
> 
> On Thu, 27 Jul 2017 21:42:01 + pkg-fall...@freebsd.org wrote:
...
>> In file included from squirrel/squirrel/sqvm.cc:5:
>> In file included from /usr/include/c++/v1/math.h:310:
>> /usr/include/c++/v1/limits:149:85: error: expected expression
>>_LIBCPP_INLINE_VISIBILITY static _LIBCPP_CONSTEXPR type max() _NOEXCEPT 
>> {return type();}
>>  
>>   ^
>> squirrel/squirrel/sqobject.h:131:24: note: expanded from macro 'type'
>> #define type(obj) ((obj)._type)
>>   ^
> 
> Simutrans code defines 'type' as a macro.  Shouldn't libc++ headers use
> _type or __type or something?

No, the member name 'type' is used in many classes in the C++ standard
library, for example all the traits in .  Programs should
not attempt to redefine this, at least not as a macro.

Note that this also doesn't work with libstdc++, e.g.:

$ cat boom.cpp
#define type "nope, this will not work"
#include 

and then:

$ g++ -c boom.cpp
boom.cpp:1:14: error: expected unqualified-id before string constant
 #define type "nope, this will not work"
  ^
boom.cpp:1:14: error: expected class-name before string constant
 #define type "nope, this will not work"
  ^
boom.cpp:1:14: error: expected '{' before string constant
boom.cpp:1:14: error: expected class-name before string constant
 #define type "nope, this will not work"
  ^
boom.cpp:1:14: error: expected '{' before string constant
boom.cpp:1:14: error: expected class-name before string constant
 #define type "nope, this will not work"
  ^
boom.cpp:1:14: error: expected '{' before string constant
boom.cpp:1:14: error: expected class-name before string constant
 #define type "nope, this will not work"
  ^
boom.cpp:1:14: error: expected '{' before string constant
boom.cpp:1:14: error: expected unqualified-id before string constant
 #define type "nope, this will not work"
  ^
In file included from boom.cpp:3:0:
/usr/local/lib/gcc6/include/c++/type_traits:212:60: error: template argument 1 
is invalid
 : public __is_void_helper::type>::type
^
/usr/local/lib/gcc6/include/c++/type_traits:212:61: error: expected '{' before 
'::' token
 : public __is_void_helper::type>::type
 ^~
[...and lots more errors like this...]

-Dimitry



signature.asc
Description: Message signed with OpenPGP

[Bug 219484] cad/openvsp: Fails to build with lang/gcc6 or later on 10.3 (< 11.0)

2017-07-28 Thread bugzilla-noreply 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219484

Raphael Kubo da Costa  changed:

   What|Removed |Added

 CC||rak...@freebsd.org

--- Comment #17 from Raphael Kubo da Costa  ---
(In reply to fernando.apesteguia from comment #16)
>> Is this patch acceptable?
>
> .if ${OSVERSION} < 110

Note that you generally want to choose a more specific version that corresponds
more closely to the commit that imported the libc++ version with the new
overloads.

In any case, I think you can simplify the patch by just setting
USE_CXXSTD=gnu++11 -- GCC 6 builds with -std=gnu++14 by default, and the new
overloads were added in C++14. Since you only need C++11 to build the code you
can use an older standard. I've done that here and the port built fine on
10.3-i386 with GCC 6.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

Re: [package - head-amd64-default][games/simutrans] Failed for simutrans-120.2.2 in build

2017-07-28 Thread Tijl Coosemans 
On Thu, 27 Jul 2017 21:42:01 + pkg-fall...@freebsd.org wrote:
> You are receiving this mail as a port that you maintain
> is failing to build on the FreeBSD package build server.
> Please investigate the failure and submit a PR to fix
> build.
> 
> Maintainer: t...@freebsd.org
> Last committer: t...@freebsd.org
> Ident:  $FreeBSD: head/games/simutrans/Makefile 441004 2017-05-16 
> 15:28:53Z tijl $
> Log URL:
> http://beefy12.nyi.freebsd.org/data/head-amd64-default/p446708_s321589/logs/simutrans-120.2.2.log
> Build URL:  
> http://beefy12.nyi.freebsd.org/build.html?mastername=head-amd64-default=p446708_s321589
> Log:
> 
> >> Building games/simutrans  
> build started at Thu Jul 27 21:35:40 UTC 2017
> port directory: /usr/ports/games/simutrans
> building for: FreeBSD head-amd64-default-job-06 12.0-CURRENT FreeBSD 
> 12.0-CURRENT 1200039 amd64
> maintained by: t...@freebsd.org
> Makefile ident:  $FreeBSD: head/games/simutrans/Makefile 441004 
> 2017-05-16 15:28:53Z tijl $
> Poudriere version: 3.1.19-51-g177d9e6d
> Host OSVERSION: 1200033
> Jail OSVERSION: 1200039
> Job Id: 06
> 
> 
> 
> 
> !!! Jail is newer than host. (Jail: 1200039, Host: 1200033) !!!
> !!! This is not supported. !!!
> !!! Host kernel must be same or newer than jail. !!!
> !!! Expect build failures. !!!
> 
> 
> 
> ---Begin Environment---
> SHELL=/bin/csh
> OSVERSION=1200039
> UNAME_v=FreeBSD 12.0-CURRENT 1200039
> UNAME_r=12.0-CURRENT
> BLOCKSIZE=K
> MAIL=/var/mail/root
> STATUS=1
> SAVED_TERM=
> MASTERMNT=/usr/local/poudriere/data/.m/head-amd64-default/ref
> PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
> POUDRIERE_BUILD_TYPE=bulk
> PKGNAME=simutrans-120.2.2
> OLDPWD=/
> PWD=/usr/local/poudriere/data/.m/head-amd64-default/ref/.p/pool
> MASTERNAME=head-amd64-default
> SCRIPTPREFIX=/usr/local/share/poudriere
> USER=root
> HOME=/root
> POUDRIERE_VERSION=3.1.19-51-g177d9e6d
> SCRIPTPATH=/usr/local/share/poudriere/bulk.sh
> LIBEXECPREFIX=/usr/local/libexec/poudriere
> LOCALBASE=/usr/local
> POUDRIEREPATH=/usr/local/bin/poudriere
> ---End Environment---
> 
> ---Begin Poudriere Port Flags/Env---
> PORT_FLAGS=
> PKGENV=
> ---End Poudriere Port Flags/Env---
> 
> ---Begin OPTIONS List---
> ===> The following configuration options are available for simutrans-120.2.2: 
>  
>  DOCS=on: Build and/or install documentation
> > Options available for the multi PAK: you have to choose at least one of 
> them  
>  PAK64=on: Default graphics
>  PAK128=off: High resolution graphics
> ===> Use 'make config' to modify these settings  
> ---End OPTIONS List---
> 
> --CONFIGURE_ARGS--
> 
> --End CONFIGURE_ARGS--
> 
> --CONFIGURE_ENV--
> SDL_CONFIG=/usr/local/bin/sdl-config MAKE=gmake 
> XDG_DATA_HOME=/wrkdirs/usr/ports/games/simutrans/work  
> XDG_CONFIG_HOME=/wrkdirs/usr/ports/games/simutrans/work  
> HOME=/wrkdirs/usr/ports/games/simutrans/work TMPDIR="/tmp" SHELL=/bin/sh 
> CONFIG_SHELL=/bin/sh
> --End CONFIGURE_ENV--
> 
> --MAKE_ENV--
> SDL_CONFIG=/usr/local/bin/sdl-config 
> XDG_DATA_HOME=/wrkdirs/usr/ports/games/simutrans/work  
> XDG_CONFIG_HOME=/wrkdirs/usr/ports/games/simutrans/work  
> HOME=/wrkdirs/usr/ports/games/simutrans/work TMPDIR="/tmp" NO_PIE=yes 
> MK_DEBUG_FILES=no MK_KERNEL_SYMBOLS=no SHELL=/bin/sh NO_LINT=YES 
> PREFIX=/usr/local  LOCALBASE=/usr/local  LIBDIR="/usr/lib"  CC="cc" 
> CFLAGS="-O2 -pipe  -fstack-protector -fno-strict-aliasing"  CPP="cpp" 
> CPPFLAGS=""  LDFLAGS=" -fstack-protector" LIBS=""  CXX="c++" CXXFLAGS="-O2 
> -pipe -fstack-protector -fno-strict-aliasing "  MANPREFIX="/usr/local" 
> BSD_INSTALL_PROGRAM="install  -s -m 555"  BSD_INSTALL_LIB="install  -s -m 
> 0644"  BSD_INSTALL_SCRIPT="install  -m 555"  BSD_INSTALL_DATA="install  -m 
> 0644"  BSD_INSTALL_MAN="install  -m 444"
> --End MAKE_ENV--
> 
> --PLIST_SUB--
> OSREL=12.0
> PREFIX=%D
> LOCALBASE=/usr/local
> RESETPREFIX=/usr/local
> PORTDOCS=""
> PORTEXAMPLES=""
> LIB32DIR=lib
> DOCSDIR="share/doc/simutrans"
> EXAMPLESDIR="share/examples/simutrans"
> DATADIR="share/simutrans"
> WWWDIR="www/simutrans"
> ETCDIR="etc/simutrans"
> --End PLIST_SUB--
> 
> --SUB_LIST--
> PREFIX=/usr/local
> LOCALBASE=/usr/local
> DATADIR=/usr/local/share/simutrans
> DOCSDIR=/usr/local/share/doc/simutrans
> EXAMPLESDIR=/usr/local/share/examples/simutrans
> WWWDIR=/usr/local/www/simutrans
> ETCDIR=/usr/local/etc/simutrans
> --End SUB_LIST--
> 
> ---Begin make.conf---
> USE_PACKAGE_DEPENDS=yes
> BATCH=yes
> WRKDIRPREFIX=/wrkdirs
> PORTSDIR=/usr/ports
> PACKAGES=/packages
> DISTDIR=/distfiles
> PACKAGE_BUILDING=yes
>  /usr/local/etc/poudriere.d/make.conf 
> # XXX: We really need this but cannot use it while 'make checksum' does not
> # try the next mirror on checksum failure.  It currently retries the same
> # failed mirror and then fails rather then trying another.  It *does*
> # try the next if the size is mismatched though.
> #MASTER_SITE_FREEBSD=yes
> # Build ALLOW_MAKE_JOBS_PACKAGES with 2 jobs
>

[Bug 218808] www/firefox: usr/bin/ld: error: unknown argument: --warn-unresolved-symbols (WITH_LLD_IS_LD)

2017-07-28 Thread bugzilla-noreply 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218808

O. Hartmann  changed:

   What|Removed |Added

Summary|www/firefox: usr/bin/ld:|www/firefox: usr/bin/ld:
   |error: unknown argument:|error: unknown argument:
   |--warn-unresolved-symbols   |--warn-unresolved-symbols
   ||(WITH_LLD_IS_LD)

--- Comment #8 from O. Hartmann  ---
I'll keep this bug open just in case someone is searching for fallout of option
WITH_LLD_IS_LS=yes.

The problem seems to disappear when going the "GNU ld" path ...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"