[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 Garrett Cooper,425-314-3911 changed: What|Removed |Added Resolution|--- |FIXED Status|In Progress |Closed --- Comment #12 from Garrett Cooper,425-314-3911 --- Closing bug. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490
--- Comment #11 from Warner Losh ---
P.S. If you want to paper over it in a different way, you could add a '-' after
the @ in the rm -rf ${CANONICALOBJDIR} line. That would cause errors to just be
ignored.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490
--- Comment #10 from Warner Losh ---
Ian: the problem is that directory foo has a subdir bar. So running rm -rf in
both foo and foo/bar (especially when there are several bars) is what causes
the issue. rm was too stupid to not generate an error when it was trying to
read an entry that went away by some other agent. bde thinks this is a
standards violation, but I'm not convinced by his reasoning. Adding actual
debugging to rm shows that running in both is the issue, and it fails to
properly ignore the ENOENT it gets when reading the subdir..
This is caused, I think, by not waiting for all subdirs to finish in clean
targets before doing the current directory. Or maybe the -Rf in the first place
is the bug that's masking this not waiting.
I believe the -rf in question is in bsd.obj.mk where it deletes the
CANONICALOBJDIR since CLEANDIRS isn't used in the sys/modules tree. It would
appear that the for loop in bsd.subdir.mk that has the ${__target}:
${__subdir_targets} dependency isn't strong enough to force the recursion to
finish before the current target is run. That might be a fruitful line to try
to investigate. If you fix that, then the -r likely can go away if you think
about it (though we'd need to add a seperate rmdir to get the same effect,
which would have the added benefit of catching when the directory isn't empty
due to missing CLEANFILES, since our build system has opted for the "you must
list everything" approach elsewhere the -rf is a bit of a outliner in the
current system).
So by all means, look at the build system, but it is my belief that the fix in
rm is actually standards-ly correct and fixes this bug. A build-system fix
would help those systems with rm that isn't quite standards compliant.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 --- Comment #9 from Ian Lepore --- I've been digging into the actual build system problem, and I'm starting to think that all the reported failures that contain enough of the log to be useful show that the build failed in a directory that has subdirectories. That is, one of the failures appeared to be caused by rm -rf running concurrently in usr.bin/lex and usr.bin/lex/lib. Another failure involves modules/aic7xxx and modules/aic7xxx/ahc. In another log it appeared that ata/atapci/chipsets was being deleted simulataneously with ata/atapci/chipsets/ataacard and several other subdirs under chipsets/. I didn't see any evidence that the exact same path was being multiply deleted at the same time. That is, no duplicated entries in SUBDIR lists or accidentally processing the entire sys/modules hiearchy twice in parallel somehow through two different parent paths or anything like that. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 Garrett Cooper changed: What|Removed |Added See Also||https://bugs.freebsd.org/bu ||gzilla/show_bug.cgi?id=1941 ||32 -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 Garrett Cooper changed: What|Removed |Added Assignee|i...@freebsd.org |i...@freebsd.org -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 Garrett Cooper changed: What|Removed |Added Status|Issue Resolved |In Discussion Resolution|FIXED |--- --- Comment #8 from Garrett Cooper --- Reopening the bug because in retrospect the underlying issue has not been resolved -- it has been worked around with r268376. There are actually two bugs: 1. (Cause) rm -Rf is being run on a path and a subdirectory concurrently. 2. (Effect) rm -Rf is failing because fts_read isn't properly filtering out certain errors like EACCES, ENOENT and EPERM. imp@ resolved 2. (but there are other issues that were introduced with the commit as it ignores all errors with fts_* according to the rm(1) manpage). ian@ is looking into 1. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 Glen Barber changed: What|Removed |Added Status|Needs MFC |Issue Resolved Resolution|--- |FIXED --- Comment #7 from Glen Barber --- r272372 -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 Garrett Cooper changed: What|Removed |Added CC||h...@sendmail.cz --- Comment #6 from Garrett Cooper --- *** Bug 193558 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 Garrett Cooper changed: What|Removed |Added Assignee|freebsd-b...@freebsd.org|i...@freebsd.org -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 Warner Losh changed: What|Removed |Added Status|Issue Resolved |Needs MFC Resolution|FIXED |--- --- Comment #5 from Warner Losh --- Yes. It does. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 --- Comment #4 from Garrett Cooper --- The fix hasn't been MFCed to stable/10 or stable/9 though... should it? -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 Warner Losh changed: What|Removed |Added Status|Needs Triage|Issue Resolved Resolution|--- |FIXED --- Comment #3 from Warner Losh --- Already fixed, as Garrett states. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 Garrett Cooper changed: What|Removed |Added CC||i...@freebsd.org, ||rodr...@freebsd.org --- Comment #2 from Garrett Cooper --- This may have already been addressed by imp@ in https://svnweb.freebsd.org/base?view=revision&revision=268376 . I can't verify what version of FreeBSD the jenkins server or kyua servers are running though, so I don't know if this bug happened before or after the enhancement was made to rm to ignore fts_read errors with rm -f. -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 --- Comment #1 from yaneurab...@gmail.com --- Created attachment 145486 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=145486&action=edit Build log >From http://kyua3.nyi.freebsd.org/head/data/0-LATEST/output.log -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
[Bug 192490] [build] race condition with multiple instances of cleandir in subdirectories; results in failure like "rm: fts_read: No such file or directory"
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192490 yaneurab...@gmail.com changed: What|Removed |Added CC||freebsd-toolchain@FreeBSD.o ||rg, j...@freebsd.org -- You are receiving this mail because: You are on the CC list for the bug. ___ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
