[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

--- Comment #28 from David Chisnall  ---
Ah, I see.  It would have helped if your reduced test case had used #include
 instead of #include .

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

--- Comment #27 from fernando.apesteg...@gmail.com ---
(In reply to David Chisnall from comment #25)
In 10.2 and below OpenVSP compiles without these modifications. It is in
11-CURRENT where it started to fail when we landed the new clang/libc++

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

--- Comment #26 from Raphael Kubo da Costa  ---
Well, that's FreeBSD 10.2, where the port was already working. The problem only
happens in HEAD after a newer libc++ was imported.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

--- Comment #25 from David Chisnall  ---
Works for me:

$ clang++ -c foo.cc
$ clang++ -v
FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) 20140512
Target: x86_64-unknown-freebsd10.2
Thread model: posix
Selected GCC installation:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

--- Comment #22 from Raphael Kubo da Costa  ---
(In reply to David Chisnall from comment #21)
> This patch looks more complicated than it needs to be.  Wouldn't inserting:
> 
> using ::array;
> 
> Immediately after the definition of array work?

It doesn't seem to work:

% cat foo.cc
#include 
using namespace std;  // Not doing that here doesn't help, as it can be done
indirectly from another file included before this one.
template
struct array {
array(T t);
};
using ::array;
template
array::array(T t) {}

% clang++ -c foo.cc
foo.cc:9:1: error: unknown type name 'array'
array::array(T t) {}
^
foo.cc:9:6: error: expected unqualified-id
array::array(T t) {}
 ^
2 errors generated.

> Alternatively, changing the
> uses  of array to ::array would also work without sticking array in a
> namespace.

That solves the issue for users of the array class, but not for array.h itself
(plus the same amount of lines would need to be changed be it to "::array" or
"openvsp_array".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

David Chisnall  changed:

   What|Removed |Added

 CC||thera...@freebsd.org

--- Comment #21 from David Chisnall  ---
This patch looks more complicated than it needs to be.  Wouldn't inserting:

using ::array;

Immediately after the definition of array work?  Alternatively, changing the
uses  of array to ::array would also work without sticking array in a
namespace.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

--- Comment #19 from commit-h...@freebsd.org ---
A commit references this bug:

Author: rakuco
Date: Thu Feb 25 22:21:38 UTC 2016
New revision: 409563
URL: https://svnweb.freebsd.org/changeset/ports/409563

Log:
  Add patches to fix the build on FreeBSD 11 with libc++.

  OpenVSP does something like this:
using namespace std;
class array {
  ...
};

  Which causes the build to fail with HEAD's libc++. Even though the port does
  not use -std=c++11, libc++ still declares an array class that conflicts with
  the one OpenVSP has.

  Enclose OpenVSP's array declaration in a namespace to avoid these conflicts.

  PR:   207253
  Approved by:  fernando.apesteg...@gmail.com (maintainer)

Changes:
  head/cad/openvsp/files/patch-src_util__code_array.h
  head/cad/openvsp/files/patch-src_vsp_af.cpp
  head/cad/openvsp/files/patch-src_vsp_havoc__geom.cpp
  head/cad/openvsp/files/patch-src_vsp_havoc__geom.h

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

Raphael Kubo da Costa  changed:

   What|Removed |Added

   Assignee|freebsd-ports-bugs@FreeBSD. |rak...@freebsd.org
   |org |
 Resolution|--- |FIXED
 Status|Open|Closed

--- Comment #20 from Raphael Kubo da Costa  ---
Landed, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

Raphael Kubo da Costa  changed:

   What|Removed |Added

 Attachment #167391|maintainer-approval?(fernan |maintainer-approval+
  Flags|do.apesteg...@gmail.com)|

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

--- Comment #18 from fernando.apesteg...@gmail.com ---
(In reply to Raphael Kubo da Costa from comment #17)

Yes, please. And thanks to come up with the patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

--- Comment #16 from fernando.apesteg...@gmail.com ---
Comment on attachment 167391
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=167391
Enclose array in a namespace

I added two new poudriere logs for {9.3,10.2}amd64. I can also confirm the
application runs fine on 10.2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

fernando.apesteg...@gmail.com changed:

   What|Removed |Added

 Attachment #167090|0   |1
is obsolete||

--- Comment #15 from fernando.apesteg...@gmail.com ---
Created attachment 167409
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=167409=edit
poudriere log on 10.2-RELEASE-amd64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

Raphael Kubo da Costa  changed:

   What|Removed |Added

 CC||fernando.apesteguia@gmail.c
   ||om
 Attachment #167391||maintainer-approval?(fernan
  Flags||do.apesteg...@gmail.com)

--- Comment #13 from Raphael Kubo da Costa  ---
Created attachment 167391
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=167391=edit
Enclose array in a namespace

(In reply to Dimitry Andric from comment #11) 
> Well, try to report this to libc++ upstream, and see what they say.  I don't
> much feel like hacking our local copy with some change that will conflict
> with whatever upstream is doing, let alone that we cannot do anything about
> the existing copies of libc++ out there.

OK. I was hoping you'd be willing to do that as it happened a few other times
in the past.

(In reply to fernando.apesteguia from comment #12)
> What strikes me is that the very same software works on FreeBSD 9.x and 10.x
> without issues
> (http://portsmon.freebsd.org/portoverview.py?category=cad=openvsp).
> So something must have changed in libc++. I'm afraid we can break other
> software as stupid as they can be using names. I think it's worth having a
> look at what it changed around July 2015 that was when the port started
> failing.

What changed is that libc++ and the rest of clang/LLVM were updated to more
recent versions during that period, and these new versions introduced the
changes that are breaking OpenVSP.

> I'm working on the port of OpenVSP 3.0 but it requires the addition of other
> ports first and it will take a while. In the meantime I would rather compile
> OpenVSP with gcc as the patch purposes instead of working on a new patch for
> the code.

Please take a look at this patch I'm attaching. It builds fine on HEAD for me,
and doesn't force the use of GCC.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

--- Comment #10 from fernando.apesteg...@gmail.com ---
(In reply to Raphael Kubo da Costa from comment #9)

I think it is not doing the right thing. Have a look at this[1]. std::array is
a feature introduced in C++11 and the software is not using C++11 features.

[1] http://www.cplusplus.com/reference/array/array/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

--- Comment #9 from Raphael Kubo da Costa  ---
I agree, but this is legacy software (version 3 doesn't even have its own array
implementation anymore as far as I can see) that won't be changed upstream.

My question is if libc++ is right in declaring std::array when not in C++11
mode or if this clash shouldn't happen at all, even if what the program does is
dangerous.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

--- Comment #8 from Dimitry Andric  ---
I think the program should not try to use both "using namespace std", and then
use a reserved C++11 name.  It should either drop the "using namespace std", or
rename its own array to e.g. openvsp_array or even better, ovenvsp::array.

In general, try to avoid "using namespace std".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"

[Bug 207253] cad/openvsp: Fix in 11-CURRENT

[bugzilla-noreply]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207253

Raphael Kubo da Costa  changed:

   What|Removed |Added

 CC||freebsd-toolchain@FreeBSD.o
   ||rg

--- Comment #7 from Raphael Kubo da Costa  ---
+freebsd-toolchain. Can someone take a look at comment #6 and check if libc++
is working as intended?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
freebsd-toolchain@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"