[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

2015-06-01 Thread dim (Dimitry Andric)
dim added a comment.

@imp, so are your concerns now addressed? I didn't expect many ports to fail, 
and there were just a handful, three of which were actual errors (they indended 
to run ${CC}, but somebody typo'd CC instead).


REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D1932

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: dim, emaste, theraven, imp, bdrewery
Cc: bdrewery, kib, imp, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org


[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

2015-05-29 Thread dim (Dimitry Andric)
dim added a comment.

An exp-run was requested in bug 200477 https://bugs.freebsd.org/200477.  Out 
of ~25000 ports, only 5 failed, and those have been trivially fixed.
The ports tree no longer requires CC to exist.


REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D1932

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: dim, emaste, theraven, imp, bdrewery
Cc: bdrewery, kib, imp, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org


[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

2015-05-27 Thread theraven (David Chisnall)
theraven added a comment.

It is problematic for the compiler to differentiate between being invoked as CC 
and as cc (clang and gcc both have to work on case-insensitive filesystems).  
The convention to have CC as an alias for c++ comes from some SysV platforms 
(though not from Linux, which does not install the CC alias).  On OS X, cc and 
CC are the same file, as the filesystem is case preserving but not case 
sensitive.

As a result of this, we have been carrying around patches to clang to make it 
detect that it is being invoked as CC for a while, to avoid breaking every 
single cmake-built C++ program (a few hundred ports) that defaults to CC as the 
C++ compiler (for Solaris/IRIX compatibility), but will happily fall back to 
using c++ instead.

Aside from the cost of maintaining this patch, this also adds a place where the 
obj dir / install sysroot must be on a case-sensitive filesystem, which harms 
attempts to make FreeBSD cross-buildable from OS X / Windows (we are careful to 
avoid this requirement for the src tree and have an svn hook to prevent it).

The CC alias does not work on Linux or OS X, so the likelihood of this breaking 
third-party code is minimal and the pain that it has already caused is 
nontrivial.


REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D1932

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: dim, emaste, theraven, imp
Cc: kib, imp, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org


[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

2015-05-27 Thread kib (Konstantin Belousov)
kib added a subscriber: kib.
kib added a comment.

On what standard the name of the C++ compiler is based, at all ?
What are supposed benefits of the change ?

I believe I already noted elsewhere to dim that the CC is long-time established 
name.  Not all software built on FreeBSD live in the ports framework.  Loosing 
zero-cost convenience feature is not very smart.


REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D1932

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: dim, emaste, theraven, imp
Cc: kib, imp, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org


[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

2015-05-26 Thread imp (Warner Losh)
imp added a comment.

CC has been an alias for the default C++ compiler the entire life FreeBSD has 
had a C++ compiler.

Sure, it isn't based on any standards but it is a very de-facto standard that 
many ports rely on.
FreeBSD isn't the only system to do this. Sun did this for years, as did SGI, 
and many other folks
that had a C++ compiler based on cfront. IIRC CC was a shell script front end 
for cfront in at least
the cfront 2.0 and 3.0 time frame. Many ISV's compilersr picked up on this 
de-facto standard and
have been providing the link for a long time.


REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D1932

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: dim, emaste, theraven
Cc: imp, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org


[Differential] [Commented On] D1932: Remove the non-standard CC alias for c++

2015-05-26 Thread emaste (Ed Maste)
emaste added a comment.

In https://reviews.freebsd.org/D1932#49686, @imp wrote:

 it is a very de-facto standard that many ports rely on.


Many ports will choose CC if it exists, but I'm not sure they rely on it. 
Autoconf and cmake builds will try a list and if they pick c++ next they'll be 
fine.
exp-run requested in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200475


REPOSITORY
  rS FreeBSD src repository

REVISION DETAIL
  https://reviews.freebsd.org/D1932

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: dim, emaste, theraven, imp
Cc: imp, freebsd-toolchain
___
freebsd-toolchain@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain
To unsubscribe, send any mail to freebsd-toolchain-unsubscr...@freebsd.org