Re: usb/106435: Possible buffer overflow in dev/usb/ums.c

2006-12-09 Thread Markus Brueffer
Synopsis: Possible buffer overflow in dev/usb/ums.c

Responsible-Changed-From-To: freebsd-usb-markus
Responsible-Changed-By: markus
Responsible-Changed-When: Sat Dec 9 13:08:55 UTC 2006
Responsible-Changed-Why: 
I'll handle this one.

http://www.freebsd.org/cgi/query-pr.cgi?pr=106435
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to [EMAIL PROTECTED]


Re: usb/106435: Possible buffer overflow in dev/usb/ums.c

2006-12-08 Thread Eygene Ryabinkin
Sorry, missed the double quote in the patch. The real patch
should be:

--- ums.c.orig  Tue Dec  5 13:29:34 2006
+++ ums.c   Tue Dec  5 13:31:40 2006
@@ -431,9 +431,10 @@
 #define UMS_BUT(i) ((i)  3 ? (((i) + 2) % 3) : (i))
 
DPRINTFN(5, (ums_intr: sc=%p status=%d\n, sc, status));
-   DPRINTFN(5, (ums_intr: data = %02x %02x %02x %02x %02x %02x\n,
-sc-sc_ibuf[0], sc-sc_ibuf[1], sc-sc_ibuf[2],
-sc-sc_ibuf[3], sc-sc_ibuf[4], sc-sc_ibuf[5]));
+   DPRINTFN(5, (ums_intr: data =));
+   for (i = 0; i  sc-sc_isize; i++)
+   DPRINTFN(5, ( %02x, sc-sc_ibuf[i]));
+   DPRINTFN(5, (\n));
 
if (status == USBD_CANCELLED)
return;
-- 
Eygene
___
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to [EMAIL PROTECTED]