[Differential] D1309: VIMAGE PF fixes #1

2018-10-28 Thread kristof (Kristof Provost) 
kristof closed this revision.
kristof added a comment.
Herald added subscribers: farrokhi, ae.


  Assorted pf VIMAGE fixes have been done, and pf is now usable inside VIMAGE 
jails.

CHANGES SINCE LAST ACTION
  https://reviews.freebsd.org/D1309/new/

REVISION DETAIL
  https://reviews.freebsd.org/D1309

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: rodrigc, #network, trociny, glebius, gnn, bz, zec
Cc: ae, farrokhi, kristof, robak, emaste, freebsd-virtualization-list, 
freebsd-pf-list, freebsd-net-list
___
freebsd-virtualization@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-virtualization
To unsubscribe, send any mail to 
"freebsd-virtualization-unsubscr...@freebsd.org"

[Differential] D1944: PF and VIMAGE fixes

2016-08-16 Thread kristof (Kristof Provost) 
kristof abandoned this revision.

REVISION DETAIL
  https://reviews.freebsd.org/D1944

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: kristof, trociny, gnn, zec, rodrigc, glebius, eri, bz, nvass-gmx.com
Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com, farrokhi, julian, robak, 
freebsd-virtualization-list, freebsd-pf-list, freebsd-net-list
___
freebsd-virtualization@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-virtualization
To unsubscribe, send any mail to 
"freebsd-virtualization-unsubscr...@freebsd.org"

[Differential] D1944: PF and VIMAGE fixes

2016-08-16 Thread kristof (Kristof Provost) 
kristof commandeered this revision.
kristof edited reviewers, added: nvass-gmx.com; removed: kristof.
kristof added a comment.


  I'm commandeering this so it can be closed, because the patch fro bz@ 
(https://reviews.freebsd.org/D6924) has been included.

REVISION DETAIL
  https://reviews.freebsd.org/D1944

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: kristof, trociny, gnn, zec, rodrigc, glebius, eri, bz, nvass-gmx.com
Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com, farrokhi, julian, robak, 
freebsd-virtualization-list, freebsd-pf-list, freebsd-net-list
___
freebsd-virtualization@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-virtualization
To unsubscribe, send any mail to 
"freebsd-virtualization-unsubscr...@freebsd.org"

[Differential] D1944: PF and VIMAGE fixes

2016-04-24 Thread kristof (Kristof Provost) 
kristof added inline comments.

INLINE COMMENTS
  sys/netpfil/pf/pf_if.c:130 I don't understand why this is required. Surely if 
an ifnet lives in V_ifnet (so, lives in the current vnet) ifp->if_vnet is 
always going to be curvnet?
  sys/netpfil/pf/pf_if.c:141 Why add curvnet here?
  pfi_attach_ifnet_event doesn't use its argument.
  sys/netpfil/pf/pf_if.c:143 Same as above.
  sys/netpfil/pf/pf_if.c:151 Same as above.
  sys/netpfil/pf/pf_if.c:814 I believe this is correct, but should probably 
include adding an __unused annotation to arg, and removing the 'curvnet' 
argument from the EVENTHANDLER_REGISTER() call.

REVISION DETAIL
  https://reviews.freebsd.org/D1944

EMAIL PREFERENCES
  https://reviews.freebsd.org/settings/panel/emailpreferences/

To: nvass-gmx.com, bz, trociny, kristof, gnn, zec, rodrigc, glebius, eri
Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com, farrokhi, julian, robak, 
freebsd-virtualization-list, freebsd-pf-list, freebsd-net-list
___
freebsd-virtualization@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-virtualization
To unsubscribe, send any mail to 
"freebsd-virtualization-unsubscr...@freebsd.org"

[Differential] [Commented On] D1944: PF and VIMAGE fixes

2015-03-26 Thread kristof (Kristof Provost) 
kristof added inline comments.

INLINE COMMENTS
  sys/netpfil/pf/pf_ioctl.c:325 It's not clear to me why this is done here, 
rather than in pf_unload(). The initialisation is done in pf_load() after all.
  sys/netpfil/pf/pf_ioctl.c:3725 Don't we still need to do all of this 
somewhere?

REVISION DETAIL
  https://reviews.freebsd.org/D1944

To: nvass-gmx.com, gnn, bz, zec, trociny, glebius, rodrigc, kristof
Cc: freebsd-virtualization, freebsd-pf, freebsd-net
___
freebsd-virtualization@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization
To unsubscribe, send any mail to 
freebsd-virtualization-unsubscr...@freebsd.org