Re: [Freeciv-Dev] 2.1.5

2008-06-06 Thread Marko Lindqvist
2008/6/6 Daniel Markstedt:
 On 6/5/08, Marko Lindqvist wrote:
 2008/5/26 Daniel Markstedt:

   One week later it is; Targeted release date June 8.

  Freeciv doesn't compile with current gcc 4.3 branch, and 4.3.1 will
  be released any day now.


 Is this reason enough to postpone the 2.1.5 in your opinion?

 If we release 2.1.5 without fix for this, we need to release 2.1.6
rather soon. I believe that otherwise there could be rather long time
between 2.1.5 and 2.1.6. So yes, I think we should postpone 2.1.5.
 Of course, if someone else plans to make lot of fixes to S2_1, making
2.1.6 release soon after 2.1.5 more sensible, situation is quite
different.

 Madeline?


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] 2.1.5

2008-06-06 Thread Madeline Book
On 6/6/08, Marko Lindqvist [EMAIL PROTECTED] wrote:
 2008/6/6 Daniel Markstedt:

  On 6/5/08, Marko Lindqvist wrote:
   2008/5/26 Daniel Markstedt:
  
 One week later it is; Targeted release date June 8.
  
Freeciv doesn't compile with current gcc 4.3 branch, and 4.3.1 will
be released any day now.
  
  
   Is this reason enough to postpone the 2.1.5 in your opinion?


  If we release 2.1.5 without fix for this, we need to release 2.1.6
  rather soon. I believe that otherwise there could be rather long time
  between 2.1.5 and 2.1.6. So yes, I think we should postpone 2.1.5.
   Of course, if someone else plans to make lot of fixes to S2_1, making
  2.1.6 release soon after 2.1.5 more sensible, situation is quite
  different.

   Madeline?

In my opinion the fixes for S2_1 that I have encountered recently are
all rather minor and could wait for later; I am still more focused on working
on the editor. What might be nice is to release 2.1.5 so it can be used
for the first 2.1.x longturn game (which will probably start in a week or two),
which will give some good testing data and should find more bugs.

I don't know much at all about the gcc bug (actually I had 4.3 installed
a while ago, but since I had some problems not just with freeciv I am
now using 3.4.6).

Since I don't know how much hassle it is to make a full release for
freeciv I would tend to support more releases more often. Since then
the program can be advertised on various sites and users can have
the feeling that progress is being made. ;)


-
ファンのためにやりましょう!

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40258) freeciv and gcc 4.3

2008-06-06 Thread Jason Dorje Short

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40258 

I heard a rumor that freeciv (S2_1) didn't compile with gcc 4.3.  So I 
installed it and tried it.  I found only one error in the default 
compilation, fixed by this simple patch.  This surely applies to 2.2 and 
trunk as well.

-jason

Index: client/cityrepdata.c
===
--- client/cityrepdata.c	(revision 14712)
+++ client/cityrepdata.c	(working copy)
@@ -633,6 +633,7 @@
   int len = right - left;
 
   dat-is_numeric = FALSE;
+  dat-numeric_value = 0;
   dat-string_value = fc_malloc(len + 1);
   memcpy(dat-string_value, left, len);
   dat-string_value[len] = 0;
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


Re: [Freeciv-Dev] (PR#40258) freeciv and gcc 4.3

2008-06-06 Thread Jason Dorje Short

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40258 

Jason Dorje Short wrote:
 URL: http://bugs.freeciv.org/Ticket/Display.html?id=40258 
 
 I heard a rumor that freeciv (S2_1) didn't compile with gcc 4.3.  So I 
 installed it and tried it.  I found only one error in the default 
 compilation, fixed by this simple patch.  This surely applies to 2.2 and 
 trunk as well.

[EMAIL PROTECTED]:~/src/freeciv/freeciv-2.1$ gcc --version
gcc-4.3 (Debian 4.3.0-5) 4.3.1 20080523 (prerelease)
Copyright (C) 2008 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


cc1: warnings being treated as errors
cityrepdata.c: In function ‘split_string’:
../utility/specvec.h:126: error: ‘d.numeric_value’ may be used 
uninitialized in this function
cityrepdata.c:747: note: ‘d.numeric_value’ was declared here
cityrepdata.c:729: error: ‘d.string_value’ may be used uninitialized in 
this function
cityrepdata.c:729: error: ‘d.numeric_value’ may be used uninitialized in 
this function


A bizarre and completely harmless warning as the numeric_value value is 
not, in fact, being used.  But whatever.


-jason



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] (PR#40259) significant 2.1 memory leak

2008-06-06 Thread Jason Dorje Short

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40259 

==14996== 404,976 bytes in 386 blocks are possibly lost in loss record 
175 of 179
==14996==at 0x4021A92: memalign (vg_replace_malloc.c:460)
==14996==by 0x4021B3F: posix_memalign (vg_replace_malloc.c:569)
==14996==by 0x45CBCE3: (within /usr/lib/libglib-2.0.so.0.1600.3)
==14996==by 0x45CCEF0: g_slice_alloc (in 
/usr/lib/libglib-2.0.so.0.1600.3)
==14996==by 0x45CD004: g_slice_alloc0 (in 
/usr/lib/libglib-2.0.so.0.1600.3)
==14996==by 0x455EAA6: g_type_create_instance (in 
/usr/lib/libgobject-2.0.so.0.1600.3)
==14996==by 0x45441E1: (within /usr/lib/libgobject-2.0.so.0.1600.3)
==14996==by 0x45449A7: g_object_newv (in 
/usr/lib/libgobject-2.0.so.0.1600.3)
==14996==by 0x454: g_object_new_valist (in 
/usr/lib/libgobject-2.0.so.0.1600.3)
==14996==by 0x454565F: g_object_new (in 
/usr/lib/libgobject-2.0.so.0.1600.3)
==14996==by 0x4452D23: gdk_pixbuf_new_from_data (in 
/usr/lib/libgdk_pixbuf-2.0.so.0.1200.9)
==14996==by 0x4450F2E: gdk_pixbuf_copy (in 
/usr/lib/libgdk_pixbuf-2.0.so.0.1200.9)
==14996==by 0x812EE0D: crop_sprite (sprite.c:60)
==14996==by 0x808AED4: tileset_lookup_sprite_tags (tilespec.c:2376)
==14996==by 0x808C8E1: tileset_load_tiles (tilespec.c:2504)
==14996==by 0x8113FCA: ui_main (gui_main.c:1430)
==14996==by 0x8058CE2: main (civclient.c:404)

I'm not quite sure if this is lost during the ctor_sprite process or 
later when insert_sprite is called.  Either way seems strange.  But it's 
a fair amount of memory.

There's also a number of other smaller (but perhaps easier to track) leaks.

-jason



___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev