[Freeciv-Dev] (PR#40741) [Patch] Fix shared vision city visibility

2009-03-06 Thread Marko Lindqvist 

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40741 

 City information is not copied from player map to player map with
shared vision treaty. Instead dest player gets just initialized site
structure.

 Fix attached


 - ML

diff -Nurd -X.diff_ignore freeciv/server/maphand.c freeciv/server/maphand.c
--- freeciv/server/maphand.c	2009-02-26 21:16:19.0 +0200
+++ freeciv/server/maphand.c	2009-03-06 16:08:10.0 +0200
@@ -1055,11 +1055,11 @@
   dest_tile-bases= from_tile-bases;
   dest_tile-last_updated = from_tile-last_updated;
   send_tile_info(pdest-connections, ptile, FALSE);
-	
+
   /* update and send city knowledge */
   /* remove outdated cities */
-  if (dest_tile-site  dest_tile-site-location == ptile) {
-	if (!from_tile-site || from_tile-site-location != ptile) {
+  if (dest_tile-site) {
+	if (!from_tile-site) {
 	  /* As the city was gone on the newer from_tile
 	 it will be removed by this function */
 	  reality_check_city(pdest, ptile);
@@ -1073,13 +1073,12 @@
   }
 
   /* Set and send new city info */
-  if (from_tile-site  from_tile-site-location == ptile) {
-	if (!dest_tile-site || dest_tile-site-location != ptile) {
-	  change_playertile_site(dest_tile, NULL);
-
+  if (from_tile-site) {
+	if (!dest_tile-site) {
   /* We cannot assign new vision site with change_playertile_site(),
* since location is not yet set up for new site */
-  dest_tile-site = create_vision_site(0, NULL, NULL);
+  dest_tile-site = create_vision_site(0, ptile, NULL);
+  *dest_tile-site = *from_tile-site;
 	}
 /* Note that we don't care if receiver knows vision source city
  * or not. */
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [Freeciv-i18n] A new 2.1 release may happen soon

2009-03-06 Thread Marko Lindqvist 
2009/3/5 Joe Dalton joedalt...@yahoo.dk:

 Hi

 http://www.cazfi.net/freeciv/translations/S2_1/
 has not been updated

 It updates only when ever I have time and remember to run update-po.

 I just did :-)


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40743) Split chat/message window crash

2009-03-06 Thread Madeline Book 

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40743 

 [bjo...@gmail.com - Fri Mar 06 04:30:41 2009]:
 
 I keep getting segfaults when I double click on the [Messages X] title
 tab to separate it, with dual/split chat and messages enabled.
 
 The separate window pops up then whole thing dies.
 
 Program received signal SIGSEGV, Segmentation fault.
 [Switching to Thread 0xb6e559b0 (LWP 15070)]
 0xb7caf3e0 in gtk_notebook_button_release (widget=0xad58ae0,
 event=0xc2c8f40)
 at /build/buildd/gtk+2.0-2.14.4/gtk/gtknotebook.c:2825
 2825/build/buildd/gtk+2.0-2.14.4/gtk/gtknotebook.c: No such file
 or directory.
 in /build/buildd/gtk+2.0-2.14.4/gtk/gtknotebook.c

I'm starting another ticket for the issue reported in 40705.


---
明日は新たな日です。

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40743) Split chat/message window crash

2009-03-06 Thread Madeline Book 

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40743 

 [bjo...@gmail.com - Fri Mar 06 04:30:41 2009]:
 
 I keep getting segfaults when I double click on the [Messages X] title
 tab to separate it, with dual/split chat and messages enabled.
 
 The separate window pops up then whole thing dies.
 
 Program received signal SIGSEGV, Segmentation fault.
 [Switching to Thread 0xb6e559b0 (LWP 15070)]
 0xb7caf3e0 in gtk_notebook_button_release (widget=0xad58ae0,
 event=0xc2c8f40)
 at /build/buildd/gtk+2.0-2.14.4/gtk/gtknotebook.c:2825
 2825/build/buildd/gtk+2.0-2.14.4/gtk/gtknotebook.c: No such file
 or directory.
 in /build/buildd/gtk+2.0-2.14.4/gtk/gtknotebook.c

Unfortunately I cannot figure out the cause of the
crash from just that much backtrace information.
Try the steps listed in the following link for a
longer backtrace:

http://freeciv.wikia.com/wiki/Bug_Reporting

Furthermore, I cannot make the program crash trying
out the behaviour you mentioned. Perhaps something
has changed in newer gtk versions (I have 2.10.13
installed), so if a full backtrace does not reveal
the cause, I suppose I will have to upgrade gtk. :(


---
朝ご飯はハチミツだけだ。

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#40743) Split chat/message window crash

2009-03-06 Thread Brendon Oram 

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40743 

If no one else can reproduce it, it must be something wrong with my
GTK (Turn done button doesn't blink).

Ubuntu 8.10
checking for GTK+ - version = 2.4.0... yes (version 2.14.4)

(gdb) bt full
#0  0xb7dd83e0 in gtk_notebook_button_release (widget=0xb5c3ae0,
event=0xe2d14f8) at /build/buildd/gtk+2.0-2.14.4/gtk/gtknotebook.c:2825
page = (GtkNotebookPage *) 0x0
#1  0xb7db9036 in _gtk_marshal_BOOLEAN__BOXED (closure=0x9af6ac8,
return_value=0xbfc5f550, n_param_values=2, param_values=0xc761940,
invocation_hint=0xbfc5f53c, marshal_data=0xb7dd8390)
at /build/buildd/gtk+2.0-2.14.4/gtk/gtkmarshalers.c:84
data1 = (gpointer) 0xb5c3ae0
data2 = value optimized out
v_return = value optimized out
__PRETTY_FUNCTION__ = _gtk_marshal_BOOLEAN__BOXED
#2  0xb79633c9 in ?? () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#3  0xb7964c4b in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#4  0xb797ad3d in ?? () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#5  0xb797c62b in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#6  0xb797cc26 in g_signal_emit () from /usr/lib/libgobject-2.0.so.0
No symbol table info available.
#7  0xb7ece33e in gtk_widget_event_internal (widget=0xb5c3ae0, event=0xe2d14f8)
at /build/buildd/gtk+2.0-2.14.4/gtk/gtkwidget.c:4745
signal_num = value optimized out
return_val = 0
#8  0xb7db1b4c in IA__gtk_propagate_event (widget=0xb5c3ae0, event=0xe2d14f8)
at /build/buildd/gtk+2.0-2.14.4/gtk/gtkmain.c:2391
tmp = (GtkWidget *) 0xc737440
handled_event = 237835512
__PRETTY_FUNCTION__ = IA__gtk_propagate_event
#9  0xb7db2ef7 in IA__gtk_main_do_event (event=0xe2d14f8)
at /build/buildd/gtk+2.0-2.14.4/gtk/gtkmain.c:1596
event_widget = (GtkWidget *) 0xb5c3ae0
grab_widget = (GtkWidget *) 0xb5c3ae0
window_group = (GtkWindowGroup *) 0xc737440
rewritten_event = (GdkEvent *) 0x0
tmp_list = value optimized out
__PRETTY_FUNCTION__ = IA__gtk_main_do_event
#10 0xb7c4950a in gdk_event_dispatch (source=0x9af2b60, callback=0,
user_data=0x0) at /build/buildd/gtk+2.0-2.14.4/gdk/x11/gdkevents-x11.c:2365
display = value optimized out
event = value optimized out
#11 0xb78d76f8 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#12 0xb78dada3 in ?? () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#13 0xb78db2c2 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#14 0xb7db33a9 in IA__gtk_main ()
at /build/buildd/gtk+2.0-2.14.4/gtk/gtkmain.c:1200
tmp_list = (GList *) 0xbfc5fc74
functions = (GList *) 0x0
init = (GtkInitFunction *) 0x9af4358
loop = (GMainLoop *) 0xc757298
#15 0x0812663f in ui_main (argc=1, argv=0xbfc5fc74) at gui_main.c:1603
home = value optimized out
sig = value optimized out
style = value optimized out
#16 0x0805a32b in main (argc=162499072, argv=0xbfc5fc74) at civclient.c:404
i = 1
loglevel = 2
ui_options = value optimized out
ui_separator = 197
option = 0xbfc5f9e8 d��\235�004��C+\200�\200�O\037Z\001?
user_tileset = 191


On Sat, Mar 7, 2009 at 10:52 AM, Madeline Book madeline.b...@gmail.com wrote:

 URL: http://bugs.freeciv.org/Ticket/Display.html?id=40743 

 [bjo...@gmail.com - Fri Mar 06 04:30:41 2009]:

 I keep getting segfaults when I double click on the [Messages X] title
 tab to separate it, with dual/split chat and messages enabled.

 The separate window pops up then whole thing dies.

 Program received signal SIGSEGV, Segmentation fault.
 [Switching to Thread 0xb6e559b0 (LWP 15070)]
 0xb7caf3e0 in gtk_notebook_button_release (widget=0xad58ae0,
 event=0xc2c8f40)
     at /build/buildd/gtk+2.0-2.14.4/gtk/gtknotebook.c:2825
 2825    /build/buildd/gtk+2.0-2.14.4/gtk/gtknotebook.c: No such file
 or directory.
         in /build/buildd/gtk+2.0-2.14.4/gtk/gtknotebook.c

 Unfortunately I cannot figure out the cause of the
 crash from just that much backtrace information.
 Try the steps listed in the following link for a
 longer backtrace:

 http://freeciv.wikia.com/wiki/Bug_Reporting

 Furthermore, I cannot make the program crash trying
 out the behaviour you mentioned. Perhaps something
 has changed in newer gtk versions (I have 2.10.13
 installed), so if a full backtrace does not reveal
 the cause, I suppose I will have to upgrade gtk. :(


 ---
 朝ご飯はハチミツだけだ。




___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40743) Split chat/message window crash

2009-03-06 Thread Madeline Book 

URL: http://bugs.freeciv.org/Ticket/Display.html?id=40743 

 [bjo...@gmail.com - Sat Mar 07 04:50:45 2009]:
 
 If no one else can reproduce it, it must be something wrong with my
 GTK (Turn done button doesn't blink).
 
 Ubuntu 8.10
 checking for GTK+ - version = 2.4.0... yes (version 2.14.4)
 
 (gdb) bt full
 [...]

Alright, thanks for the extra information. I'll try to
figure out the cause of the crash and a way to fix it.


---
週末でさえ働かなければならなさそうですね。

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev