[Freeciv-Dev] [bug #13658] [Patch] Update T rireme flag documentation
Update of bug #13658 (project freeciv): Category:None = docs Status:None = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?13658 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13679] Autogames with same gameseed mapseed differ
URL: http://gna.org/bugs/?13679 Summary: Autogames with same gameseed mapseed differ Project: Freeciv Submitted by: cazfi Submitted on: Friday 06/12/2009 at 22:23 Category: None Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: One cannot currently rely on autogames in reggression testing. Even with the same build, autogames differ between runs. Sounds like memory bug. ___ Reply to this item at: http://gna.org/bugs/?13679 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13680] [Patch] AI calls through function pointerts, first part
URL: http://gna.org/bugs/?13680 Summary: [Patch] AI calls through function pointerts, first part Project: Freeciv Submitted by: cazfi Submitted on: Friday 06/12/2009 at 23:17 Category: None Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: AI and other server code should be better separated. This patch is first step. Call some of the AI functions through function pointers. ___ File Attachments: --- Date: Friday 06/12/2009 at 23:17 Name: AiFuncs.diff Size: 8kB By: cazfi http://gna.org/bugs/download.php?file_id=5943 ___ Reply to this item at: http://gna.org/bugs/?13680 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13681] [Pacth] Remove is_air_unit()
URL: http://gna.org/bugs/?13681 Summary: [Pacth] Remove is_air_unit() Project: Freeciv Submitted by: cazfi Submitted on: Friday 06/12/2009 at 23:49 Category: general Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: This patch gets rid of last is_air_unit() call from editor by replacing it with UCF_UNREACHABLE flag check. is_air_unit() is removed. Requires #13673 ___ File Attachments: --- Date: Friday 06/12/2009 at 23:49 Name: IsAirUnitRemoval.diff Size: 2kB By: cazfi http://gna.org/bugs/download.php?file_id=5944 ___ Reply to this item at: http://gna.org/bugs/?13681 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13654] [patch] Help for Research Lab implies that University not required
Follow-up Comment #1, bug #13654 (project freeciv): I think all this is intentional. You cannot build Research Lab without University, but if University (or Library) gets destroyed later, Research Lab is not rendered completely useless. ___ Reply to this item at: http://gna.org/bugs/?13654 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13636] [patch] update for migration
Follow-up Comment #2, bug #13636 (project freeciv): Also, CodingStyle dictates that variables are never declared in the middle of the function. You move some variable declarations from the beginning of the city_migration_score() to the middle. ___ Reply to this item at: http://gna.org/bugs/?13636 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13682] [Patch] Remove configure.in reference from CodingStyle
URL: http://gna.org/bugs/?13682 Summary: [Patch] Remove configure.in reference from CodingStyle Project: Freeciv Submitted by: cazfi Submitted on: Saturday 06/13/2009 at 00:20 Category: docs Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: We no longer have configure.in, only configure.ac. This patch updates CodingStyle accordingly. For Both TRUNK and S2_1. ___ File Attachments: --- Date: Saturday 06/13/2009 at 00:20 Name: CodingStyleCin.diff Size: 657B By: cazfi http://gna.org/bugs/download.php?file_id=5945 ___ Reply to this item at: http://gna.org/bugs/?13682 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13683] [Patch] HELI_MOVING - BOTH_MOVING
URL: http://gna.org/bugs/?13683 Summary: [Patch] HELI_MOVING - BOTH_MOVING Project: Freeciv Submitted by: cazfi Submitted on: Saturday 06/13/2009 at 01:07 Category: general Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: This patch renames HELI_MOVING as BOTH_MOVING. ___ File Attachments: --- Date: Saturday 06/13/2009 at 01:07 Name: BothMoving.diff Size: 4kB By: cazfi http://gna.org/bugs/download.php?file_id=5946 ___ Reply to this item at: http://gna.org/bugs/?13683 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13684] [Patch] AI: Check fuel, not AIR_MOVING, when determining type simpliness
URL: http://gna.org/bugs/?13684 Summary: [Patch] AI: Check fuel, not AIR_MOVING, when determining type simpliness Project: Freeciv Submitted by: cazfi Submitted on: Saturday 06/13/2009 at 01:20 Category: None Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: $subject ___ File Attachments: --- Date: Saturday 06/13/2009 at 01:20 Name: FuelSimpleType.diff Size: 542B By: cazfi http://gna.org/bugs/download.php?file_id=5947 ___ Reply to this item at: http://gna.org/bugs/?13684 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#18439) Merge AIR_MOVING and HELI_MOVING
URL: http://bugs.freeciv.org/Ticket/Display.html?id=18439
2006/7/9 Marko Lindqvist cazf...@gmail.com:
Goal is to have only three basic move_types: Land, Sea and Both.
Last should be used for air, heli and amphibious units.
Finally, this was possible to implement. Patch attached. Requires gna
tickets #13673, #13681, #13683, #13684.
- ML
diff -Nurd -X.diff_ignore freeciv/ai/aicity.c freeciv/ai/aicity.c
--- freeciv/ai/aicity.c 2009-06-13 02:09:12.0 +0300
+++ freeciv/ai/aicity.c 2009-06-13 01:41:14.0 +0300
@@ -371,7 +371,6 @@
case SEA_MOVING:
return ai-stats.units.sea;
case BOTH_MOVING:
- case AIR_MOVING:
return ai-stats.units.amphibious;
case MOVETYPE_LAST:
break;
diff -Nurd -X.diff_ignore freeciv/ai/aihunt.c freeciv/ai/aihunt.c
--- freeciv/ai/aihunt.c 2008-10-27 04:13:32.0 +0200
+++ freeciv/ai/aihunt.c 2009-06-13 01:41:32.0 +0300
@@ -314,7 +314,7 @@
if (ut-move_rate + victim-moves_left pos.total_MC
ATTACK_POWER(victim) DEFENCE_POWER(punit)
(utype_move_type(ut) == SEA_MOVING
- || utype_move_type(ut) == AIR_MOVING)) {
+ || utype_move_type(ut) == BOTH_MOVING)) {
/* Threat to our carrier. Kill it. */
sucker = victim;
UNIT_LOG(LOGLEVEL_HUNT, missile, found aux target %d(%d, %d),
diff -Nurd -X.diff_ignore freeciv/ai/aitools.c freeciv/ai/aitools.c
--- freeciv/ai/aitools.c2009-06-12 02:30:41.0 +0300
+++ freeciv/ai/aitools.c2009-06-13 02:00:48.0 +0300
@@ -664,9 +664,10 @@
if (punit-ai.ai_role != AIUNIT_HUNTER
get_transporter_capacity(punit) 0) {
unit_class_iterate(uclass) {
+ /* FIXME: BOTH_MOVING units need ferry only if they use fuel */
if (can_unit_type_transport(unit_type(punit), uclass)
(uclass-move_type == LAND_MOVING
- || (uclass-move_type == AIR_MOVING
+ || (uclass-move_type == BOTH_MOVING
!uclass_has_flag(uclass, UCF_MISSILE {
is_ferry = TRUE;
break;
diff -Nurd -X.diff_ignore freeciv/ai/aiunit.c freeciv/ai/aiunit.c
--- freeciv/ai/aiunit.c 2009-06-13 02:09:16.0 +0300
+++ freeciv/ai/aiunit.c 2009-06-13 01:43:04.0 +0300
@@ -2215,9 +2215,10 @@
if (get_transporter_capacity(punit) 0) {
unit_class_iterate(pclass) {
+ /* FIXME: BOTH_MOVING units need ferry only if they use fuel */
if (can_unit_type_transport(unit_type(punit), pclass)
(pclass-move_type == LAND_MOVING
- || (pclass-move_type == AIR_MOVING
+ || (pclass-move_type == BOTH_MOVING
!uclass_has_flag(pclass, UCF_MISSILE {
is_ferry = TRUE;
break;
diff -Nurd -X.diff_ignore freeciv/client/climisc.c freeciv/client/climisc.c
--- freeciv/client/climisc.c2009-06-13 02:09:12.0 +0300
+++ freeciv/client/climisc.c2009-06-13 01:40:57.0 +0300
@@ -1134,8 +1134,7 @@
return UNIT_BG_SEA;
}
- assert(pclass-move_type == BOTH_MOVING
- || pclass-move_type == AIR_MOVING);
+ assert(pclass-move_type == BOTH_MOVING);
if (uclass_has_flag(pclass, UCF_TERRAIN_SPEED)) {
/* Unit moves on both sea and land by speed determined by terrain */
diff -Nurd -X.diff_ignore freeciv/client/helpdata.c freeciv/client/helpdata.c
--- freeciv/client/helpdata.c 2009-06-13 02:09:12.0 +0300
+++ freeciv/client/helpdata.c 2009-06-13 01:41:04.0 +0300
@@ -1052,7 +1052,6 @@
CATLSTR(buf, bufsz, _(* Will never achieve veteran status.\n));
} else {
switch(utype_move_type(utype)) {
- case AIR_MOVING:
case BOTH_MOVING:
CATLSTR(buf, bufsz,
_(* Will be built as a veteran in cities with appropriate
diff -Nurd -X.diff_ignore freeciv/common/aicore/pf_tools.c
freeciv/common/aicore/pf_tools.c
--- freeciv/common/aicore/pf_tools.c2009-06-13 02:09:12.0 +0300
+++ freeciv/common/aicore/pf_tools.c2009-06-13 01:46:04.0 +0300
@@ -72,7 +72,7 @@
}
/*
- Cost function for AIR_MOVING and amphibious units
+ Cost function for flying and amphibious units
*/
static int airmove(const struct tile *ptile, enum direction8 dir,
const struct tile *ptile1,
@@ -686,7 +686,6 @@
parameter-get_MC = seamove_no_bombard;
}
break;
- case AIR_MOVING:
case BOTH_MOVING:
parameter-get_MC = airmove;
break;
@@ -725,7 +724,6 @@
case SEA_MOVING:
parameter-get_MC = sea_overlap_move;
break;
- case AIR_MOVING:
case BOTH_MOVING:
parameter-get_MC = airmove; /* very crude */
break;
@@ -756,7 +754,6 @@
case SEA_MOVING:
parameter-get_MC = sea_attack_move;
break;
- case AIR_MOVING:
case BOTH_MOVING:
parameter-get_MC = airmove; /* very crude
[Freeciv-Dev] [bug #13654] [patch] Help for Research Lab implies that University not required
Follow-up Comment #2, bug #13654 (project freeciv): I hadn't thought of that. I had assumed that it was not possible to have the building without its prerequisites, but I don't see any restriction in the code enforcing that; AFAICT it's perfectly possible to raze, sabotage, or sell a prerequisite. So I retract my patch. In which case, the help for Stock Exchange ought in principle to be updated; as far as I can tell (untested), a Bank + Stock Exchange have a reduced effect (100% instead of 150%) even if the Marketplace is destroyed. ___ Reply to this item at: http://gna.org/bugs/?13654 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
