[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client
Follow-up Comment #1, patch #2715 (project freeciv): I compiles! Does not work at all correctly yet. (file #13647) ___ Additional Item Attachment: File name: CairoTmp.diff.bz2 Size:13 KB ___ Reply to this item at: http://gna.org/patch/?2715 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2826] Themes directory for gtk3-client
URL: http://gna.org/patch/?2826 Summary: Themes directory for gtk3-client Project: Freeciv Submitted by: cazfi Submitted on: Sun 24 Jul 2011 09:31:24 AM EEST Category: client-gtk-3.0 Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: This patch makes gtk3-client to use its own themes directory. BNefore applying this, one should 'svn cp' data/themes/gui-gtk-2.0 to data/themes/gui-gtk-3.0 ___ File Attachments: --- Date: Sun 24 Jul 2011 09:31:24 AM EEST Name: Gtk3Themes.diff Size: 4kB By: cazfi http://gna.org/patch/download.php?file_id=13648 ___ Reply to this item at: http://gna.org/patch/?2826 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2827] Client runs server script from current directory in debug build only
URL: http://gna.org/patch/?2827 Summary: Client runs server script from current directory in debug build only Project: Freeciv Submitted by: cazfi Submitted on: Sun 24 Jul 2011 10:19:44 AM EEST Category: client Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.2.8, 2.3.0, 2.4.0 ___ Details: When launching server, client *prefers* running it as ./ser That can be considered security issue in release builds. Attacker just has to trick user to run client in a (world writable) directory where he has placed his own ser-program. OTOH running ./ser is definitely useful feature during development so that client finds server directly from build directory. Attached patch makes client to search server from relative paths only in debug builds. Yes, as this is security issue, I've set 2.3.0 (and not 2.3.1) among targets even though we already have RC for 2.3.0. ___ File Attachments: --- Date: Sun 24 Jul 2011 10:19:44 AM EEST Name: SrvPathSecurity.diff Size: 824B By: cazfi http://gna.org/patch/download.php?file_id=13649 ___ Reply to this item at: http://gna.org/patch/?2827 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2828] Turn off beta status from S2_3
URL: http://gna.org/patch/?2828 Summary: Turn off beta status from S2_3 Project: Freeciv Submitted by: cazfi Submitted on: Sun 24 Jul 2011 10:36:23 AM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: As S2_3 is running RC already, beta status should be turned off. We want builds to be similar to final released ones already to detect any problems this may cause. In general, IMO RC should not be flagged beta. ___ File Attachments: --- Date: Sun 24 Jul 2011 10:36:23 AM EEST Name: S2_3NoBeta.diff Size: 331B By: cazfi http://gna.org/patch/download.php?file_id=13650 ___ Reply to this item at: http://gna.org/patch/?2828 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18396] Translations for help and options not displayed
Follow-up Comment #9, bug #18396 (project freeciv): Long term goal of always using Windows line endings on Windows would mean that build process from tarball would need to convert text files. - Surely this can be automated with unix2dos or similar? Or should we provide .tar with unix line endings, and .zip with Windows ones? - That seems like a reasonable solution to me. ___ Reply to this item at: http://gna.org/bugs/?18396 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18396] Translations for help and options not displayed
Follow-up Comment #10, bug #18396 (project freeciv): Long term goal of always using Windows line endings on Windows would mean that build process from tarball would need to convert text files. - Surely this can be automated with unix2dos or similar? Yes, conversion itself is almost trivial part. Hard part is determining *when* (and to what direction) to do it. You can have 1a) tarball 1b) linux svn checkout 1c) linux svn export 1d) windows svn checkout 1e) windows svn export and 2a) native compilation 2b) cross-compilation to system with similar line ending than native 2c) cross-compilation to system with different line ending from native. ___ Reply to this item at: http://gna.org/bugs/?18396 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2829] Text data files with native line endings
URL: http://gna.org/patch/?2829 Summary: Text data files with native line endings Project: Freeciv Submitted by: cazfi Submitted on: Sun 24 Jul 2011 09:35:30 PM EEST Category: None Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: In bug #18396 there is some discussion about always providing textual data files with native (dos / unix) line endings. This ticket is for further discussion about the matter. Should that be part of general freeciv build system at all, or should we just let people making windows builds to resolve it somehow themselves. If it will be part of main freeciv build process, preferably it should not introduce new requirement (unix2dos / dos2unix) for builds where it really is not needed, but configure woudl check for conversation tools only if it knows that they will be needed. One cannot rust source tree to have certain kind of line endings without checking. Tarball has certain kind of line endings regardless where it's used. svn checkouts have native line endings. Conversations (and lack of them) must be supported for both native and cross-compilations. ___ Reply to this item at: http://gna.org/patch/?2829 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18396] Translations for help and options not displayed
Follow-up Comment #11, bug #18396 (project freeciv): Opened separate ticket, patch #2829, for providing data files with native line endings. ___ Reply to this item at: http://gna.org/bugs/?18396 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2830] ser - fcser, civ - fcgui
URL: http://gna.org/patch/?2830 Summary: ser - fcser, civ - fcgui Project: Freeciv Submitted by: cazfi Submitted on: Sun 24 Jul 2011 11:06:13 PM EEST Category: None Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: This patch (to be written) is somewhat related to patch #2827. Patch #2827 is about attacker intentionally installing ./ser to be run. This patch is against accidentally running wrong program due to namespace conflict. ser is definitely not a kind of program name that we can be sure not to exist in any other software in the world. Idea is to rename ser as fcser to reduce risk of namespace conflict, and for consistency civ as fcgui. ___ Reply to this item at: http://gna.org/patch/?2830 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2831] Alternative to gui-qt function pointer layer
URL: http://gna.org/patch/?2831 Summary: Alternative to gui-qt function pointer layer Project: Freeciv Submitted by: cproc Submitted on: So 24 Jul 2011 22:57:15 CEST Category: client-qt Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: The attached patch defines the GUI functions called from common code as 'extern C' to avoid the naming problems. This seems to work as well as using a function pointer layer. ___ File Attachments: --- Date: So 24 Jul 2011 22:57:15 CEST Name: gui-qt_names.diff Size: 88kB By: cproc http://gna.org/patch/download.php?file_id=13653 ___ Reply to this item at: http://gna.org/patch/?2831 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18416] Various typo fixes in strings
URL: http://gna.org/bugs/?18416 Summary: Various typo fixes in strings Project: Freeciv Submitted by: jtn Submitted on: Sun Jul 24 22:09:55 2011 Category: None Severity: 2 - Minor Priority: 5 - Normal Status: In Progress Assigned to: jtn Originator Email: Open/Closed: Open Release: 2.3.0-RC1 Discussion Lock: Any Operating System: Any Planned Release: 2.3.1,2.4.0 ___ Details: ___ Reply to this item at: http://gna.org/bugs/?18416 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18334] few dozen typos in 2.2.5
Update of bug #18334 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn Planned Release: = 2.3.1,2.4.0 ___ Reply to this item at: http://gna.org/bugs/?18334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18334] few dozen typos in 2.2.5
Follow-up Comment #1, bug #18334 (project freeciv): Most of those fixes are already on S2_3, and we're avoiding changing strings for S2_2 since translators have more or less moved off that branch. So only the fixes for comments in packets.def survive... (file #13654) ___ Additional Item Attachment: File name: trunk-S2_3-trivial-typos-bis.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?18334 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2831] Alternative to gui-qt function pointer layer
Follow-up Comment #1, patch #2831 (project freeciv): Well, changing that probably makes sense, though I have been toying with opposite idea; to start using function pointer layer for all guis. That would allow for example design where we would hjave just one client program to which different guis are loaded as modules. ___ Reply to this item at: http://gna.org/patch/?2831 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2831] Alternative to gui-qt function pointer layer
Follow-up Comment #2, patch #2831 (project freeciv): Updated patch. Some of the 'extern C's in the previous patch were actually not necessary. (file #13656) ___ Additional Item Attachment: File name: gui_qt_names_2.diffSize:87 KB ___ Reply to this item at: http://gna.org/patch/?2831 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2827] Client runs server script from current directory in debug build only
Follow-up Comment #1, patch #2827 (project freeciv): - Fix problem in Windows specific code also (file #13657) ___ Additional Item Attachment: File name: SrvPathSecurity_2827-2.diffSize:1 KB ___ Reply to this item at: http://gna.org/patch/?2827 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18406] Client cannot find server to laucnh when freeciv installed to custom location
Follow-up Comment #1, bug #18406 (project freeciv): - Updated to apply on top of patch #2827 (file #13658) ___ Additional Item Attachment: File name: CustLocLaunchSrv_18406-2.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?18406 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2791] CPUHog
Update of patch #2791 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2791 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2816] Remove set but unused best_impr from auto_settler_findwork()
Update of patch #2816 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2816 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2832] Remove undep.sh
URL: http://gna.org/patch/?2832 Summary: Remove undep.sh Project: Freeciv Submitted by: cazfi Submitted on: Mon 25 Jul 2011 01:10:56 AM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: If I read ChangeLogs correctly, undep.sh was broken for years until I fixed it 2007. After that it soon broke again but nobody has touched it since. So it has been broken for almost an decade (it was actively maintained 2003) and nobody has complained. I think we can simply remove it. Attached patch does that. In addition to applying this patch, svn rm bootstrap/undep.sh.in is needed. ___ File Attachments: --- Date: Mon 25 Jul 2011 01:10:56 AM EEST Name: RmUndepSh.diff Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=13659 ___ Reply to this item at: http://gna.org/patch/?2832 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2829] Text data files with native line endings
Follow-up Comment #1, patch #2829 (project freeciv): I'd say having files with UNIX file endings on Windows is not a big problem, since they can be opened with WordPad. But Freeciv should be able to handle both types. ___ Reply to this item at: http://gna.org/patch/?2829 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2793] Update comments to configure.ac
Update of patch #2793 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2793 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
