[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)

2012-01-17 Thread Matthias Pfafferodt

Update of bug #19296 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #3:

 Test linkage for whole WAND_LIBS would be cleaner and would also 
 catch other problematic libraries, not just libbz2. 
Done by the patch; Thanks for the hint - more learned about the internals of
the tools I use ;-)

 why isn't freeciv simply using pkg-config for this and serveral
 other checks ? If that's broken, most of your build system like
 is.
MagickWand has its own tools (MagickWand-config) which are used. They report
-lbz2 as a dependency but the corresponding development packages are not
automatically installed. I have reported it at the opensuse bug tracker at
https://bugzilla.novell.com/show_bug.cgi?id=741947


(file #14811)
___

Additional Item Attachment:

File name: 0016-fix-check-for-MagickWand-libbzip2.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?19296

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18217] GCC 4.6: variable 'xxx' set but not used

2012-01-17 Thread Matthias Pfafferodt

Follow-up Comment #13, bug #18217 (project freeciv):

see also bug #19153

___

Reply to this item at:

  http://gna.org/bugs/?18217

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19297] fix mnemonic diplodlg [gtk2 version]

2012-01-17 Thread Matthias Pfafferodt

Follow-up Comment #1, bug #19297 (project freeciv):

updated version of the patch; use the correct gtk function ...

(file #14816)
___

Additional Item Attachment:

File name: 0017-fix-mnemonic-diplodlg-gtk2-version.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?19297

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19149] [unused var fix] SDL client

2012-01-17 Thread Matthias Pfafferodt

Update of bug #19149 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #7:

updated patch; it uses the solution proposed by Jason Dorje Short jdorje in
bug #18217:

- use a macro UNUSED_VAR(x) to define a variable as 'unused'


(file #14817)
___

Additional Item Attachment:

File name: 0014-unused-var-fix-SDL-client-2.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?19149

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19228] bug in freeciv-stub s --help

2012-01-17 Thread Matthias Pfafferodt

Follow-up Comment #1, bug #19228 (project freeciv):

This is due to patch #2977 - a simplification of the command line options. As
the stub client does not has any framework there is nothing to report ...

___

Reply to this item at:

  http://gna.org/bugs/?19228

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19299] gui_proto_constructor.h not distributed

2012-01-17 Thread Marko Lindqvist

URL:
  http://gna.org/bugs/?19299

 Summary: gui_proto_constructor.h not distributed
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 18 Jan 2012 12:18:58 AM EET
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: cazfi
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

gui_proto_constructor.h header is not put to distribution tarball. Problem
found in fullmoon build. Fix attached. Will commit immediately.



___

File Attachments:


---
Date: Wed 18 Jan 2012 12:18:58 AM EET  Name: DistProtoConstructor.diff  Size:
394B   By: cazfi

http://gna.org/bugs/download.php?file_id=14819

___

Reply to this item at:

  http://gna.org/bugs/?19299

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19299] gui_proto_constructor.h not distributed

2012-01-17 Thread Marko Lindqvist

Update of bug #19299 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19299

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19272] The revolt_cost of a city can become negative.

2012-01-17 Thread Jacob Nevins

Update of bug #19272 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19272

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19246] Diplomacy bugs in the SDL client.

2012-01-17 Thread Jacob Nevins

Update of bug #19246 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19246

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19288] Spy sabotage dialog broken

2012-01-17 Thread Jacob Nevins

Update of bug #19288 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19288

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19290] Intelligence report: nation flag can obscure techs

2012-01-17 Thread Jacob Nevins

Update of bug #19290 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?19290

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19296] fix check for MagickWand (libbzip2)

2012-01-17 Thread anonymous

Follow-up Comment #4, bug #19296 (project freeciv):

Hmmm...
2008-02-03  6.3.8-5 Cristy  quetzlzacatenango@image...
...
Add Magick++-config, MagickCore.pc, MagickWand.pc, Magick++.pc

Is this old enough ?

pkg-config --libs MagickWand
-lMagickWand -lMagickCore
and at least as of ImageMagick 6.7.4.0
MagickWand-config --libs
the output is the same.

Again, this may simply be a freeciv policy, but adding workarounds for
*distro* packaging errors seems an odd solution.
If a distro builds freeciv, they'll add the dep, once it fails to run, if a
user has the problem, they should bug their distro.

On the other hand, it might just be another (odd) freciv policy - you still
use the whole AM_PATH_GTK_2_0 macro; most packages simply rely on pkg-config
here, instead of that compile check.


___

Reply to this item at:

  http://gna.org/bugs/?19296

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev