[Freeciv-Dev] [bug #23089] fc_client::init() lacking function header

2014-12-16 Thread mir3x
Follow-up Comment #1, bug #23089 (project freeciv):

fc_client.h
line 276(S25)   void init(); ( in private section ) 
( line 272 in trunk )

or I misunderstood something ?

___

Reply to this item at:

  http://gna.org/bugs/?23089

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5552] Qt-client: fix city dialog title

2014-12-16 Thread mir3x
Update of patch #5552 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5552

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23030] Ghost nuclear unit left in enemy city after explosion

2014-12-16 Thread pepeto
Follow-up Comment #2, bug #23030 (project freeciv):

I have found similar problem (reversed) for paratrooper jump seen by shared
vision.


___

Reply to this item at:

  http://gna.org/bugs/?23030

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23062] Qt client doesn't ask for confirmation on exit

2014-12-16 Thread mir3x
Update of bug #23062 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23062

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5553] Target city selection: Only return city if acting against it is possible

2014-12-16 Thread Sveinung Kvilhaugsvik
Update of patch #5553 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5553

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23077] Rulesets with attacking caravan broken

2014-12-16 Thread Sveinung Kvilhaugsvik
Update of bug #23077 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23077

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22935] Science report not fully redrawn when changing tileset

2014-12-16 Thread mir3x
Update of bug #22935 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = mir3x  
 Planned Release: = 2.5, trunk 

___

Follow-up Comment #1:

Fixed

(file #23225)
___

Additional Item Attachment:

File name: Qt-Science-Refresh.patch   Size:4 KB


___

Reply to this item at:

  http://gna.org/bugs/?22935

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5542] civ2civ3: make wonders obsolete by own techs

2014-12-16 Thread Sveinung Kvilhaugsvik
Update of patch #5542 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5542

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5569] Put the rule that only domestic wonder building can receive help in the ruleset.

2014-12-16 Thread Sveinung Kvilhaugsvik
Follow-up Comment #1, patch #5569 (project freeciv):

Update documentation

(file #23226)
___

Additional Item Attachment:

File name: 0001-Put-the-rule-that-only-domestic-wonder-building-can-.patch
Size:8 KB


___

Reply to this item at:

  http://gna.org/patch/?5569

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23089] fc_client::init() lacking function header

2014-12-16 Thread Marko Lindqvist
Follow-up Comment #2, bug #23089 (project freeciv):

You speak about function prototype. Function header this ticket is about is
the comment documenting the function.

From CodingStyle:

- Every function should have a comment header. The comment should look like
  the example below, indented by two spaces. It should be above the
  function's implementation, not the prototype:

/
  The description of the function should be here. Also describe what is
  expected of the arguments if it is not obvious. Especially note down any
  non-trivial assumptions that the function makes.

  Do _not_ introduce a new function without some sort of comment.
/

___

Reply to this item at:

  http://gna.org/bugs/?23089

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5548] Set Fort and Airstrip extrastyle in tilesets inheriting them from Amplio2

2014-12-16 Thread Marko Lindqvist
Update of patch #5548 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5548

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4835] Sdl2-client Coding Style corrections

2014-12-16 Thread Marko Lindqvist
Follow-up Comment #31, patch #4835 (project freeciv):

wldgl.c style corrections

(file #23227)
___

Additional Item Attachment:

File name: Sdl2WldlgStyle.patch   Size:9 KB


___

Reply to this item at:

  http://gna.org/patch/?4835

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5580] [Metaticket] Document and cleanup sprite origins setup

2014-12-16 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5580

 Summary: [Metaticket] Document and cleanup sprite origins
setup
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 17 Dec 2014 07:44:31 AM EET
Category: client
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

This came up when I tried to implement patch #5558: sprite origins used in
different situations is a mess, undocumented one. For no (to tileset author)
apparent reason Single2 sprite is drawn to different offset than 3Layer middle
sprite.

We need to understand how all of this works, and document it once we do -
cleanup it where possible - use it (patch #5558)

Suggesting this one as 2.6 release goal despite the work most likely taking
place only after S2_6 already lives in its own branch. We don't want any
tileset authors leaving because they can't figure out what offset applies when
and spending too much time on experimenting with different offsets.




___

Reply to this item at:

  http://gna.org/patch/?5580

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5580] [Metaticket] Document and cleanup sprite origins setup

2014-12-16 Thread Marko Lindqvist
Update of patch #5580 (project freeciv):

  Depends on: = patch #5558


___

Reply to this item at:

  http://gna.org/patch/?5580

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev