[Freeciv-Dev] [patch #5673] as_transform_activity_iterate()

2015-01-04 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5673

 Summary: as_transform_activity_iterate()
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 05 Jan 2015 09:57:35 AM EET
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Add autosettler activity iterator as_transform_activity_iterate(). Unlike
activity_type_iterate() it goes through only the activities autosettler really
is interested about, excluding road and base building activities that are
handled in their own loops.
Immediate gain is that there's no unnecessary processing of activities we're
not interested about, but the real goal of this patch is refactoring the
autosettler code for making further development possible. Both the fact that
there's no need to block some activities *inside* the loops (as only
acceptable ones ever get in in the first place) and that one can add more such
activity lists to iterate over are important.
Name of the iterate macro is a bit misleading at the moment as non-transform
activities of pollution and fallout cleaning are still in this list.

I would make this TRUNK only, if only the default AI was to be considered.
However, planned threaded AI 2.6 autosettlers code will require this.



___

File Attachments:


---
Date: Mon 05 Jan 2015 09:57:35 AM EET  Name: AsTransformActivityIterate.patch 
Size: 10kB   By: cazfi

http://gna.org/patch/download.php?file_id=23404

___

Reply to this item at:

  http://gna.org/patch/?5673

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5663] Optimize handling of upkeep of units without Shield2Gold flag

2015-01-04 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5663

 Summary: Optimize handling of upkeep of units without
Shield2Gold flag
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 04 Jan 2015 12:57:32 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Most units in most rulesets have no Shield2Gold flag. When determining upkeep,
make fast check of the flag first and more expensive calculations only when
for units which they are needed.



___

File Attachments:


---
Date: Sun 04 Jan 2015 12:57:32 PM EET  Name: Shield2GoldNotOptimize.patch 
Size: 1kB   By: cazfi

http://gna.org/patch/download.php?file_id=23392

___

Reply to this item at:

  http://gna.org/patch/?5663

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23143] Fortress+River defense bonus reduced in 2.5 compared to 2.4

2015-01-04 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?23143

 Summary: Fortress+River defense bonus reduced in 2.5 compared
to 2.4
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 04 Jan 2015 11:25:17 UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Need Info
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.5.0, 2.6.0, 3.0.0

___

Details:

On S2_4, the ruleset-defined defense bonus of a base was multiplied by the
hardcoded 1.5x bonus from a river on the same tile.

On S2_5 and later, all extra bonuses are added together, so the net effect of
having both a base (e.g. fortress) and a river is reduced. (Details and
example on the wiki ruleset update page
http://www.freeciv.org/wiki/How_to_update_a_ruleset_from_2.4_to_2.5?diff=22599oldid=22539.)

This raises a couple of problems/questions:
* Exactly preserving ruleset behaviour is tricky-to-impossible because the
only available effect to add the correction factor (Defend_Bonus) has
side-effects:
** IgWall units (Howitzers) would ignore the correction.
*** Unhardcoding IgWall (patch #4799, already on S2_6) would deal with this,
but it's too late to do that for S2_5.
*** However, we could remove use of IgWall from supplied rulesets, and
backport just the AI logic from that patch to spot IgWall-like constructs
using negated=true requirements?
** The BadWallAttacker behaviour would be triggered in base+river cases.
However, none of the supplied rulesets have units with this flag.
* Do we want to attempt to correct this in any or all of the supplied
rulesets, or just accept (and advertise) the reduced bonus?




___

Reply to this item at:

  http://gna.org/bugs/?23143

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23144] README.effects not updated for cumulative Veteran_Build effect

2015-01-04 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?23144

 Summary: README.effects not updated for cumulative
Veteran_Build effect
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 04 Jan 2015 11:39:22 UTC
Category: docs
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.5.0, 2.6.0, 3.0.0

___

Details:


Veteran_Build
New land units of this type have veteran class 1. The amount value is 
ignored, so that you can have multiple Veteran_Build effects, and units will 
only get 1 free veterancy level. This is considered a feature at the moment.





___

Reply to this item at:

  http://gna.org/bugs/?23144

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23143] Fortress+River defense bonus reduced in 2.5 compared to 2.4

2015-01-04 Thread Marko Lindqvist
Follow-up Comment #2, bug #23143 (project freeciv):

 backport just the AI logic from that patch to spot IgWall-like
 constructs using negated=true requirements?

That would require backport of patch #4797

___

Reply to this item at:

  http://gna.org/bugs/?23143

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23145] City_Unhappy_Size not documented in README.effects

2015-01-04 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?23145

 Summary: City_Unhappy_Size not documented in README.effects
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 04 Jan 2015 11:57:18 UTC
Category: docs
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0

___

Details:

This was added in r11546
http://svn.gna.org/viewcvs/freeciv?revision=11546view=revision, PR#15396.




___

Reply to this item at:

  http://gna.org/bugs/?23145

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23143] Fortress+River defense bonus reduced in 2.5 compared to 2.4

2015-01-04 Thread Jacob Nevins
Additional Item Attachment, bug #23143 (project freeciv):

File name: 24_river_fortress.sav.bz2  Size:13 KB


___

Reply to this item at:

  http://gna.org/bugs/?23143

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23143] Fortress+River defense bonus reduced in 2.5 compared to 2.4

2015-01-04 Thread Marko Lindqvist
Follow-up Comment #5, bug #23143 (project freeciv):

In general, I would just accept this as an rules change in 2.5. It's an
another story if we adjust things in S2_6 (civ1 and civ2 rulesets should be
fixed, but I'm not sure the old behavior was correct for both of them either)

___

Reply to this item at:

  http://gna.org/bugs/?23143

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5664] Defensive extras list (cache)

2015-01-04 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5664

 Summary: Defensive extras list (cache)
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 04 Jan 2015 03:27:32 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Build list of extras providing defense bonus, and iterate only that list
instead of all extras when determining tile defense value.



___

File Attachments:


---
Date: Sun 04 Jan 2015 03:27:32 PM EET  Name: DefensiveExtraList.patch  Size:
2kB   By: cazfi

http://gna.org/patch/download.php?file_id=23394

___

Reply to this item at:

  http://gna.org/patch/?5664

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5666] handle_unit_get_actions(): a possible action has a unit as the actor.

2015-01-04 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5666

 Summary: handle_unit_get_actions(): a possible action has a
unit as the actor.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 04 Jan 2015 04:59:38 PM UTC
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:





___

File Attachments:


---
Date: Sun 04 Jan 2015 04:59:38 PM UTC  Name:
0008-handle_unit_get_actions-a-possible-action-has-a-unit.patch  Size: 964B  
By: sveinung

http://gna.org/patch/download.php?file_id=23396

___

Reply to this item at:

  http://gna.org/patch/?5666

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav

2015-01-04 Thread pepeto
Update of bug #23093 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #13:

The original posted patch for S2_4 should stabilize this branch.

___

Reply to this item at:

  http://gna.org/bugs/?23093

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5665] Client: Check received unit actions using action_prob_possible()

2015-01-04 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5665

 Summary: Client: Check received unit actions using
action_prob_possible()
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 04 Jan 2015 04:58:43 PM UTC
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

so it will work even if the action probability encoding changes in the future.



___

File Attachments:


---
Date: Sun 04 Jan 2015 04:58:43 PM UTC  Name:
0007-Client-Check-received-unit-actions-using-action_prob.patch  Size: 914B  
By: sveinung

http://gna.org/patch/download.php?file_id=23395

___

Reply to this item at:

  http://gna.org/patch/?5665

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5667] Only cache a unit types ability to do action with a unit actor

2015-01-04 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5667

 Summary: Only cache a unit types ability to do action with a
unit actor
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 04 Jan 2015 05:00:36 PM UTC
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:





___

File Attachments:


---
Date: Sun 04 Jan 2015 05:00:36 PM UTC  Name:
0009-Only-cache-a-unit-types-ability-to-do-action-with-a-.patch  Size: 2kB  
By: sveinung

http://gna.org/patch/download.php?file_id=23397

___

Reply to this item at:

  http://gna.org/patch/?5667

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5668] Node to store its priority queue index

2015-01-04 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5668

 Summary: Node to store its priority queue index
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 04 Jan 2015 07:29:30 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

pf_normal_map_iterate() accounts over 20% of the server CPU time, so any
optimization to it counts, and can be even higher priority than cleanest
possible APIs. There's also other related path finding functions in the list
of top CPU hogs.

When it finds faster route to the given node, it calls priority queue
_replace() to set new cost for it. _replace() needs to find the node being
replaced, and as the nodes in the hash are not ordered, it has to iterate
though them all to find the correct one.

Attached patch changes that by keeping the node's index in the priority queue
in the node itself so there's no need to search it.

This is not very clean solution as it exposes index that should be internal
detail of the priority queue to the path finding code. I'll test this to see
if it gives any noticeable performance gain.
Earlier I considered replacing use of generic priority queue with (mostly
duplicate) implementation internal to, and specifically crafted and optimised
for, path finding.



___

File Attachments:


---
Date: Sun 04 Jan 2015 07:29:30 PM EET  Name: PqIndexCache.patch  Size: 10kB  
By: cazfi

http://gna.org/patch/download.php?file_id=23398

___

Reply to this item at:

  http://gna.org/patch/?5668

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5660] Bad 'row-activated' signal usage for improvement selling

2015-01-04 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5660

 Summary: Bad 'row-activated' signal usage for improvement
selling
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 04 Jan 2015 09:59:33 AM EET
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

From bug 20097:

the way freeciv is using 'row-activated' signal was never was never really
correct, so I don't see any proper fix for that - it was always working just
cause it wanted to, not cause it had to




___

Reply to this item at:

  http://gna.org/patch/?5660

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20097] Use GtkOrientation (migrate from gtk2) and fix GdkModifierType mask handling

2015-01-04 Thread Marko Lindqvist
Update of bug #20097 (project freeciv):

  Status:None = Duplicate  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 
 Planned Release:   2.4.0 =

___

Follow-up Comment #7:

 it was always working just cause it wanted to, not cause it had to

Currently it wants to, so closing this bug and opened future improvement patch
#5660

___

Reply to this item at:

  http://gna.org/bugs/?20097

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20681] Select menu disabled when no units selected, but Unit selection dialog could be used

2015-01-04 Thread Marko Lindqvist
Update of bug #20681 (project freeciv):

 Planned Release:   2.4.0 = 2.4.5, 2.5.0, 2.6.0,
3.0.0


___

Reply to this item at:

  http://gna.org/bugs/?20681

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4965] civ2civ3: partisans linked to city nationality

2015-01-04 Thread Marko Lindqvist
Follow-up Comment #2, patch #4965 (project freeciv):

This is being backported to S2_5 in patch #5544

___

Reply to this item at:

  http://gna.org/patch/?4965

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5544] civ2civ3: backport changes from trunk to S2_5

2015-01-04 Thread Marko Lindqvist
Update of patch #5544 (project freeciv):

Category:None = rulesets   
  Status:None = Ready For Test 
 Assigned to:None = cazfi  
 Planned Release: = 2.5.0  


___

Reply to this item at:

  http://gna.org/patch/?5544

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4811] civ2civ3: increase explorer vision

2015-01-04 Thread Marko Lindqvist
Follow-up Comment #3, patch #4811 (project freeciv):

This is being backported to S2_5 in patch #5544

___

Reply to this item at:

  http://gna.org/patch/?4811

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1447] Merge ruleset files in 1 file

2015-01-04 Thread Marko Lindqvist
Follow-up Comment #1, patch #1447 (project freeciv):

IMO Current division is quite balanced compromise between each file being big
enough unit and having granularity. For example compatibility mode for loading
older version requires parts of rulesets to define their version
independently. That works well in the level of current files.

___

Reply to this item at:

  http://gna.org/patch/?1447

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #1943] Code style patch

2015-01-04 Thread Marko Lindqvist
Update of patch #1943 (project freeciv):

  Status:None = Wont Do
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?1943

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2184] Remove hardcoded Entertainer/Scientist/Taxman references from clients

2015-01-04 Thread Marko Lindqvist
Update of patch #2184 (project freeciv):

 Planned Release: = 2.6.0  

___

Follow-up Comment #4:

The option should not be tied to specific specialists, but their output:
Use the specialist that produces most gold (from the ones available at the
time it's being added), then science etc.


Taht would work at the moment (when specialists do not have other effects than
Specialist_Output) but of course if the formats get more flexible to allow
specialist to be requirement for other effects, things will break.


___

Reply to this item at:

  http://gna.org/patch/?2184

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2903] [Metaticket] xml-files instead of self-made section-file format

2015-01-04 Thread Marko Lindqvist
Update of patch #2903 (project freeciv):

  Depends on: = patch #4884


___

Reply to this item at:

  http://gna.org/patch/?2903

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2903] [Metaticket] xml-files instead of self-made section-file format

2015-01-04 Thread Marko Lindqvist
Update of patch #2903 (project freeciv):

  Depends on: = patch #4915


___

Reply to this item at:

  http://gna.org/patch/?2903

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2903] [Metaticket] xml-files instead of self-made section-file format

2015-01-04 Thread Marko Lindqvist
Update of patch #2903 (project freeciv):

  Depends on: = patch #5505


___

Reply to this item at:

  http://gna.org/patch/?2903

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2903] [Metaticket] xml-files instead of self-made section-file format

2015-01-04 Thread Marko Lindqvist
Update of patch #2903 (project freeciv):

  Status:None = In Progress
 Planned Release: = 3.0.0  


___

Reply to this item at:

  http://gna.org/patch/?2903

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2911] Improvements to tutorial scenario

2015-01-04 Thread Marko Lindqvist
Follow-up Comment #4, patch #2911 (project freeciv):

 Even if you have more improvements to tutorial to be added later
 in mind, maybe you should commit this existing improvement
 already.

Ping

___

Reply to this item at:

  http://gna.org/patch/?2911

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5643] Clean up: Place regular move handling after the enabler controlled actions.

2015-01-04 Thread Sveinung Kvilhaugsvik
Update of patch #5643 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5643

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #2915] Intro font information from freeciv.rc-2.0

2015-01-04 Thread Marko Lindqvist
Update of patch #2915 (project freeciv):

  Status:  Ready For Test = Invalid
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?2915

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5634] Put the rule that empty cities cost half as much in the ruleset.

2015-01-04 Thread Sveinung Kvilhaugsvik
Update of patch #5634 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5634

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3418] Show citizen nationality in the SDL client

2015-01-04 Thread Marko Lindqvist
Update of patch #3418 (project freeciv):

Category:  client-sdl = client-sdl2

___

Follow-up Comment #1:

Setting category to sdl2-client as more important than old sdl-client, though
it's possible that once implemented it's trivial to backport.

___

Reply to this item at:

  http://gna.org/patch/?3418

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3505] Civ2: No upkeep for fanatics under Fundamentalism

2015-01-04 Thread Marko Lindqvist
Follow-up Comment #1, patch #3505 (project freeciv):

http://strategywiki.org/wiki/Civilization_II/Government
says that Fanatics are always free, and otherwise free upkeep is 8 units.

___

Reply to this item at:

  http://gna.org/patch/?3505

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5662] Be precise about plural form when talking about actor and target kind.

2015-01-04 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5662

 Summary: Be precise about plural form when talking about
actor and target kind.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 04 Jan 2015 10:07:26 AM UTC
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

Up unit now all enabler controlled actions have had a single target. This is
about to change. Capture unit will capture *all* units at a tile. This will
require more precision when talking about target kind.



___

File Attachments:


---
Date: Sun 04 Jan 2015 10:07:26 AM UTC  Name:
0006-Be-precise-about-plural-form-when-talking-about-acto.patch  Size: 6kB  
By: sveinung

http://gna.org/patch/download.php?file_id=23387

___

Reply to this item at:

  http://gna.org/patch/?5662

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5661] Clean up: Centralize the bonus reduction of Enter Marketplace.

2015-01-04 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/patch/?5661

 Summary: Clean up: Centralize the bonus reduction of Enter
Marketplace.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 04 Jan 2015 10:06:18 AM UTC
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

Make get_caravan_enter_city_trade_bonus() handle the bonus reduction of Enter
Marketplace (without establishing a trade route).



___

File Attachments:


---
Date: Sun 04 Jan 2015 10:06:18 AM UTC  Name:
0005-Centralize-the-bonus-reduction-of-Enter-Marketplace.patch  Size: 9kB  
By: sveinung

http://gna.org/patch/download.php?file_id=23386

___

Reply to this item at:

  http://gna.org/patch/?5661

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3505] Civ2: No upkeep for fanatics under Fundamentalism

2015-01-04 Thread Marko Lindqvist
Update of patch #3505 (project freeciv):

 Planned Release: = 2.4.5, 2.5.0, 2.6.0,
3.0.0

___

Follow-up Comment #2:

- Also reduce number of non-fanatic units free upkeep to 8

(file #23388, file #23389, file #23390)
___

Additional Item Attachment:

File name: Civ2Fanatics-2.patch   Size:0 KB
File name: Civ2Fanatics-S2_5-2.patch  Size:0 KB
File name: Civ2Fanatics-S2_4-2.patch  Size:0 KB


___

Reply to this item at:

  http://gna.org/patch/?3505

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #4104] Generalize global warming/cooling

2015-01-04 Thread Sveinung Kvilhaugsvik
Update of patch #4104 (project freeciv):

 Planned Release:   2.6.0 =


___

Reply to this item at:

  http://gna.org/patch/?4104

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23135] Cimpletoon has no inaccessible tile definition

2015-01-04 Thread Marko Lindqvist
Update of bug #23135 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23135

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5564] civ2civ3: backport some terrain effects

2015-01-04 Thread Marko Lindqvist
Update of patch #5564 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5564

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5477] Improve Barbarian unit flag documentation

2015-01-04 Thread Marko Lindqvist
Update of patch #5477 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5477

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5645] Qt-client man page update

2015-01-04 Thread Marko Lindqvist
Update of patch #5645 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5645

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23146] Messages sent to threaded AI when it's not active (memory leak)

2015-01-04 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?23146

 Summary: Messages sent to threaded AI when it's not active
(memory leak)
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 04 Jan 2015 09:44:24 PM EET
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0, 2.6.0, 3.0.0

___

Details:

When threaded AI is built in, messages are queued for player thread to
receive. If there's no players actually using threaded AI type, the thread is
not running at all, meaning that message queue only grows and grows. This uses
both more and more memory and surprisingly much CPU time.

Attached fix avoids queueing messages when player thread is not running.



___

File Attachments:


---
Date: Sun 04 Jan 2015 09:44:24 PM EET  Name: ThreadedAiQueueNoReceiver.patch 
Size: 2kB   By: cazfi

http://gna.org/bugs/download.php?file_id=23399

___

Reply to this item at:

  http://gna.org/bugs/?23146

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5669] tile_move_cost_ptrs() road handling optimization

2015-01-04 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5669

 Summary: tile_move_cost_ptrs() road handling optimization
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 04 Jan 2015 11:09:30 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Avoid constructs like road_extra_get(extra_road_get(extra)) hidden in macro
calls and wrapper functions in tile_move_cost_ptrs() (function that with 4.30%
share of CPU time is number 5 in profiling results)
Add comment next to definitions of road_type_iterate() and base_type_iterate()
that they should be deprecated for reasons like these.



___

File Attachments:


---
Date: Sun 04 Jan 2015 11:09:30 PM EET  Name:
CostPtrsExtraRoadExtraOptimize.patch  Size: 3kB   By: cazfi

http://gna.org/patch/download.php?file_id=23400

___

Reply to this item at:

  http://gna.org/patch/?5669

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5670] sdl2-client info to man page

2015-01-04 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5670

 Summary: sdl2-client info to man page
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 05 Jan 2015 12:17:33 AM EET
Category: docs
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Update freeciv-client man-page with information about sdl2-client



___

File Attachments:


---
Date: Mon 05 Jan 2015 12:17:33 AM EET  Name: sdl2Man.patch  Size: 2kB   By:
cazfi

http://gna.org/patch/download.php?file_id=23401

___

Reply to this item at:

  http://gna.org/patch/?5670

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5672] Stub ruleset with single barbarian nation

2015-01-04 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5672

 Summary: Stub ruleset with single barbarian nation
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 05 Jan 2015 06:45:16 AM EET
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Make stub ruleset to use single LandAndSea barbarian nation.

In addition to applying the patch-file, rm data/stub/nation/pirate.ruleset




___

File Attachments:


---
Date: Mon 05 Jan 2015 06:45:16 AM EET  Name: SingleBarbStub.patch  Size: 858B 
 By: cazfi

http://gna.org/patch/download.php?file_id=23403

___

Reply to this item at:

  http://gna.org/patch/?5672

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5671] rscompat.[ch]

2015-01-04 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5671

 Summary: rscompat.[ch]
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 05 Jan 2015 06:32:47 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Add module rscompat to handle ruleset compatibility mode related stuff.
Initial version introduces info structure to control compatibility
adjustments, moves ruleset capability check to rscompat, and adds empty
rscompat_postprocess() to be filled with ruleset compatibility processing
things as needed.




___

File Attachments:


---
Date: Mon 05 Jan 2015 06:32:47 AM EET  Name: rscompat.patch  Size: 20kB   By:
cazfi

http://gna.org/patch/download.php?file_id=23402

___

Reply to this item at:

  http://gna.org/patch/?5671

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev