[Freeciv-Dev] [patch #6034] Move definition of ACTION_ANY to common/actions.h

2015-04-25 Thread Sveinung Kvilhaugsvik
Update of patch #6034 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?6034

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays

2015-04-25 Thread Sveinung Kvilhaugsvik
Update of patch #5955 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5955

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6037] Trade routes list

2015-04-25 Thread Marko Lindqvist
Follow-up Comment #2, patch #6037 (project freeciv):

 - Traderoute direction is not set when caravan first establish the
traderoute

This is now bug #23537

___

Reply to this item at:

  http://gna.org/patch/?6037

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23537] Trade route direction not set when caravan establish it

2015-04-25 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?23537

 Summary: Trade route direction not set when caravan establish
it
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 25 Apr 2015 11:49:12 PM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 3.0.0

___

Details:

This is one of the bugs mentioned in patch #6037. Turns out it's causing
enough trouble in current codebase so it makes sense to fix it already before
patch #6037 gets ready.

Fix attached



___

File Attachments:


---
Date: Sat 25 Apr 2015 11:49:12 PM EEST  Name: CaravanDirection.patch  Size:
786B   By: cazfi

http://gna.org/bugs/download.php?file_id=24350

___

Reply to this item at:

  http://gna.org/bugs/?23537

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23535] Crash on saving traderoute goods information

2015-04-25 Thread Marko Lindqvist
Update of bug #23535 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #1:

The problem was more obvious than I thought: it's always handling
MAX_TRADE_ROUTES routes, even when there isn't that many established. Attached
fix makes it to save dummy direction and goods information about routes that
do not exist.

(file #24346)
___

Additional Item Attachment:

File name: DummyGoodsSave.patch   Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?23535

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23535] Crash on saving traderoute goods information

2015-04-25 Thread Marko Lindqvist
Update of bug #23535 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23535

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23501] Help claims city worked tiles cannot be stolen, but they can

2015-04-25 Thread Marko Lindqvist
Follow-up Comment #5, bug #23501 (project freeciv):

 it changes gameplay around border pressure quite a lot

FWIW for this very same reason I view it as a *serious* bug.

___

Reply to this item at:

  http://gna.org/bugs/?23501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23407] Server wants us to remove unit id 2579, but we don't know about this unit!

2015-04-25 Thread Jacob Nevins
Follow-up Comment #3, bug #23407 (project freeciv):


1: Server wants us to remove unit id 3741, but we don't know about this unit!


I can of course work out what kind of units these were from a savegame.

* 2579: a Diplomat
** Message in T0191-auto savegame: 
191,1426988786,12,33,S_S_RUNNING,E_MY_DIPLOMAT_BRIBE,00100,[c
fg=\#8B\]Your [l tgt=\unit\ id=2579 name=\Diplomat\ /] succeeded in
bribing the [l tgt=\unit\ id=2756 name=\Chariot\ /].[/c]
* 2555: a Diplomat
* 3741: another Diplomat

I'm guessing that this is triggered by diplomats disappearing when they
complete their mission.

___

Reply to this item at:

  http://gna.org/bugs/?23407

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6038] Improve ruleset docs for terrain pillage/clean_pollution/fallout_time

2015-04-25 Thread Marko Lindqvist
Follow-up Comment #1, patch #6038 (project freeciv):

While at it, why not make it consistent between build and removal times.
Currently build side entries have if 0, cannot xxx and you add (0 =
impossible) to removal side entries.

___

Reply to this item at:

  http://gna.org/patch/?6038

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23501] Help claims city worked tiles cannot be stolen, but they can

2015-04-25 Thread Marko Lindqvist
Follow-up Comment #6, bug #23501 (project freeciv):

err... could have been clearer: I mean the current behavior which your patch
fixes to be the buggy one.

___

Reply to this item at:

  http://gna.org/bugs/?23501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23526] Give warning when creating more AI players than available in nationset

2015-04-25 Thread Andreas Røsdal
Follow-up Comment #3, bug #23526 (project freeciv):

Thanks for fixing this!

___

Reply to this item at:

  http://gna.org/bugs/?23526

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6032] Worker task list

2015-04-25 Thread Marko Lindqvist
Follow-up Comment #1, patch #6032 (project freeciv):

- Use the first worker task (as we still support only one / city) instead of
one stored to index 1 in the list.

The very first worker task created was completely ignored once it had been
appended to the list, except that its existence made second task added to end
up to index 1 and to get used for everything (including updates and removals
of itself)

(file #24347, file #24348)
___

Additional Item Attachment:

File name: WorkerTaskList-2.patch Size:18 KB
File name: WorkerTaskList-S2_6-2.patchSize:15 KB


___

Reply to this item at:

  http://gna.org/patch/?6032

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21999] adv_data_city_impr_calc() fails to consider present==FALSE

2015-04-25 Thread Marko Lindqvist
Update of bug #21999 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?21999

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23535] Crash on saving traderoute goods information

2015-04-25 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?23535

 Summary: Crash on saving traderoute goods information
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 25 Apr 2015 07:51:27 PM EEST
Category: general
Severity: 3 - Normal
Priority: 9 - Immediate
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 3.0.0

___

Details:

Server crashes while saving goods information about traderoutes.

Once I get the fix ready (assuming the problem is what I assume at the
moment), I will not wait review period but commit immediately.




___

Reply to this item at:

  http://gna.org/bugs/?23535

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6029] free diplrel_mess

2015-04-25 Thread Marko Lindqvist
Update of patch #6029 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?6029

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6035] Move the one time bonus reduction of Enter Marketplace to the ruleset.

2015-04-25 Thread Sveinung Kvilhaugsvik
Update of patch #6035 (project freeciv):

  Status:  Ready For Test = Done   
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?6035

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23528] gui-xaw: implicit declaration of function 'same_pos'

2015-04-25 Thread Jacob Nevins
Update of bug #23528 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_6-xaw-include-map-h.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?23528

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6022] Remember what goods traderoute is about

2015-04-25 Thread Marko Lindqvist
Update of patch #6022 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?6022

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23530] border_city_radius_sq maximum is greater than size in network protocol

2015-04-25 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?23530

 Summary: border_city_radius_sq maximum is greater than size
in network protocol
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 25 Apr 2015 11:39:49 BST
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.5.1, 2.6.0, 3.0.0

___

Details:

Maximum is 401, yet it's declared as a UINT8 in the network protocol.

This is harmless as it's not used by the client currently, and it seems to end
up declared as an int in the server game_info structure.




___

Reply to this item at:

  http://gna.org/bugs/?23530

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23503] Inconsistency in ocean border claiming next to border source

2015-04-25 Thread Jacob Nevins
Update of bug #23503 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23503

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6037] Trade routes list

2015-04-25 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?6037

 Summary: Trade routes list
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 25 Apr 2015 03:54:29 PM EEST
Category: general
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Package all the trade route related values to a struct, and have a list of
these trade routes in a city.

Network protocol has not been changed in this patch. Client still receives
MAX_TRADE_ROUTES route information as a part of city info packet. It currently
makes complete rebuild of the trade routes list when it receives them.



___

File Attachments:


---
Date: Sat 25 Apr 2015 03:54:29 PM EEST  Name: TradeRouteList.patch.bz2  Size:
9kB   By: cazfi

http://gna.org/patch/download.php?file_id=24326

___

Reply to this item at:

  http://gna.org/patch/?6037

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23531] removal_time_factor not used

2015-04-25 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?23531

 Summary: removal_time_factor not used
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 25 Apr 2015 13:54:58 BST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

terrain_extra_removal_time() multiplies by the extra's build_time_factor.
removal_time_factor isn't referenced anywhere.
I assume this is a mistake.




___

Reply to this item at:

  http://gna.org/bugs/?23531

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6038] Improve ruleset docs for terrain pillage/clean_pollution/fallout_time

2015-04-25 Thread Jacob Nevins
URL:
  http://gna.org/patch/?6038

 Summary: Improve ruleset docs for terrain
pillage/clean_pollution/fallout_time
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 25 Apr 2015 14:38:45 BST
Category: None
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Clarify relationship of terrain pillage time to extra removal_time.
Note effect of zero pillage/clean_pollution/fallout_time.





___

Reply to this item at:

  http://gna.org/patch/?6038

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6037] Trade routes list

2015-04-25 Thread Marko Lindqvist
Follow-up Comment #1, patch #6037 (project freeciv):

There's several existing bugs in TRUNK that I think are better to fix only
once this patch is in - no conflicts between the patches + less work as the
there's no need to rewrite the fixes to the model of this patch + this makes
it much easier to fix some of the problems (setting the goods information of
the re-established traderoute correctly)

- Traderoute direction is not set when caravan first establish the traderoute
- Goods are not set when reestablish_city_trade_routes temporarily removes the
route and then re-establish it (possibly to different slot)
- reestablish_city_trade_routes() sets traderoute direction to what ever
direction it happened to be called - nothing to do with the original way
traderoute was established

___

Reply to this item at:

  http://gna.org/patch/?6037

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [task #7814] S2_6 datafile format freeze

2015-04-25 Thread Jacob Nevins
Update of task #7814 (project freeciv):

  Depends on: = patch #6036


___

Reply to this item at:

  http://gna.org/task/?7814

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6036] Give rulesets control over territory permanently claimed by cities

2015-04-25 Thread Jacob Nevins
URL:
  http://gna.org/patch/?6036

 Summary: Give rulesets control over territory permanently
claimed by cities
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 25 Apr 2015 13:28:02 BST
Category: None
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Split out from bug #23530:

 Once claimed, a tile that can be directly worked by a city can
 not change ownership unless the city does (or is destroyed). 
  [...]
 Should it become ruleset-configurable or even 
 user-configurable? Perhaps as a signed delta from the city 
 radius, so that immunity from transfer can be disabled for 
 the city's outer worked tiles or all of them with a 
 sufficiently negative value?

This patch makes it ruleset-configurable, enabling a ruleset where a city
under border pressure will feel some effect but not be completely starved.




___

Reply to this item at:

  http://gna.org/patch/?6036

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23532] AI estimate about trade loss from traderoute cancelling too high

2015-04-25 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?23532

 Summary: AI estimate about trade loss from traderoute
cancelling too high
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 25 Apr 2015 05:15:55 PM EEST
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.1, 2.6.0, 3.0.0

___

Details:

one_city_trade_benefit() gets *sum* of trade values of all routes being
cancelled

int oldtrade = city_trade_removable(pcity, would_remove);

Later it considers that value to apply *per* city it owns.

city_list_iterate(would_remove, losercity) {
  if (city_owner(losercity) == pplayer) {
losttrade += oldtrade


Fix attached. This solution also uses trade value from the right end of the
route instead of assuming that it's idendical on both ends (not necessarily
true in S2_6-)




___

File Attachments:


---
Date: Sat 25 Apr 2015 05:15:55 PM EEST  Name: CityTradeBenefitLostTrade.patch 
Size: 704B   By: cazfi

http://gna.org/bugs/download.php?file_id=24327

___

Reply to this item at:

  http://gna.org/bugs/?23532

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23501] Help claims city worked tiles cannot be stolen, but they can

2015-04-25 Thread Jacob Nevins
Follow-up Comment #3, bug #23501 (project freeciv):

I don't think this is distinguishable from complete absence of locked tiles in
any of the supplied rulesets.

The city map is offset by 10 tiles in each of x and y, so total
distance-squared is 200 from where it should be (14.14 tiles diagonally).

The closest that any part of that offset city-map comes to the city that's the
border source is the city workable radius. Radius_sq=26, radius about 5
(ignoring that in many rulesets workable radius is much less).

Any tile that is to be considered within the offset map of a
city-as-border-source is distance_sq (sqrt(200)-sqrt(26))^2, which comes to
81-ish (9 tiles ish).

In order for this to matter, such a tile has to have been claimed by a city
for territory purposes.

The distance_sq a city will claim is given by
radius_sq_city+(MIN(city_size,26)*size_effect).
* Classic etc: 17+26*1 = 43
* civ2civ3: 5+26*1 = 31
* alien: 4+26*1 = 30

None of this is anywhere near 81. So no city can claim a tile in the first
place in order to retain it under this broken rule.

Custom ruelsets with much bigger city borders might have triggered it.

___

Reply to this item at:

  http://gna.org/bugs/?23501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6039] Center map on antipode

2015-04-25 Thread Bernd Jendrissek
URL:
  http://gna.org/patch/?6039

 Summary: Center map on antipode
 Project: Freeciv
Submitted by: berndj
Submitted on: Sat 25 Apr 2015 04:22:54 PM UTC
Category: client-gtk-2.0
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

When establishing trade routes, it's useful to send the caravans/freight as
far as possible. This patch centers the map on the furthest point from the
current map center position. Note that pressing '!' twice does not guarantee a
return to the current position, although on donut worlds it's likely to be
close.



___

File Attachments:


---
Date: Sat 25 Apr 2015 04:22:54 PM UTC  Name: antipode.patch  Size: 2kB   By:
berndj

http://gna.org/patch/download.php?file_id=24331

___

Reply to this item at:

  http://gna.org/patch/?6039

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5987] Improve help for water territory claiming

2015-04-25 Thread Jacob Nevins
Update of patch #5987 (project freeciv):

  Status: In Progress = Ready For Test 
 Assigned to:None = jtn
 Summary: Help: Consider Claim_Ocean in borders documentation
= Improve help for water territory claiming

___

Additional Item Attachment:

File name: trunk-S2_6-help-water-borders.patch Size:1 KB
File name: S2_5-help-water-borders.patch  Size:0 KB


___

Reply to this item at:

  http://gna.org/patch/?5987

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6036] Give rulesets control over territory permanently claimed by cities

2015-04-25 Thread Jacob Nevins
Update of patch #6036 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_6-border-city-protect-config.patch Size:12 KB


___

Reply to this item at:

  http://gna.org/patch/?6036

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23501] Help claims city worked tiles cannot be stolen, but they can

2015-04-25 Thread Jacob Nevins
Update of bug #23501 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = jtn
 Planned Release: = 2.4.5, 2.5.1, 2.6.0,
3.0.0

___

Follow-up Comment #4:

Attached patches:
* In S2_4: remove the code entirely. No visible change except for odd
rulesets.
** (Including a string change; while we were avoiding string changes in S2_4
* In S2_5+: reinstate the rule.
** In S2_6+, patch #6036 will give rulesets control over this rule. In S2_5
there's no avoiding it.
** I dithered massively about reintroducing the rule to S2_5, since it changes
gameplay around border pressure quite a lot: encourages land-grabs and
prevents starving cities by border pressure. It wouldn't take much to talk me
out of it.

(file #24336, file #24337)
___

Additional Item Attachment:

File name: trunk-S2_6-S2_5-border-city-protect.patch Size:0 KB
File name: S2_4-border-city-protect.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?23501

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23530] border_city_radius_sq maximum is greater than size in network protocol

2015-04-25 Thread Jacob Nevins
Update of bug #23530 (project freeciv):

  Status: In Progress = Ready For Test 
 Release: = 2.5.0  
 Planned Release: 2.5.1, 2.6.0, 3.0.0 = 2.6.0, 3.0.0   

___

Follow-up Comment #1:

Not fixing in S2_5 since it would require capability faff and is currently
harmless.

(file #24334, file #24335)
___

Additional Item Attachment:

File name: trunk-network-border-city-radius.patch Size:1 KB
File name: S2_6-network-border-city-radius.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?23530

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6038] Improve ruleset docs for terrain pillage/clean_pollution/fallout_time

2015-04-25 Thread Jacob Nevins
Update of patch #6038 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_6-rulesetdoc-pillage-removal-time.patch Size:9 KB


___

Reply to this item at:

  http://gna.org/patch/?6038

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23531] removal_time_factor not used

2015-04-25 Thread Jacob Nevins
Update of bug #23531 (project freeciv):

  Status: In Progress = Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_6-removal_time_factor.patch Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?23531

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23459] Help says Pillaging removes one terrain alteration per turn per unit

2015-04-25 Thread Jacob Nevins
Update of bug #23459 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = jtn

___

Additional Item Attachment:

File name: trunk-S2_6-help-pillage-single-turn.patch Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?23459

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23526] Give warning when creating more AI players than available in nationset

2015-04-25 Thread Jacob Nevins
Update of bug #23526 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = jtn
 Release: = 2.5.0  
Operating System:   GNU/Linux = Any
 Planned Release: = 2.5.1, 2.6.0, 3.0.0

___

Additional Item Attachment:

File name: trunk-aifill-fail-reason.patch Size:7 KB
File name: S2_6-aifill-fail-reason.patch  Size:7 KB
File name: S2_5-aifill-fail-reason.patch  Size:7 KB


___

Reply to this item at:

  http://gna.org/bugs/?23526

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev