[Freeciv-Dev] [bug #21730] minimap size

2015-10-27 Thread wotan 
Follow-up Comment #1, bug #21730 (project freeciv):

I agree

when you compile freeciv, you can set the mapsize manually, would be nice if
this was a client setting


gtk2 client

./client/options.h  : 469

#define GUI_GTK_OVERVIEW_MIN_XSIZE  200
#define GUI_GTK_OVERVIEW_MIN_YSIZE  200


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7952] Tracking release 2.5.2

2015-10-27 Thread Marko Lindqvist 
Follow-up Comment #2, task #7952 (project freeciv):

At the moment we have 27 bugs and 9 patches targeted to S2_5, of which all
patches and 22 bugs are targeted specifically to 2.5.2 already.
Please keep your ticket status updated.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23969] Client segfault on quit, preceded by Gtk-CRITICAL IA__gtk_text_buffer errors

2015-10-27 Thread Marko Lindqvist 
Follow-up Comment #5, bug #23969 (project freeciv):

Patch for S2_6, to be rebased on top of bug #23950 later.

Implemented using callback parameter to options_save().

(file #25481)
___

Additional Item Attachment:

File name: OptionsSaveLogCb-S2_6.patchSize:8 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23861] Version 2.5.1 hangs up on Windows XP?

2015-10-27 Thread Marko Lindqvist 
Follow-up Comment #18, bug #23861 (project freeciv):

> then it should reveal in the console what was the message that it was unable
to write to the chatline.

-> this message is probably bug #23969

To avoid confusion; most likely this has nothing to do with the actual problem
in this ticket.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23872] No way to load "xxx.sav" when "xxx.sav.bz2" exist

2015-10-27 Thread Marko Lindqvist 
Update of bug #23872 (project freeciv):

 Planned Release: 2.5.2, 2.6.0, 3.0.0 => 2.5.x, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23961] Gtk-WARNING **: Don't know color 'u'

2015-10-27 Thread Marko Lindqvist 
Update of bug #23961 (project freeciv):

 Planned Release: 2.5.2, 2.6.0, 3.0.0 => 2.5.x, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23989] Public netitnf.h header has non-public HAVE_SOCKLEN_T

2015-10-27 Thread Marko Lindqvist 
URL:
  

 Summary: Public netitnf.h header has non-public
HAVE_SOCKLEN_T
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 27 Oct 2015 06:24:33 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0

___

Details:

In addition to making HAVE_SOCKLEN_T itself public, also correct headers
should be included for getting the correct socklen_t definition.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23978] Europe 1901 claims the closest diplstate ever between allies is "No contact"

2015-10-27 Thread Sveinung Kvilhaugsvik 
Update of bug #23978 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6265] Show ruleset defined text in "Build Type x Base" menu entries.

2015-10-27 Thread Marko Lindqvist 
Follow-up Comment #2, patch #6265 (project freeciv):

That's what gettext return for an empty string (""). Most likely you are
trying to construct the menu before receiving the ruleset defined string from
the server.
Note also that you need to refresh it when ever rulesets are changed.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23984] Conversion from 'enum diplrel_other' to 'enum citytile_type'

2015-10-27 Thread Sveinung Kvilhaugsvik 
Update of bug #23984 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => sveinung   
 Release: => TRUNK  
Operating System:None => Any
 Planned Release: => 3.0.0  

___

Follow-up Comment #1:

Untested patch attached.

(file #25485)
___

Additional Item Attachment:

File name: 0001-Access-correct-member-of-union.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6483] Make the sciencebox setting SSET_RULES_HEAVY

2015-10-27 Thread Sveinung Kvilhaugsvik 
Update of patch #6483 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6481] Introduce a heavy scenario rule setting class

2015-10-27 Thread Sveinung Kvilhaugsvik 
Update of patch #6481 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6482] Make the killstack setting SSET_RULES_HEAVY

2015-10-27 Thread Sveinung Kvilhaugsvik 
Update of patch #6482 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23973] Peace and Alliance is closer than "Never met"

2015-10-27 Thread Sveinung Kvilhaugsvik 
Update of bug #23973 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6478] savegame3: store diplstate_type by name

2015-10-27 Thread Sveinung Kvilhaugsvik 
Update of patch #6478 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6265] Show ruleset defined text in "Build Type x Base" menu entries.

2015-10-27 Thread mir3x 
Update of patch #6265 (project freeciv):

  Status:None => Need Info  

___

Follow-up Comment #1:

Q_(terrain_control.gui_type_base1) returns nothing for english language, 
for polish returns this:

Project-Id-Version: freeciv
Report-Msgid-Bugs-To: 
POT-Creation-Date: 2015-04-18 01:08+0300
PO-Revision-Date: 2015-05-20 15:46+0100
Last-Translator: Hubert Kowalewski 
Language-Team: polski 
Language: pl
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Plural-Forms: nplurals=3; plural=n==1 ? 0 : n%10>=2 && n%10<=4 && (n%100<10 ||
n%100>=20) ? 1 : 2;
X-Generator: Poedit 1.5.4

( in both 2.6 and trunk )

Any idea whats wrong ?


(file #25484)
___

Additional Item Attachment:

File name: qt_gui_types.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6496] Look ws2tcpip.h for socklen_t definition

2015-10-27 Thread Marko Lindqvist 
URL:
  

 Summary: Look ws2tcpip.h for socklen_t definition
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 27 Oct 2015 06:31:55 PM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

Looking through fc_config.h generated for the crosser based build I noticed
that HAVE_SOCKLEN_T was not defined.

Attached patch makes such builds to get socklen_t definition from ws2tcpip.h
(no behavioral changes expected as we already we're fallbacking to identical
definition):

- Search socklen_t from Windows specific header ws2tcpip.h
- Do not fail the socklen_t configure check just because (any) system lacks
headers needed providing socklen_t in some other system
- Include ws2tcpip.h to netintf.h for getting the definition also when doing
the actual compilation


For S2_6/TRUNK we should define HAVE_WS2TCPIP_H as a public macro in
freeciv_config.h, but doing that alone, without fixing rest of bug #23989,
would just cause compilation problems -> handle all of it in bug #23989.



___

File Attachments:


---
Date: Tue 27 Oct 2015 06:31:55 PM EET  Name: Ws2TcpIpSocklenT.patch  Size: 1kB
  By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23888] explorer_goto() can mess goto_tile for AI task using it

2015-10-27 Thread Marko Lindqvist 
Follow-up Comment #4, bug #23888 (project freeciv):

- S2_5 fix that simply removes goto_tile changing form the autoexplorer. It's
not like the information would be accurate and/or relevant any more by the
time client may see it.

(file #25488)
___

Additional Item Attachment:

File name: ExplorerGotoTileNot.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6434] Include a scenario with a complex situation

2015-10-27 Thread Sveinung Kvilhaugsvik 
Update of patch #6434 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6471] Force government menu icons visible

2015-10-27 Thread Marko Lindqvist 
Update of patch #6471 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23975] Disasters setting not initialized in game_defaults() (game_init())

2015-10-27 Thread Marko Lindqvist 
Update of bug #23975 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23872] No way to load "xxx.sav" when "xxx.sav.bz2" exist

2015-10-27 Thread Marko Lindqvist 
Update of bug #23872 (project freeciv):

 Planned Release: 2.5.x, 2.6.0, 3.0.0 => 2.5.3, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23976] Traits have not been documented in ruleset comments

2015-10-27 Thread Marko Lindqvist 
Update of bug #23976 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #1:

S2_5 version, commit candidate already.

In other branches any patch would conflict with patch #5028, so waiting that
one to get resolved first.

(file #25494)
___

Additional Item Attachment:

File name: TraitDoc-S2_5.patchSize:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6499] Use -Wno-tautological-compare on all builds

2015-10-27 Thread Marko Lindqvist 
URL:
  

 Summary: Use -Wno-tautological-compare on all builds
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 27 Oct 2015 09:51:31 PM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

We have macros resulting in a lot of tautological comparisons on purpose. Stop
compiler spamming those warnings from any build (not only when --enable-debug
has been used)

Reported by  on #freeciv-dev.



___

File Attachments:


---
Date: Tue 27 Oct 2015 09:51:31 PM EET  Name: CommonNoTautology-S2_5.patch 
Size: 1kB   By: cazfi


---
Date: Tue 27 Oct 2015 09:51:31 PM EET  Name: CommonNoTautology.patch  Size:
1kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23966] Segfault when loading in Freeciv web

2015-10-27 Thread Andreas Røsdal 
Follow-up Comment #2, bug #23966 (project freeciv):

Attaching a savegame where this crash can be reproduced.

(file #25495)
___

Additional Item Attachment:

File name: lambrus.sav.xz Size:299 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22786] "Manual Turn Done in AI mode" not useful?

2015-10-27 Thread Marko Lindqvist 
Follow-up Comment #3, bug #22786 (project freeciv):

The server part has been moved to -> bug #23991

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6477] Accept city name suggestion with Enter

2015-10-27 Thread Marko Lindqvist 
Update of patch #6477 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6498] Use "gtk4" namespace for gtk3x options

2015-10-27 Thread Marko Lindqvist 
URL:
  

 Summary: Use "gtk4" namespace for gtk3x options
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 27 Oct 2015 09:45:53 PM EET
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Use "gtk4" referring namespaces for options of gtk3x client from the beginning
for forward compatibility of the options saved to client settings.



___

File Attachments:


---
Date: Tue 27 Oct 2015 09:45:53 PM EET  Name: Gtk4OptionNamespace.patch  Size:
2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23991] Turn never finishing when last client to do turn done under AI control

2015-10-27 Thread Marko Lindqvist 
URL:
  

 Summary: Turn never finishing when last client to do turn
done under AI control
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 27 Oct 2015 10:09:47 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

Extracted server part from patch of bug #22786, where the part is explained
as:

"Count client with AI controlled player as "connection under control" if it
already has made properly ended turn, when checking against game going
rampant*

*) It's possible to construct corner-cases where this is arguably wrong, but
in general I think this works better than old code that could lead server
never to finish turn if the last turn done was from a client switching under
AI control, and there was no other clients connected at the time."




___

File Attachments:


---
Date: Tue 27 Oct 2015 10:09:47 PM EET  Name:
PhaseDoneIsControlledConnection.patch  Size: 569B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23991] Turn never finishing when last client to do turn done under AI control

2015-10-27 Thread Marko Lindqvist 
Follow-up Comment #1, bug #23991 (project freeciv):

I think we've hit this bug after voting about /aitoggle. At least once in such
a situation I had to resolt to temporarily turning timeout on to force one
turn change that way.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6497] Qt client - show players information in network page

2015-10-27 Thread mir3x 
URL:
  

 Summary: Qt client - show players information in network page
 Project: Freeciv
Submitted by: mir3x
Submitted on: Tue 27 Oct 2015 07:59:28 PM CET
Category: client-qt
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6, 3.0

___

Details:

Added showing information about selected server in network page.



___

File Attachments:


---
Date: Tue 27 Oct 2015 07:59:28 PM CET  Name: qt_net_info.patch  Size: 3kB  
By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23992] Client page change in queue mess

2015-10-27 Thread Marko Lindqvist 
URL:
  

 Summary: Client page change in queue mess
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 27 Oct 2015 11:19:34 PM EET
Category: client-sdl2
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

When leaving sdl2-client, client common code places switching of the page to
the update queue. At the same time it causes gui to free some elements of the
PAGE_GAME. A bit later set_turn_done_button_state() gets called, and it checks
that current page is PAGE_GAME. It is, since page switch is still in queue.
Then set_turn_done_button_state() proceeds to do stuff assuming that PAGE_GAME
elements exist.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23993] Clang 3.7 warnings in trunk

2015-10-27 Thread Louis Moureaux 
URL:
  

 Summary: Clang 3.7 warnings in trunk
 Project: Freeciv
Submitted by: louis94
Submitted on: mar. 27 oct. 2015 21:31:48 UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

There are three of them (release build):

In city.c

city.c:1426:43: warning: implicit conversion from enumeration type 'enum
diplrel_other' to different enumeration type 'enum citytile_type'
[-Wenum-conversion]
  tile_is_foreign.source.value.citytile = DRO_FOREIGN;
~ ^~~


In nation.c

nation.c:69:20: warning: unused function 'nation_check' [-Wunused-function]
static inline bool nation_check(const struct nation_type *pnation,
   ^


In autosettlers.c

autosettlers.c:888:7: warning: variable 'best_act' is used uninitialized
whenever 'if' condition is false [-Wsometimes-uninitialized]
  if (unit_has_type_flag(punit, UTYF_SETTLERS)) {
  ^~~~
autosettlers.c:901:38: note: uninitialized use occurs here
  best_tile, best_act, _target,
 ^~~~
autosettlers.c:888:3: note: remove the 'if' if its condition is always true
  if (unit_has_type_flag(punit, UTYF_SETTLERS)) {
  ^~
autosettlers.c:837:3: note: variable 'best_act' is declared here
  enum unit_activity best_act;
  ^






___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6501] New configure option --disable-delta-protocol

2015-10-27 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: New configure option --disable-delta-protocol
 Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 27 Oct 2015 11:00:32 PM UTC
Category: freeciv-web
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

A third party project without a working delta protocol implementation may need
the ability to communicate with Freeciv. Today this must be done by patching
generate_packets.py.

Let the build system disable the delta network protocol. Emit a warning if it
is disabled.

Turning off bool folding when the delta protocol otherwise is supported is
still not possible.



___

File Attachments:


---
Date: Tue 27 Oct 2015 11:00:32 PM UTC  Name:
0002-New-configure-option-disable-delta-protocol.patch  Size: 3kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23966] Segfault when loading in Freeciv web

2015-10-27 Thread Marko Lindqvist 
Follow-up Comment #3, bug #23966 (project freeciv):

First error it gives is about xz-compression:

XZ: "Progress not possible" (10)

Does freeciv-web in production have bug #23891 fixed?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23966] Segfault when loading in Freeciv web

2015-10-27 Thread Andreas Røsdal 
Follow-up Comment #4, bug #23966 (project freeciv):

>Does freeciv-web in production have bug #23891 fixed?

No. So this seems to be a very likely cause. Thanks!

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23988] Feature request: all units on a tile are shown in the bar on the right side

2015-10-27 Thread Marko Lindqvist 
Follow-up Comment #1, bug #23988 (project freeciv):

Am I right to assume that you are currently playing with Game -> Options ->
Local Client -> Interface -> Arrange Widgets for small displays enabled? It is
by default (in gtk3-client we could make the default to depend on actual
screen size in S2_6 and later...)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6500] generate_packets.py: ignore argument position

2015-10-27 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: generate_packets.py: ignore argument position
 Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 27 Oct 2015 10:57:47 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

Stop depending on the position of command line arguments. Not an issue at the
moment since only one argument currently exists.



___

File Attachments:


---
Date: Tue 27 Oct 2015 10:57:47 PM UTC  Name:
0001-generate_packets.py-ignore-argument-position.patch  Size: 838B   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23962] The helptext of Pikemen don't mention the defense bonus vs horses

2015-10-27 Thread Sveinung Kvilhaugsvik 
Update of bug #23962 (project freeciv):

 Assigned to:None => sveinung   

___

Follow-up Comment #4:

> Sveinung; will you take the S2_6/TRUNK autogeneration part?
Yes.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6490] civ2civ3: force establish trade route

2015-10-27 Thread Sveinung Kvilhaugsvik 
Update of patch #6490 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6502] Cleanup begin_turn() is_new_turn checks

2015-10-27 Thread Marko Lindqvist 
URL:
  

 Summary: Cleanup begin_turn() is_new_turn checks
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 28 Oct 2015 01:12:30 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Most code blocks in begin_turn() are only executed if is_new_turn is set.
Cleanup unneeded "if (is_new_turn" constructs away when consecutive blocks can
be joined to just one block where the check is in the beginning.



___

File Attachments:


---
Date: Wed 28 Oct 2015 01:12:30 AM EET  Name: IsNewTurnCleanup.patch  Size: 2kB
  By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6503] Remove savegame version checks from savegame3.c

2015-10-27 Thread Marko Lindqvist 
URL:
  

 Summary: Remove savegame version checks from savegame3.c
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 28 Oct 2015 01:17:36 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Only TRUNK saves are created in savegame3.c format, so when savegame3.c save
is loaded, there's no need to support saves from older versions. Drop all
checks for older loading->version.



___

File Attachments:


---
Date: Wed 28 Oct 2015 01:17:36 AM EET  Name: Savegame3GuaranteedVersion.patch 
Size: 4kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6246] Drop sdl1.2-mixer support

2015-10-27 Thread Marko Lindqvist 
Update of patch #6246 (project freeciv):

 Planned Release:   3.0.0 => 3.1.0  

___

Follow-up Comment #1:

Sdl1.2-mixer support is really just a couple of lines in sound.m4 to provide
flags to include correct headers and to link against correct libraries. As
long as our sdl-mixer plugin has no need to use something that not readily
available from sdl1.2-mixer, there's no need to rush dropping of this support.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22710] Turn demographics statistics refreshed on save+load

2015-10-27 Thread Marko Lindqvist 
Update of bug #22710 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #2:

Load correct score from the savegame.

(file #25500, file #25501)
___

Additional Item Attachment:

File name: ScoreLoad.patchSize:8 KB
File name: ScoreLoad-S2_6.patch   Size:4 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23850] Great Library tech not announced

2015-10-27 Thread anonymous 
Follow-up Comment #2, bug #23850 (project freeciv):

I made a small edit to the logic of the found_new_tech() of statement in
techtools.c. Now all non researched tech provide what tech was found and what
is being researched next, for example, techs gained from philosophy, and techs
from wonders.

(file #25504)
___

Additional Item Attachment:

File name: research_bug_patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23402] An immediate advances message needs to be displayed specifically.

2015-10-27 Thread Marko Lindqvist 
Update of bug #23402 (project freeciv):

Category:None => general
  Status:None => Duplicate  
 Assigned to:None => cazfi  

___

Follow-up Comment #1:

This is being handled in bug #23850

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21730] minimap size

2015-10-27 Thread Christian Knoke 
Update of bug #21730 (project freeciv):

Category:None => client-gtk-3.0 

___

Follow-up Comment #2:


Hello Wotan,

I wonder why I wrote this, originally.

I think it was because of the vertical scrollbar at the minimap.

The minimap itself has a variable size and scale, nowadays (2.5.1).

Quite often I have seen scroll bars on the minimap, in recent games. These
where no big games.

I think, scroll bars on the minimap are evil (tm).

The size of the items on the (nowadays) right bar is not always so, that you
can see everything clear.

It should be.

This is all gtk3 client.

I add some feature requests.

Regards,

Christian


| I agree
| 
| when you compile freeciv, you can set the mapsize manually, 
| would be nice if this was a client setting

| gtk2 client

| ./client/options.h : 469

| #define GUI_GTK_OVERVIEW_MIN_XSIZE 200
| #define GUI_GTK_OVERVIEW_MIN_YSIZE 200

| Fri 28 Feb 2014 12:43:55 PM CET, original submission:
| | 
| | On big map, the ysize of the minimap is too small.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6444] Ruleset selection gui

2015-10-27 Thread mir3x 
Additional Item Attachment, patch #6444 (project freeciv):

File name: qt_pregame_options_v2-s26_trunk.patch.bz2 Size:2 KB
File name: qt_pregame_options_v2.patch.bz2 Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23987] Feature request: Mark enemies on the map

2015-10-27 Thread Christian Knoke 
URL:
  

 Summary: Feature request: Mark enemies on the map
 Project: Freeciv
Submitted by: chrisk
Submitted on: Tue 27 Oct 2015 02:48:34 PM CET
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.1++
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:


I'd like to see some marks/colors on enemy units in sight, so I can recognise
them easily on the map. I.e. units of nations I'm in war with (or they with
me..)

I'd very much like to see this on the minimap, too, e.g. red dots reserved for
this. Big help on big maps..

Christian





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23988] Feature request: all units on a tile are shown in the bar on the right side

2015-10-27 Thread Christian Knoke 
URL:
  

 Summary: Feature request: all units on a tile are shown in
the bar on the right side
 Project: Freeciv
Submitted by: chrisk
Submitted on: Tue 27 Oct 2015 02:51:58 PM CET
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.1++
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:


On the right side bar, below the active tile info, there is some space for
this: a display of all units present on the active tile.

Makes life easier..

Christian





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21730] minimap size

2015-10-27 Thread wotan 
Follow-up Comment #3, bug #21730 (project freeciv):

oh yes gtk3 used to have a bug where the minimap window wouldn't resize the
content.

scrollbars are horrible and the gtk2 client is still the best client out
there, you can rearrange the windows just as you like and its stable and fast,
gtk3 is still unusably slow will try again in a year


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev