Re: [Freeciv-Dev] [bug #24018] The AI players are extremely slow during europa_1901's turn change

2015-11-04 Thread Andreas Røsdal 
> Are the AI players unusually slow for the number of units and cities they
have?

I think the AI is unusually slow in this scenario. At the moment the Europe
1901 is not usable on the production server.
Possibly the AI will have to behave differently with a very large number of
cities and units, for example perform less calculations for each unit if
the number of units is above some threshold value.


Andreas
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24029] Rulesave not handling trait_xxx_default

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: Rulesave not handling trait_xxx_default
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 05 Nov 2015 12:54:26 AM EET
Category: freeciv-ruledit
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0

___

Details:

Fix attached



___

File Attachments:


---
Date: Thu 05 Nov 2015 12:54:26 AM EET  Name: RulesaveFixedTrait.patch  Size:
1kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24018] The AI players are extremely slow during europa_1901's turn change

2015-11-04 Thread Marko Lindqvist 
Follow-up Comment #4, bug #24018 (project freeciv):

In case of aitoggle, at least, the time is spent in assess_danger(), called
for 46 cities player owns, each taking seconds to process.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24028] Qt client - first chat message broken

2015-11-04 Thread mir3x 
URL:
  

 Summary: Qt client - first chat message broken
 Project: Freeciv
Submitted by: mir3x
Submitted on: Wed 04 Nov 2015 11:52:53 PM CET
Category: client-qt
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.2, 2.6, 3.0

___

Details:

Sometimes after starting game, first chat message could be the last one from
pregame chat or broken one.
Fixed.



___

File Attachments:


---
Date: Wed 04 Nov 2015 11:52:53 PM CET  Name: qt-chat-fix.patch  Size: 913B  
By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6546] Cache defense multiplier bonuses utype vs utype

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: Cache defense multiplier bonuses utype vs utype
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 05 Nov 2015 12:25:19 AM EET
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Values are constant within ruleset, so cache them on ruleset load.

Not for 2.5.2. We may consider backporting to S2_5 / 2.5.3.




___

File Attachments:


---
Date: Thu 05 Nov 2015 12:25:19 AM EET  Name:
CacheDefenseMultiplierCBonus.patch  Size: 3kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6546] Cache defense multiplier bonuses utype vs utype

2015-11-04 Thread Marko Lindqvist 
Follow-up Comment #1, patch #6546 (project freeciv):

Eventually we should cache all combat bonuses the same way, and possibly in
common code instead of default AI.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24018] The AI players are extremely slow during europa_1901's turn change

2015-11-04 Thread Marko Lindqvist 
Follow-up Comment #3, bug #24018 (project freeciv):

Yeah, I took "George V" to enter the game. Tried to aitoggle him off to have
an all-AI game, and that simple *aitoggle* took extremely long time. This is
something to investigate.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6545] notify.research lua

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: notify.research lua
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 04 Nov 2015 11:00:08 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

In order to give customized messages about techs gained, or other events
concerning research, lua script needs to be able to send notifications to all
players sharing the research.

Untested patch attached.



___

File Attachments:


---
Date: Wed 04 Nov 2015 11:00:08 PM EET  Name: NotifyResearchLua.patch  Size:
3kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7814] S2_6 datafile format freeze

2015-11-04 Thread Marko Lindqvist 
Update of task #7814 (project freeciv):

  Depends on: => patch #6545


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6531] More tech announcement control for lua-scripts

2015-11-04 Thread Marko Lindqvist 
Update of patch #6531 (project freeciv):

  Status:None => In Progress

___

Follow-up Comment #1:

Two additions to lua scripting API should be made.

1) Make it possible to lua-script to send notifications to all players in the
shared research group -> patch #6545

2) To lift unnecessary burden from the script author (to make sure it won't
get forgotten as an oversight), server should automatically send notifications
about techs given by the script. The script just needs a way to prevent this
automatic message in case of some "dummy" tech or when it wants to send
customized message itself.

This ticket is about the latter.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6547] Update Europe_1901 to S2_5 savegame format

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: Update Europe_1901 to S2_5 savegame format
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 05 Nov 2015 01:41:38 AM EET
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

This version is also available to 2.5 via modpack installer.




___

File Attachments:


---
Date: Thu 05 Nov 2015 01:41:38 AM EET  Name: Europe1901_25Fmt.patch.bz2  Size:
196kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6547] Update Europe_1901 to S2_5 savegame format

2015-11-04 Thread Marko Lindqvist 
Follow-up Comment #1, patch #6547 (project freeciv):

I also tried conversion to 2.6 format both directly and from the 2.5 format
version. The difference between direct and via 2.5 is that the conversion ->
2.5 has added settings 'disasters' and 'killstack' to saved settings, which
further conversion to 2.6 then keeps, but direct conversion -> 2.6 does not
add them.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24012] S2_6 cannot replicate S2_5 behaviour moving between different native roads

2015-11-04 Thread Jacob Nevins 
Follow-up Comment #4, bug #24012 (project freeciv):

> I have just tested S2_6 rev30384, and it is possible for 
> merchants to move from river to road (and road to river), even 
> diagonally. 
I've double-checked S2_6 and it's impossible for me. (civ2civ3, iso or
iso|hex.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24010] Weird display glitch: despotism heads on main map (after tileset change)

2015-11-04 Thread Marko Lindqvist 
Update of bug #24010 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: 2.5.2, 2.6.0, 3.0.0 => 2.5.2  

___

Follow-up Comment #7:

I think the double unref fixed by attached patch was behind all this.

Only S2_5 was affected by this. This should have been part of bug #23935, but
when backporting the fix to S2_5 the fact that there was one case more to fix
than in later branches went unnoticed.

(file #25617)
___

Additional Item Attachment:

File name: DoubleSpecialUnref.patch   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23935] Client segfault when starting second local game

2015-11-04 Thread Marko Lindqvist 
Follow-up Comment #8, bug #23935 (project freeciv):

One more case was found in S2_5 in bug #24010.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24030] Trident has no Lake gfx

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: Trident has no Lake gfx
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 05 Nov 2015 01:12:24 AM EET
Category: art
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Loading Europe_1901 using Trident tileset I noticed that Lough Neagh looks
like an Ocean despite middle-mouse telling it to be Lake.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24031] hexemplio clicks misaligned with hex boundaries

2015-11-04 Thread Jacob Nevins 
URL:
  

 Summary: hexemplio clicks misaligned with hex boundaries
 Project: Freeciv
Submitted by: jtn
Submitted on: Thu 05 Nov 2015 01:09:55 UTC
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_6 r30412
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 2.6.0, 3.0.0

___

Details:

S2_6 r30412, hexemplio tileset, wrapx|iso|hex topology: clicks seem to go to
the wrong hexes. For instance selecting units and adding things like roads in
the editor.

It looks as though clicking within a given hex can hit the ones above,
above-left, and above-right, depending where in the hex you click.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6541] Support TRUNK-style 'default' ruleset in scenario

2015-11-04 Thread Marko Lindqvist 
Update of patch #6541 (project freeciv):

  Status:  Ready For Test => None   


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6549] tile_has_extra() as an macro

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: tile_has_extra() as an macro
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 05 Nov 2015 07:37:27 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Turn tile_has_extra() an macro to cut function call overhead.



___

File Attachments:


---
Date: Thu 05 Nov 2015 07:37:27 AM EET  Name: MacroTileHasExtra.patch  Size:
2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24018] The AI players are extremely slow during europa_1901's turn change

2015-11-04 Thread Marko Lindqvist 
Follow-up Comment #6, bug #24018 (project freeciv):

With patch #6550:

Each sample counts as 0.01 seconds.
  %   cumulative   self  self total   
 time   seconds   secondscalls   s/call   s/call  name
 37.63 31.4031.40 139470450 0.00 0.00  pf_normal_map_iterate
 11.05 40.62 9.22 544973169 0.00 0.00  tile_move_cost_ptrs
  9.68 48.70 8.08 533192173 0.00 0.00 
base_get_direction_for_step
  3.15 51.33 2.63 1770384743 0.00 0.00  is_native_to_class
  2.34 53.28 1.95 1149920129 0.00 0.00  map_pos_to_tile
  2.07 55.01 1.73 1730602476 0.00 0.00  tile_has_extra
  2.04 56.71 1.70 544973169 0.00 0.00  normal_move
  1.88 58.28 1.57 166058467 0.00 0.00  player_can_invade_tile
  1.65 59.66 1.38 1235025786 0.00 0.00 
is_native_tile_to_class
  1.33 60.77 1.11 535356118 0.00 0.00  is_native_move
  1.32 61.87 1.10 851560216 0.00 0.00  utype_has_flag
  1.29 62.95 1.08 tile_has_road_flag
  1.28 64.02 1.07 168315999 0.00 0.00  pf_get_move_scope
  1.27 65.08 1.06 533192173 0.00 0.00  get_direction_for_step
  1.23 66.11 1.03 533192173 0.00 0.00  is_move_cardinal
  1.03 66.97 0.86
can_attack_from_non_native
  1.03 67.83 0.86 genlist_release_mutex


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6548] Drop pre-1.15 support nation list

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: Drop pre-1.15 support nation list
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 05 Nov 2015 04:47:39 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

savegame.c still has a list of nations that pre-1.15 freeciv used to have so
it could load saves created by such versions.
We don't support pre-2.0 savegames, so drop that.



___

File Attachments:


---
Date: Thu 05 Nov 2015 04:47:40 AM EET  Name: Pre115SupportDrop.patch  Size:
2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24018] The AI players are extremely slow during europa_1901's turn change

2015-11-04 Thread Marko Lindqvist 
Follow-up Comment #5, bug #24018 (project freeciv):

Each sample counts as 0.01 seconds.
  %   cumulative   self  self total   
 time   seconds   secondscalls   s/call   s/call  name
 38.67 52.3252.32 139470450 0.00 0.00  pf_normal_map_iterate
 10.52 66.5514.23 533192173 0.00 0.00 
base_get_direction_for_step
  8.15 77.5811.03 544973169 0.00 0.00  tile_move_cost_ptrs
  5.63 85.20 7.62 3572464560 0.00 0.00  map_pos_to_tile
  3.60 90.07 4.87 166058467 0.00 0.00  player_can_invade_tile
  2.96 94.07 4.00 1770384743 0.00 0.00  is_native_to_class
  2.19 97.03 2.96 535356118 0.00 0.00  is_native_move
  1.58 99.17 2.14 1730602476 0.00 0.00  tile_has_extra
  1.45101.13 1.96 1235025786 0.00 0.00 
is_native_tile_to_class
  1.43103.06 1.93 544973169 0.00 0.00  normal_move
  1.39104.94 1.88 168315999 0.00 0.00  pf_get_move_scope
  1.32106.72 1.78 tile_has_road_flag
  1.20108.34 1.62 533192173 0.00 0.00  is_move_cardinal
  1.14109.88 1.541 1.54 1.54  map_init_topology
  1.13111.41 1.5356580 0.00 0.00  pf_reverse_map_pos


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6550] Write base_get_direction_for_step() macros open, discard unnecessary parts

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: Write base_get_direction_for_step() macros open,
discard unnecessary parts
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 05 Nov 2015 08:50:05 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

As seen in bug #24018 profiling, base_get_direction_for_step() is performance
critical function (maybe even more than the profile reveals - some users
inline it).

Attached patch replaces use of generic iterator macro with
base_get_direction_for_step() specific iteration that does nothing extra - we
don't want to convert coordinate differences all the way to valid tiles to
compare, we can compare the coordinate difference directly.



___

File Attachments:


---
Date: Thu 05 Nov 2015 08:50:06 AM EET  Name:
MinimalBaseGetDirection-S2_5.patch  Size: 2kB   By: cazfi


---
Date: Thu 05 Nov 2015 08:50:05 AM EET  Name: MinimalBaseGetDirection.patch 
Size: 2kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6543] Add zoom steps API

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: Add zoom steps API
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 04 Nov 2015 09:55:45 PM EET
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Add zoom_step_up() and zoom_step_down() functions, for guis to use when zoom
levels are controlled in steps.



___

File Attachments:


---
Date: Wed 04 Nov 2015 09:55:46 PM EET  Name: ZoomSteps.patch  Size: 2kB   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6544] Provide fc_config.h used in built with Windows Installer builds

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: Provide fc_config.h used in built with Windows
Installer builds
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 04 Nov 2015 10:00:53 PM EET
Category: bootstrap
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

Often debugging of the Windows Installer build problems involves wondering
what code actually has been compiled in from the #ifdef stuff. The usual
assumption has been that it's reproducible by building again and checking what
configure sets to fc_config.h, but that's not optimal.
Attached patch includes fc_config.h generated for the build process to the
produced package. In the target system it goes to subdirectory debuginfo/




___

File Attachments:


---
Date: Wed 04 Nov 2015 10:00:53 PM EET  Name: WinInstDebugInfo.patch  Size: 1kB
  By: cazfi


---
Date: Wed 04 Nov 2015 10:00:53 PM EET  Name: WinInstDebugInfo-S2_5.patch 
Size: 618B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6539] rulesets: use the old mnemonics for the targeted

2015-11-04 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: rulesets: use the old mnemonics for the targeted
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 04 Nov 2015 03:17:38 PM UTC
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

and untargeted versions of Sabotage City and Steal Technology. This can be
done since no mnemonic using client (GTK and Qt) show them at once.

This restores the 2.5 behavior.



___

File Attachments:


---
Date: Wed 04 Nov 2015 03:17:38 PM UTC  Name:
0005-Use-the-traditional-mnemonics-for-targeted.patch  Size: 7kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6536] client: maximize profit when disbanding a unit

2015-11-04 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: client: maximize profit when disbanding a unit
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 04 Nov 2015 02:49:31 PM UTC
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

At the moment a more profitable way will block a less profitable way.

Temporary down side: it becomes impossible to order a unit to Disband if
Recycle Unit is illegal but the player don't have enough information to know
that it is. Will only happen in custom rulesets where Recycle Unit is
forbidden based on something the player don't know.



___

File Attachments:


---
Date: Wed 04 Nov 2015 02:49:31 PM UTC  Name:
0001-client-maximize-profit-when-disbanding-a-unit.patch  Size: 2kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6539] rulesets: use the old mnemonics for the targeted

2015-11-04 Thread Sveinung Kvilhaugsvik 
Update of patch #6539 (project freeciv):

  Depends on: => patch #6537


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6538] Qt client: just show targeted in act sel dlg

2015-11-04 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Qt client: just show targeted in act sel dlg
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 04 Nov 2015 03:16:45 PM UTC
Category: client-qt
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

It is possible to do the untargeted variant of Steal Tech and Sabotage City
from the target selection dialog. Don't show the untargeted variant when the
targeted variant is possible. Let the player pick it as a target.

This restores the 2.5 behavior.



___

File Attachments:


---
Date: Wed 04 Nov 2015 03:16:46 PM UTC  Name:
0004-Qt-client-one-act-sel-button-for-random-tgt.patch  Size: 1kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24026] Stop assuming the unit survived a failed disband

2015-11-04 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Stop assuming the unit survived a failed disband
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 04 Nov 2015 03:02:18 PM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Release: TRUNK
 Discussion Lock: Any
Operating System: Any
 Planned Release: 3.0.0

___

Details:

Traditional disband orders the ways it tries to disband a unit so it matches
the pre 3.0 disband unit command. Stop assuming that a failed disband action
means that the unit survived. It may have failed because the unit was killed
in Lua before the action started.



___

File Attachments:


---
Date: Wed 04 Nov 2015 03:02:18 PM UTC  Name:
0002-Stop-assuming-the-unit-survived-a-failed-disband.patch  Size: 2kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6537] GTK clients: just show targeted in act sel dlg

2015-11-04 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: GTK clients: just show targeted in act sel dlg
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 04 Nov 2015 03:15:42 PM UTC
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

It is possible to do the untargeted variant of Steal Tech and Sabotage City
from the target selection dialog. Don't show the untargeted variant when the
targeted variant is possible. Let the player pick it as a target.

This restores the 2.5 behavior.



___

File Attachments:


---
Date: Wed 04 Nov 2015 03:15:42 PM UTC  Name:
0003-GTK-clients-one-act-sel-button-for-random-tgt.patch  Size: 3kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6540] SDL 2 client: just show targeted in act sel dlg

2015-11-04 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: SDL 2 client: just show targeted in act sel dlg
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 04 Nov 2015 03:19:39 PM UTC
Category: client-sdl2
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:

It is possible to do the untargeted variant of Steal Tech and Sabotage City
from the target selection dialog. Don't show the untargeted variant when the
targeted variant is possible. Let the player pick it as a target.

This restores the 2.5 behavior.



___

File Attachments:


---
Date: Wed 04 Nov 2015 03:19:39 PM UTC  Name:
3.0-SDL-2-client-one-act-sel-button-for-random-tgt.patch  Size: 2kB   By:
sveinung


---
Date: Wed 04 Nov 2015 03:19:39 PM UTC  Name:
2.6-SDL-clients-one-act-sel-button-for-random-tgt.patch  Size: 2kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7814] S2_6 datafile format freeze

2015-11-04 Thread Marko Lindqvist 
Update of task #7814 (project freeciv):

  Depends on: => patch #6541


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6523] Sanity check armistice turns left

2015-11-04 Thread Sveinung Kvilhaugsvik 
Update of patch #6523 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6541] Support TRUNK-style 'default' ruleset in scenario

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: Support TRUNK-style 'default' ruleset in scenario
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 04 Nov 2015 06:15:27 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Special handling of 'default' ruleset was added to savegame3.c mainly to
benefit freeciv-web integration. It's still a long way from helping, though,
as the supplied scenarios are currently using S2_6 savegame format and will
switch to a new format only close to release of 3.0.
I hope to backport the 'default' ruleset handling like that in savegame3.c to
savegame2.c when the savegame has been created by freeciv-2.6. That's going to
mean some rather ugly code as savegame2.c still supports also 'default'
ruleset meaning real pre-2.5 ruleset.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23999] Error out on invalid values given to --disable-delta-protocol

2015-11-04 Thread Sveinung Kvilhaugsvik 
Update of bug #23999 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6521] Europe 1901: remove intra paragraph line breaks

2015-11-04 Thread Sveinung Kvilhaugsvik 
Update of patch #6521 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24005] Qt client debug builds failing with many -Wshadow warnings

2015-11-04 Thread Marko Lindqvist 
Follow-up Comment #2, bug #24005 (project freeciv):

Ruledit part of the log -> patch #6542

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6542] Fix ruledit shadow warnings

2015-11-04 Thread Marko Lindqvist 
URL:
  

 Summary: Fix ruledit shadow warnings
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 04 Nov 2015 08:23:32 PM EET
Category: freeciv-ruledit
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

This should fix ruledit shadow warnings reported by jtn in bug #24005.



___

File Attachments:


---
Date: Wed 04 Nov 2015 08:23:32 PM EET  Name: RuleditShadow.patch  Size: 1kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24027] Qt client - overview issues

2015-11-04 Thread mir3x 
URL:
  

 Summary: Qt client - overview issues
 Project: Freeciv
Submitted by: mir3x
Submitted on: Wed 04 Nov 2015 07:11:20 PM CET
Category: client-qt
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.2, 2.6, 3.0

___

Details:

Fixed overview often not refreshed and viewport
being badly positioned after changing view (eg. disconnecting
and reconnecting, or observing someone else )



___

File Attachments:


---
Date: Wed 04 Nov 2015 07:11:20 PM CET  Name: qt-minimap-issues.patch  Size:
2kB   By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6514] Set password from edit widget to password to send when Enter pressed

2015-11-04 Thread Marko Lindqvist 
Update of patch #6514 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev