[Freeciv-Dev] [bug #24077] Unable to build any other client, if gtk3 dependencies do not exist

[Mike Smith]

URL:
  

 Summary: Unable to build any other client, if gtk3
dependencies do not exist
 Project: Freeciv
Submitted by: jni
Submitted on: Sun 15 Nov 2015 08:31:54 AM UTC
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: r30610
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

On Linux system without gtk3, building any of the other clients always fails:

./configure --enable-client=gtk2 --disable-gtktest

results to error:

checking for GTK+ - version >= 2.12.0... yes (version 2.24.23)
checking for GTK3MP... no
configure: error: Package requirements (gtk+-3.0 >= 3.8.0) were not met:

No package 'gtk+-3.0' found

Consider adjusting the PKG_CONFIG_PATH environment variable if you
installed software in a non-standard prefix.

Alternatively, you may set the environment variables GTK3MP_CFLAGS
and GTK3MP_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

configure failed





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24077] Unable to build any other client, if gtk3 dependencies do not exist

[Marko Lindqvist]

Follow-up Comment #1, bug #24077 (project freeciv):

That's somehting that error messages shold explain, but this is because you're
trying to build gtk3-version (the default) of the modpack installer.
You probably want: ./configure --enable-client=gtk2 --enable-fcmp=gtk2

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24083] autogen.sh should set AUTOCONF_VERSION

[Marko Lindqvist]

URL:
  

 Summary: autogen.sh should set AUTOCONF_VERSION
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 15 Nov 2015 04:39:36 PM EET
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Running OpenBSD aclocal requires that.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24070] terrain alteration and pillaging broken using all default settings

[wotan]

Follow-up Comment #8, bug #24070 (project freeciv):

It works again after a new checkout. fixed

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24084] citizen_base_mood: comparison is always true due to limited range of data type

[Marko Lindqvist]

URL:
  

 Summary: citizen_base_mood: comparison is always true due to
limited range of data type
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 15 Nov 2015 05:10:43 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_6
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

common/city.c:2187: warning: comparison is always true due to limited range of
data type




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24074] Network uint8 move_rate + variable move_fragments => unvalidated low limit on ruleset-defined unit move rate

[Jacob Nevins]

Update of bug #24074 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #7:

Patches.

Difference between trunk/S2_6 and S2_5 (apart from the use of capabilities) is
that S2_5 doesn't increase the range of move_fragments and igter_cost, as that
would have been disruptive. I don't expect this to be a significant limitation
in practice.

(file #25747, file #25748, file #25749)
___

Additional Item Attachment:

File name: trunk-net-extended-move-rate.patch Size:4 KB
File name: S2_6-net-extended-move-rate.patch Size:4 KB
File name: S2_5-net-extended-move-rate.patch Size:15 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24070] terrain alteration and pillaging broken using all default settings

[Jacob Nevins]

Update of bug #24070 (project freeciv):

  Status:   Need Info => Works For Me   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6568] Rates dialog style

[Marko Lindqvist]

Update of patch #6568 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24081] Ruleset loading could validate against network protocol limits

[Jacob Nevins]

Follow-up Comment #3, bug #24081 (project freeciv):

Aha, so the cheap thing to do is also the right thing :)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24082] Map Update Bugs

[Christian Knoke]

URL:
  

 Summary: Map Update Bugs
 Project: Freeciv
Submitted by: chrisk
Submitted on: Sun 15 Nov 2015 03:10:29 PM CET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.1
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:


Vers. 2.5.1 Gtk3 cpmpiled from source, multiplayer, one-human game

In some cases, the map or the minimap is not updated correctly.
In all cases, the (mini)map display is corrected, if I right-click on a
non-central spot of the main map (but maybe not by right-click in the
minimap).

I try to list these here, maybe add later on.


1 Changing production of a city, from within the city report, does not update
production display on map

2 At the beginning of a new turn, units on minimap are not correct

3 At the beginning of a new turn, units shown on map are not always correct.
This interferes with the display larger than map update bug.






___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24070] terrain alteration and pillaging broken using all default settings

[wotan]

Additional Item Attachment, bug #24070 (project freeciv):

File name: freeciv-T0456-Y02031-auto.sav.xz Size:62 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24079] Editor restricts moves_left editing to unit's base move_rate

[Jacob Nevins]

URL:
  

 Summary: Editor restricts moves_left editing to unit's base
move_rate
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 15 Nov 2015 11:45:51 UTC
Category: editor
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

...but larger values are legal and can happen naturally due to veteran
move_bonus and effects. This prevents editing civ2civ3 Nuclear properly once
the techs enabling its movement are known, for instance.

Restriction is implemented on both client GUI and server (edithand.c).

I don't think we can really impose any valid restriction below what the
network protocol can handle (cf bug #24074).




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24080] Include packet/field name in "Trying to put X into Y bits" messages?

[Jacob Nevins]

URL:
  

 Summary: Include packet/field name in "Trying to put X into Y
bits" messages?
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 15 Nov 2015 12:30:22 UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

When we get a message like


1: Trying to put 65616 into 16 bits; it will result 80 at receiving side.


reported from a non-debug build, the first thing we usually want to know is
which packet and field it's talking about.
(Debug builds output a backtrace which helps a lot, but that's no good for
reports from real games.)

It would be possible for the invocations of DIO_PUT() from packets_gen.c to
pass string representations of the packet and field names, to put in the
message in case of failure. (Other invocations of the dio_put family of
functions could be made to pass NULL, through wrappers.)

However, I don't know if the extra pointer parameter passing would
significantly impact performance. Also all the field names would end up in the
binary (if they're not there already; packet names are, in packet_name9)).




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24070] terrain alteration and pillaging broken using all default settings

[Marko Lindqvist]

Follow-up Comment #7, bug #24070 (project freeciv):

> trunk yes, with supplied savegame

Umh, it's turn 1 savegame. There's nothing to pillage there.


I was about to check if the problem described could be caused by bug #24067,
but that would require that the original savegame was from freeciv-2.4 (or
earlier) classic/default ruleset.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24078] Units Filter / Full MP vs veteran and effect move rate bonuses

[Jacob Nevins]

URL:
  

 Summary: Units Filter / Full MP vs veteran and effect move
rate bonuses
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 15 Nov 2015 11:36:48 UTC
Category: client-qt
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

Noticed in passing this code in gui-qt/menu.cpp:mr_menu::apply_2nd_filter(),
not tested:


  if (punit->moves_left  == punit->utype->move_rate && u_filter.full_mp) {
unit_focus_add(punit);
  }


I think this will filter out units with *more* move points than their base
move_rate, which is probably not what's desired. This can happen due to
veteran bonuses and Move_Bonus effects.

Not sure what the desired behaviour is. Could replace with a simple >=, or
could try to match the moves that the unit would actually have got at the
start of the turn. (The latter can be tricky: on the one hand it's better for
civ2civ3 Nuclear units, on the other hand it's tricky with the penalty for
starting a turn on Mountains in civ2civ3.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24081] Ruleset loading could validate against network protocol limits

[Marko Lindqvist]

Follow-up Comment #2, bug #24081 (project freeciv):

> can only be done once all the ruleset fields for a packet have been loaded

Which would fit the general preference that validation takes place in
rssanity.c for the benefit of getting the check apply to ruledit too, wouldn't
it?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24070] terrain alteration and pillaging broken using all default settings

[Jacob Nevins]

Update of bug #24070 (project freeciv):

  Status:None => Need Info  
 Release:svn  => trunk  

___

Follow-up Comment #6:

Sorry, yes, I could have worked that out. Trunk civ2civ3.

Anyway, I can't reproduce problems with terrain altering or pillaging with
trunk r30604, whether or not the activity takes place across a savegame
save/load cycle.
I've attached two savegames modified from yours with the editor; in the first,
workers are building mine and irrigation and transforming to forest; in the
second, warriors are pillaging mine and irrigation. Both work as I expect.

I'm probably not using the exact version you were, but I haven't seen any
fixes go by that look obviously relevant.

Can you describe in more detail a precise situation that does not behave as
you expect, and what you expected to happen?

> in set_unit_activity_targeted() [unit.c::1234]: assertion
'activity_requires_target(new_activity) || new_target == ((void *)0)' failed.
Indeed, that's not good and may be relevant. I've not seen that.

(file #25743, file #25744)
___

Additional Item Attachment:

File name: stoat.sav.xz   Size:14 KB
File name: stoat2.sav.xz  Size:15 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24078] Units Filter / Full MP vs veteran and effect move rate bonuses

[Marko Lindqvist]

Follow-up Comment #1, bug #24078 (project freeciv):

> moves that the unit would actually have got at the start of the turn.

That would require omniscience -> not possible without server's help (should
store the 'turn start' value)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6595] Qualify "Railroad" tech name for making it distinct from the road/extra name

[Marko Lindqvist]

URL:
  

 Summary: Qualify "Railroad" tech name for making it distinct
from the road/extra name
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 15 Nov 2015 09:34:14 PM EET
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

Noticed that in Finnish translation railroad tech had no capital first letter
unlike all other techs in the same list. (Could use out C_() macro for that
specific case, but qualifying the string may solve problems on other
translations too, and gives the control to translator)



___

File Attachments:


---
Date: Sun 15 Nov 2015 09:34:14 PM EET  Name: QualifiedRailroad.patch  Size:
3kB   By: cazfi


---
Date: Sun 15 Nov 2015 09:34:14 PM EET  Name: QualifiedRailroad-S2_5.patch 
Size: 3kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24085] autogen.sh should check python existence

[Marko Lindqvist]

Update of bug #24085 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.5.2, 2.6.0, 3.0.0

___

Follow-up Comment #1:

Patch. Accept any python version at this point (no minimum version defined)

(file #25755)
___

Additional Item Attachment:

File name: PythonCheck.patch  Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24087] city_distribute_surplus_shields: assertion 'unit_has_type_flag(punit, UTYF_UNDISBANDABLE)' failed.

[Marko Lindqvist]

Update of bug #24087 (project freeciv):

 Release: => TRUNK r30617   

___

Follow-up Comment #1:

Autogame attached. Assert fails on turn 171.

(gdb) bt full
#0  0x7433579b in raise (sig=6) at
../nptl/sysdeps/unix/sysv/linux/pt-raise.c:37
resultvar = 0
pid = 
#1  0x006c7511 in fc_assert_fail (file=0x71a52f "server/cityturn.c", 
function=0x71cc20 <__FUNCTION__.27014> "city_distribute_surplus_shields",
line=2071, 
assertion=0x71bd78 "unit_has_type_flag(punit, UTYF_UNDISBANDABLE)",
message=0x796af4 "nologmsg:%s")
at utility/log.c:520
level = LOG_FATAL
#2  0x004a6958 in city_distribute_surplus_shields (pplayer=0x2b33430,
pcity=0x1eb42a0) at server/cityturn.c:2070
upkeep = 1
punit = 0x1f20c70
punit_numbers = 
punit_index = 0
punit_size = 6
__FUNCTION__ = "city_distribute_surplus_shields"
#3  0x004a7989 in city_build_stuff (pplayer=0x2b33430,
pcity=0x1eb42a0) at server/cityturn.c:2373
__FUNCTION__ = "city_build_stuff"
#4  0x004a9118 in update_city_activity (pcity=0x1eb42a0) at
../../src/server/cityturn.c:2898
pplayer = 0x2b33430
gov = 0xe61ee8
__FUNCTION__ = "update_city_activity"
#5  0x004a1966 in update_city_activities (pplayer=0x2b33430) at
server/cityturn.c:591
cities = 
i = 10
r = 0
buf = "\000\000\000\000\000\000\000\000\255Ql", '\000' ,
"\060\225\361\001\000\000\000\000\000\335\377\377\377\177\000\000\346

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24078] Units Filter / Full MP vs veteran and effect move rate bonuses

[mir3x]

Update of bug #24078 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => mir3x  

___

Follow-up Comment #2:

Ok, just changed to simple solution:
(punit->moves_left  >= punit->utype->move_rate && u_filter.full_mp)

Should work.

(file #25752)
___

Additional Item Attachment:

File name: qt_units_filter.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24087] city_distribute_surplus_shields: assertion 'unit_has_type_flag(punit, UTYF_UNDISBANDABLE)' failed.

[Marko Lindqvist]

Follow-up Comment #2, bug #24087 (project freeciv):

It's probably caused by call to unit_do_disband_trad() not getting rid of some
unit in the "destroy all but UTYF_UNDISBANDABLE" units loop. That seems like a
legal thing for it to do if no action enabler allows any kind of disband.
We need a reliable way for the code to get rid of an unit so that when we
absolutely must get rid of one, we do.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24087] city_distribute_surplus_shields: assertion 'unit_has_type_flag(punit, UTYF_UNDISBANDABLE)' failed.

[Marko Lindqvist]

Follow-up Comment #3, bug #24087 (project freeciv):

Or maybe get rid of the assert, and consider any unit that has survived the
previous loop as Undisbandable?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6583] Turn done button not active when server considered busy

[Marko Lindqvist]

Update of patch #6583 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24088] Fair generator compiler warnings with gcc-4.2.1

[Marko Lindqvist]

URL:
  

 Summary: Fair generator compiler warnings with gcc-4.2.1
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 15 Nov 2015 11:25:40 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

server/generator/mapgen.c: In function 'map_generate_fair_islands':
server/generator/mapgen.c:3452: warning: 'done' may be used uninitialized in
this function
server/generator/mapgen.c:3446: warning: 'pmap' may be used uninitialized in
this function

Fix attached



___

File Attachments:


---
Date: Sun 15 Nov 2015 11:25:40 PM EET  Name: ZeroIterMapgen.patch  Size: 1kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7814] S2_6 datafile format freeze

[Marko Lindqvist]

Update of task #7814 (project freeciv):

  Dependency Removed: => patch #5580


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5580] [Metaticket] Document and cleanup sprite origins setup

[Marko Lindqvist]

Update of patch #5580 (project freeciv):

 Planned Release:   2.6.0 => 3.0.0  

___

Follow-up Comment #1:

With all the dependencies and corner-cases attempt to cleanup this would be
rather disruptive -> removing 2.6 target.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24067] Old classic (default) save games are loaded as civ2civ3

[Marko Lindqvist]

Follow-up Comment #5, bug #24067 (project freeciv):

- Load version number from the secfile as loading->version is not yet set

(file #25757)
___

Additional Item Attachment:

File name: DefaultOrDefault-2.patch   Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6417] client goto: respect the final order

[Sveinung Kvilhaugsvik]

Update of patch #6417 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6572] Use gtk_builder instead of gtk_ui_manager

[Marko Lindqvist]

Update of patch #6572 (project freeciv):

  Status:None => In Progress
 Planned Release: => 3.0.0  

___

Follow-up Comment #1:

WIP patch

(file #25758)
___

Additional Item Attachment:

File name: GtkBuilderWIP.patch.bz2Size:10 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24085] autogen.sh should check python existence

[Marko Lindqvist]

URL:
  

 Summary: autogen.sh should check python existence
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 15 Nov 2015 06:38:44 PM EET
Category: bootstrap
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Long time ago, before autogen.sh was added, we had to give up on the idea that
python existence could be checked by configure, since python is *not*
requirement when building from the release tarball.
Now we have autogen.sh that does checking of such components that are not
requirements for building freeciv from the release tarball, but are
requirements only for building directly from the files availble in svn,
including autotools required to build the release tarball itself.

Tangent -> Lately our documentation may have been a bit sloppy in this
respect, listing things like specific autoconf and automake versions as
requirements, while they aren't, for our release tarballs. They are
requirements only for freeciv developers working directly from svn. Also some
documents may claim ./autogen.sh as a way to build from a tarball, while the
official way should be using the already generated ./configure (or
'../src/configure' as I like to document use of separate build dir)

Now autogen.sh should check presence of the python, required when building
from svn.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24039] Notification about acquiring an bonus tech not sent to embassies

[Marko Lindqvist]

Update of bug #24039 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24086] pf_fuel_map_create_segment: warning: comparison is always true due to limited range of data typee

[Marko Lindqvist]

URL:
  

 Summary: pf_fuel_map_create_segment: warning: comparison is
always true due to limited range of data typee
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 15 Nov 2015 06:57:49 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_5
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.2

___

Details:

common/aicore/path_finding.c: In function 'pf_fuel_map_create_segment':
common/aicore/path_finding.c:2186: warning: comparison is always true due to
limited range of data type

It certainly is and the code in question is an assert about it:

fc_assert(256 > node1->size_alloc); /* node1->size_alloc has only 8 bits. */





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24087] city_distribute_surplus_shields: assertion 'unit_has_type_flag(punit, UTYF_UNDISBANDABLE)' failed.

[Marko Lindqvist]

Update of bug #24087 (project freeciv):

 Summary: city_distribute_surplus_shields: a sertion
'unit_has_type_flag(punit, UTYF_UNDISBANDABLE)' failed. =>
city_distribute_surplus_shields: assertion 'unit_has_type_flag(punit,
UTYF_UNDISBANDABLE)' failed.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24087] city_distribute_surplus_shields: a sertion 'unit_has_type_flag(punit, UTYF_UNDISBANDABLE)' failed.

[Marko Lindqvist]

URL:
  

 Summary: city_distribute_surplus_shields: a sertion
'unit_has_type_flag(punit, UTYF_UNDISBANDABLE)' failed.
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 15 Nov 2015 07:20:54 PM EET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

With sandbox.ruleset on TRUNK:

city_distribute_surplus_shields() [../src/server/cityturn.c::2071]: assertion
'unit_has_type_flag(punit, UTYF_UNDISBANDABLE)' failed.


Trying to reproduce.





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6578] Keep only necessary info about sdl-client options

[Marko Lindqvist]

Update of patch #6578 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev