[Freeciv-Dev] [bug #24126] Leader names duplicated between nations

2015-11-28 Thread Jacob Nevins
Follow-up Comment #2, bug #24126 (project freeciv):

Separate tickets raised for all bugs found in passing.

> I think create_barbarian_player() can crash in this situation.
bug #24130

> player's nation/leader/etc choice is silently ignored
bug #24128

> pick_random_player_name() could try a bit harder to find 
> candidates though. Currently there may be a candidate which it 
> doesn't pick.
bug #24129

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23791] Ruleset nation leader uniqueness check doesn't work and is quadratic in total number of leader names

2015-11-28 Thread Jacob Nevins
Update of bug #23791 (project freeciv):

  Status: In Progress => Need Info  
 Planned Release: => 2.5.2, 2.6.0, 3.0.0

___

Follow-up Comment #4:

Attached a patch series, but it may need to change, depending on what we
decide in bug #24126.
(We can get rid of the quadratic behaviour and improve server startup one way
or another regardless.)

(file #25867)
___

Additional Item Attachment:

File name: trunk-leader-names-genhash.mbox Size:18 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6642] fc_strfoldcase(), case-insensitive genhash/spechash utilities

2015-11-28 Thread Jacob Nevins
URL:
  

 Summary: fc_strfoldcase(), case-insensitive genhash/spechash
utilities
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun 29 Nov 2015 00:09:16 UTC
Category: None
Priority: 5 - Normal
  Status: Need Info
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

I developed and tested this for bug #23791. It's not clear whether it's needed
now, so submitting ticket so that we have it if it's useful in future.

Trunk only. S2_6 and older branches would need a different (simpler)
implementation.



___

File Attachments:


---
Date: Sun 29 Nov 2015 00:09:16 UTC  Name: trunk-strfoldcase.patch  Size: 11kB 
 By: jtn
trunk r30806

---
Date: Sun 29 Nov 2015 00:09:16 UTC  Name: trunk-strfoldcase-torture-test.patch
 Size: 7kB   By: jtn
trunk r30806


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #24129] Try harder to find a unique player name for AI players

2015-11-28 Thread Jacob Nevins
Update of bug #24129 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_6-S2_5-pick-leader-name-better.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #24130] Trouble when barbarian player is revived but no leader names available

2015-11-28 Thread Jacob Nevins
Update of bug #24130 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_6-barb-revive-leader-name.patch Size:1 KB
File name: S2_5-barb-revive-leader-name.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #24128] E_NATION_SELECTED shouldn't be disabled by default

2015-11-28 Thread Jacob Nevins
Update of bug #24128 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_6-S2_5-msg-nation-selected-default.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22788] multiplayer ruleset: Techs are given both by Lua script and other ruleset mechanisms

2015-11-28 Thread Jacob Nevins
Update of bug #22788 (project freeciv):

  Status:None => Duplicate  
 Open/Closed:Open => Closed 

___

Follow-up Comment #3:

> Spotted again and confirmed in bug #24098.
Will be fixed there.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #24098] multiplayer: Darwin's Voyage gives 4 techs instead of 2

2015-11-28 Thread Jacob Nevins
Update of bug #24098 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => jtn
 Planned Release: => 2.5.2, 2.6.0, 3.0.0

___

Additional Item Attachment:

File name: trunk-S2_6-S2_5-multiplayer-darwin-2manytechs.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #24130] Trouble when barbarian player is revived but no leader names available

2015-11-28 Thread Jacob Nevins
URL:
  

 Summary: Trouble when barbarian player is revived but no
leader names available
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 28 Nov 2015 21:28:49 UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.5.1
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

From bug #24126:
> pick_random_player_name() may return NULL. I think this can lead 
> to AI, civil war, etc players called "Player No. 3".
> * I think create_barbarian_player() can crash in this situation.

Reproduced: not a crash, but an assertion failure and a barbarian with an
empty name, in the case where an existing dead barbarian player is revived.


1: in fc_strlcpy() [support.c::589]: assertion '((void *)0) != src' failed.
2: Backtrace:
2: 0: inst/bin/freeciv-server() [0x6319eb]
2: 1: inst/bin/freeciv-server(vdo_log+0x8b) [0x63541b]
2: 2: inst/bin/freeciv-server(do_log+0x7d) [0x6354cd]
2: 3: inst/bin/freeciv-server(fc_assert_fail+0x8e) [0x6356be]
2: 4: inst/bin/freeciv-server(fc_strlcpy+0x85) [0x643ca5]
2: 5: inst/bin/freeciv-server(create_barbarian_player+0x35a) [0x48953a]
2: 6: inst/bin/freeciv-server(summon_barbarians+0x9f2) [0x48aba2]
2: 7: inst/bin/freeciv-server(srv_main+0x1953) [0x43ae23]
2: 8: inst/bin/freeciv-server(main+0x21e) [0x431b7e]
2: 9: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)
[0x7f586cf0eec5]
2:10: inst/bin/freeciv-server() [0x43258f]





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #24129] Try harder to find a unique player name for AI players

2015-11-28 Thread Jacob Nevins
URL:
  

 Summary: Try harder to find a unique player name for AI
players
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 28 Nov 2015 21:15:26 UTC
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.5.1
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

From bug #24126:
> pick_random_player_name() could try a bit harder to find 
> candidates though. Currently there may be a candidate which it 
> doesn't pick.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #24128] E_NATION_SELECTED shouldn't be disabled by default

2015-11-28 Thread Jacob Nevins
URL:
  

 Summary: E_NATION_SELECTED shouldn't be disabled by default
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 28 Nov 2015 21:14:45 UTC
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.5.1
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

From bug #24126:
> * It would be easy for players to pick the same leader name.
> ** This doesn't seem to be handled particularly well at the 
> moment (player's nation/leader/etc choice is silently ignored).
This is because in my client, and the defaults, E_NATION_SELECTED messages
were entirely disabled. This means most people never see the messages:
* "%s nation is not available for user selection."
* "%s nation is already in use."
* "Please choose a non-blank name."
* "That nation is already in use."
* "Another player already has the name '%s'. Please choose another name."
* "Please choose a name containing only ASCII characters."
* "%s is the %s ruler %s."

None of these look like they're going to incredibly annoying to have on by
default (the last one is all you'll usually see). Some are errors that we
should show users. Some should never occur with well-behaved clients.

I think this was disabled in r10901
 in 2005.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6641] Qt client - choose nation when return is pressed on ruler name.

2015-11-28 Thread mir3x
URL:
  

 Summary: Qt client - choose nation when return is pressed on
ruler name.
 Project: Freeciv
Submitted by: mir3x
Submitted on: Sat 28 Nov 2015 09:22:58 PM CET
Category: client-qt
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6, 3.0

___

Details:

Pressing enter on leader name line edit, will choose that nation.
(in pregame, when choosing nations)




___

File Attachments:


---
Date: Sat 28 Nov 2015 09:22:58 PM CET  Name: qt_nationchoose_enter.patch 
Size: 604B   By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #24127] Qt client - network page selection not updated when switching tabs

2015-11-28 Thread mir3x
URL:
  

 Summary: Qt client - network page selection not updated when
switching tabs
 Project: Freeciv
Submitted by: mir3x
Submitted on: Sat 28 Nov 2015 08:28:12 PM CET
Category: client-qt
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.2, 2.6, 3.0

___

Details:

Fix attached.



___

File Attachments:


---
Date: Sat 28 Nov 2015 08:28:12 PM CET  Name: qt_net_selection.patch  Size: 5kB
  By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #24126] Leader names duplicated between nations

2015-11-28 Thread Jacob Nevins
Follow-up Comment #1, bug #24126 (project freeciv):

That's a lot of choices to make. I wonder about instead relaxing the rules.

Non-unique leader names would mean that:
* pick_random_player_name() may return NULL. I think this can lead to AI,
civil war, etc players called "Player No. 3".
** I think create_barbarian_player() can crash in this situation.
* It would be easy for players to pick the same leader name.
** This doesn't seem to be handled particularly well at the moment (player's
nation/leader/etc choice is silently ignored).

I vaguely wonder about a more relaxed rule, such as a rule that at least one
of a nation's leader names must be unique. However, I'm not convinced it's
worth it.
* It would be rather hard to take advantage of this rule in
pick_random_player_name(). It would not only have to find the currently unique
leader name, it would have to try not to paint future calls into a corner;
either duplicate names would never be picked, or (with more computation) only
picked once unique ones had been exhausted.
* This would mean that human players would always have an available choice
though, without having to invent names.

In any case, it's not practical to completely eliminate the chance of
pick_random_player_name() returning NULL. In pathological cases, human players
could exhaust all available leader names for a nation by picking custom names,
leaving the server with none to choose from. (The server doesn't take leader
name availability into account when picking a nation, and probably shouldn't.)
So the server needs to be robust against this case regardless of what we
decide here.
* pick_random_player_name() could try a bit harder to find candidates though.
Currently there may be a candidate which it doesn't pick.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23791] Ruleset nation leader uniqueness check doesn't work and is quadratic in total number of leader names

2015-11-28 Thread Jacob Nevins
Follow-up Comment #3, bug #23791 (project freeciv):

(There are 4232 unique leader names in current rulesets.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23791] Ruleset nation leader uniqueness check doesn't work and is quadratic in total number of leader names

2015-11-28 Thread Jacob Nevins
Update of bug #23791 (project freeciv):

  Depends on: => bugs #24126


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23791] Ruleset nation leader uniqueness check doesn't work and is quadratic in total number of leader names

2015-11-28 Thread Jacob Nevins
Update of bug #23791 (project freeciv):

 Summary: Loading ruleset is quadratic in total number of
nation leaders => Ruleset nation leader uniqueness check doesn't work and is
quadratic in total number of leader names

___

Follow-up Comment #2:

What's more, the uniqueness check doesn't work! The current nation isn't
actually checked against previous nations, previous nations are just checked
against each other. In effect, we only enforce uniqueness within a single
nation.

This dates to r18279
 in 2010. As
a result, we have many duplicates in existing nations: bug #24126.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #24126] Leader names duplicated between nations

2015-11-28 Thread Jacob Nevins
URL:
  

 Summary: Leader names duplicated between nations
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 28 Nov 2015 18:01:58 UTC
Category: rulesets
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.1
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

Leader names were intended to be checked for uniqueness between nations, but
were not, so some duplicates crept in.

From a test version of my bug #23791 patch (against trunk, but nations haven't
changed for ages):


Nations African and Abyssinian share the same leader "Haile Selassie".
Nations Amazigh and Andalusi share the same leader "Tariq ibn Ziad".
Nations Breton and Brandenburgian share the same leader "Anna".
Nations Californian and American share the same leader "Ronald Reagan".
Nations Cape Verdean and Bissau-Guinean share the same leader "Amílcar
Cabral".
Nations Celtic and Belgic share the same leader "Diwitiakos".
Nations Czechoslovakian and Czech share the same leader "Edvard Beneš".
Nations Ethiopian and Abyssinian share the same leader "Yekuno Amlak".
Nations Gallic and Belgic share the same leader "Ambiorix".
Nations German and Brandenburgian share the same leader "Otto I".
Nations Hanoverian and Anhaltian share the same leader "Georg I".
Nations Hellenic and Cretan share the same leader "Eleutherios Venizelos".
Nations Holy Roman and Austrian share the same leader "Maria Theresia".
Nations Khmer and Cambodian share the same leader "Jayavarman II".
Nations Kittitian and Nevisian and American share the same leader "Alexander
Hamilton".
Nations Libyan and Cyrenaican share the same leader "Muhammad Idris".
Nations Luxembourgish and Burgundic share the same leader "Sigismund".
Nations Malaysian and Circassian share the same leader "Mansur".
Nations Mecklenburgian and Austrian share the same leader "Albrecht II".
Nations Oldenburgian and Anhaltian share the same leader "Friedrich August".
Nations Ostrogothic and Gothic share the same leader "Þiudareiks".
Nations Papua New Guinean and Papuan share the same leader "Bill Skate".
Nations Polish and Central Lithuanian share the same leader "Józef
Piłsudski".
Nations Prussian and Brandenburgian share the same leader "Albrecht
Friedrich".
Nations Ruthenian and Russian share the same leader "Oleg".
Nations Schleswig-Holsteinian and Badian share the same leader "Karl
Friedrich".
Nations Sinhalese and Lankese share the same leader "Vijaya".
Nations Slovenian and Carantanian share the same leader "Valtunk".
Nations Solomon Islander and Polynesian share the same leader "Solomon
Mamaloni".
Nations Sotho and Lesothoan share the same leader "Moshoeshoe I".
Nations Soviet and Russian share the same leader "Vladimir Lenin".
Nations Spanish and Asturian share the same leader "Pelayo".
Nations Tahitian and Polynesian share the same leader "Pomare IV".
Nations Tanzanian and Tanganyikan share the same leader "Julius Nyerere".
Nations Texan and American share the same leader "Lyndon B. Johnson".
Nations Thracian and Dacian share the same leader "Burebista".
Nations Thuringian and Belgian share the same leader "Elisabeth".
Nations Tswana and Botswanan share the same leader "Sebele".
Nations Turkmen and Seljuk share the same leader "Alp Arslan".
Nations Turkish and Seljuk share the same leader "Alp Arslan".
Nations Ukrainian and Cossack share the same leader "Bohdan Khmelnytsky".
Nations Vedic and Indian share the same leader "Ashoka".
Nations Veletian and Mecklenburgian share the same leader "Pribislaw".
Nations Venezuelan and South American share the same leader "Francisco de
Miranda".
Nations Visigothic and Gothic share the same leader "Aþanareiks".
Nations Walloon and Crusader share the same leader "Godefroid de Bouillon".
Nations Western Pomeranian and Kashubian share the same leader "Racibor".
Nations Barbarian and Hunnic share the same leader "Attila".





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23791] Loading ruleset is quadratic in total number of nation leaders

2015-11-28 Thread Jacob Nevins
Update of bug #23791 (project freeciv):

  Status:None => In Progress
 Assigned to:None => jtn


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23791] Loading ruleset is quadratic in total number of nation leaders

2015-11-28 Thread Jacob Nevins
Follow-up Comment #1, bug #23791 (project freeciv):

Trunk server startup is noticeably slower than S2_6; I think this is really
showing up that the ICU-based fc_strcasecmp() is slower than before.

On my machine, trunk server takes 2.436s to start with classic ruleset as
'default'; S2_6 takes 1.136s. Profiling shows a large chunk of this being in
nation loading in both cases.

(I've controlled for trunk defaulting to civ2civ3 instead of S2_6's classic,
which doesn't make much difference.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6640] Qt-client - make text lighter in chat and background darker.

2015-11-28 Thread mir3x
URL:
  

 Summary: Qt-client - make text lighter in chat and background
darker.
 Project: Freeciv
Submitted by: mir3x
Submitted on: Sat 28 Nov 2015 02:15:09 PM CET
Category: client-qt
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6, 3.0

___

Details:

In game chat, all chat messages are made ligher (brighter) and 
background a bit darker.



___

File Attachments:


---
Date: Sat 28 Nov 2015 02:15:09 PM CET  Name: qt_lighter_chat.patch  Size: 3kB 
 By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6639] Standardise on "nation set" over "nationset" in game text

2015-11-28 Thread Jacob Nevins
Update of patch #6639 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-nation-set-words.patch   Size:4 KB
File name: S2_6-nation-set-words.patchSize:5 KB
File name: S2_5-nation-set-words.patchSize:4 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6639] Standardise on "nation set" over "nationset" in game text

2015-11-28 Thread Jacob Nevins
URL:
  

 Summary: Standardise on "nation set" over "nationset" in game
text
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 28 Nov 2015 12:24:49 UTC
Category: None
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

cazfi points out that in-game English text uses "nationset" and "nation set"
inconsistently.

There's no particular pattern to it, I have just vacillated between the two
over time. Go for the one that doesn't involve inventing words.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #6104] [Killstack] Patch allows unit to escape instead of been killed

2015-11-28 Thread Sławomir Lach
Follow-up Comment #65, patch #6104 (project freeciv):

Ok. My path is just working. I have checked that rivers get 50% defense bonus,
while mountains just 2%. Code is def_bonus = (100 + tile_bonus) * (100 +
base_bonus) / 100 - 100; Am I right river has bigger defense bonus than hills?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev