[Freeciv-Dev] [bug #24820] Assert 'params->fuel == 1' with "Coast" unit

2016-08-12 Thread Marko Lindqvist 
Follow-up Comment #2, bug #24820 (project freeciv):

> I'm yet to check if AI behavior is in any way sensible.

There's no regression in it, though it's constantly losing "Coast" units
running out-of-fuel. So net effect of the patch is that crash is avoided. I'm
about to commit current patch as a resolution to this ticket ("Crash when
ruleset defines fuel for units that get used with regular pathfinding map")

New ticket about AI problems should be created.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-12 Thread mir3x 
Follow-up Comment #5, bug #24935 (project freeciv):

it will still crash in that case : bug #24944
Its only visible when metaserver is up but returning errors.
Another thread will come and try just append_output something

and u have fc_client::eventFilter()
no need to create fc_client::event().

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24831] WARNING **: invalid source position for vertical gradient

2016-08-12 Thread Louis Moureaux 
Follow-up Comment #3, bug #24831 (project freeciv):

This looks like a warning from the Gtk pixbuf theme engine. So my bet is
QGtkStyle.

___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-12 Thread Louis Moureaux 
Follow-up Comment #4, bug #24935 (project freeciv):

The patch is still not thread-safe because the main thread accesses the status
bar QLabel without locking mut_ex.

Attached patch is thread-safe *unless* the version message can be received
after either gui() or the QApplication are destroyed (need help here: is it
the case?). It is thread-safe because QCoreApplication::postEvent() is
thread-safe, and QObject::event() is called from the thread the object was
created in (see Thread Affinity in the QObject doc).

The trunk patch also applies to 2.6.

(file #28276, file #28277)
___

Additional Item Attachment:

File name: qt-metaserver-version-trunk.patch Size:3 KB
File name: qt-metaserver-version-s25.patch Size:4 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24935] Version message not shown at Qt-client

2016-08-12 Thread mir3x 
Follow-up Comment #3, bug #24935 (project freeciv):

>> Also, the variable this_thread isn't destroyed properly. 

Mb bc its not variable but pointer, and its not allocated to new object.

(file #28274, file #28275)
___

Additional Item Attachment:

File name: qt_meta_msg.patch  Size:3 KB
File name: qt_meta_msg-ftrunk.patch   Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7574] Gtk clients: act sel dlg paradrop and airlift

2016-08-12 Thread Sveinung Kvilhaugsvik 
Update of patch #7574 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7593] Delete unused act vs own tile functions

2016-08-12 Thread Sveinung Kvilhaugsvik 
Update of patch #7593 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7573] Gtk clients: ask for target for "Do..."

2016-08-12 Thread Sveinung Kvilhaugsvik 
Update of patch #7573 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7589] Share unithand's action not enabled reason

2016-08-12 Thread Sveinung Kvilhaugsvik 
Update of patch #7589 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7583] Handle paratroopers_range in the action system

2016-08-12 Thread Sveinung Kvilhaugsvik 
Update of patch #7583 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7586] Deduplicate action_mp_full_makes_legal()

2016-08-12 Thread Sveinung Kvilhaugsvik 
Update of patch #7586 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7491] Qt client: Use helper<> to propagate output_window_append

2016-08-12 Thread Louis Moureaux 
Follow-up Comment #6, patch #7491 (project freeciv):

> I don't know the threading model well enough
After investigation, it looks like the client is a single-threaded
application, except for the metaserver queries.

___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] Git branching model for Freeciv-web

2016-08-12 Thread Andreas Røsdal 
Hello,

I would like to make a change to the git branching model for Freeciv-web.
The Freeciv-web git repo can be found here:
https://github.com/freeciv/freeciv-web

Today all development happens in the master branch in git and is released
from the master
branch to production when I have the chance to do it at random time
intervals. There are also some other feature-specific branches and the
testing branch currently.

I would like to change the branching model for Freeciv-web to have a master
branch and a develop branch. This is based on "A successful Git branching
model", more details here:
http://nvie.com/posts/a-successful-git-branching-model/

The master branch should be production-ready and will be deployed to the
production server every night automatically, if there are any git changes
and the tests pass.

The develop branch is where development of new features occurs. There can
also be other branches, which would be merged to the develop branch when
ready.

So in order to deploy to production, simply merge from develop to the
master branch,
and then the master branch will be deployed to production the coming night.

I will implement this change very soon if there are no objections.

Regards,
Andreas
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23992] Client page change in queue mess

2016-08-12 Thread Marko Lindqvist 
Update of bug #23992 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24965] Tooltips in Remote Server Options Control Dialog may flicker

2016-08-12 Thread Louis Moureaux 
Follow-up Comment #2, bug #24965 (project freeciv):

If the tooltip is very big, it may pop up below the mouse. Then the widget
gets a "mouse leaved" event and hides the tooltip. Thus it gets a "mouse
entered" event... I can get a similar behavior with the Qt client and very big
fonts.

Possible solutions include hyphenating big (relative to screen) tooltips and
making them interactive and add a scrollbar.

___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24965] Tooltips in Remote Server Options Control Dialog may flicker

2016-08-12 Thread mir3x 
Follow-up Comment #1, bug #24965 (project freeciv):

Maybe your hands are shaking, or u live in flat which is not flat, and mouse
is moving down all the time. Or maybe mouse is just broken.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24965] Tooltips in Remote Server Options Control Dialog may flicker

2016-08-12 Thread Christian Knoke 
URL:
  

 Summary: Tooltips in Remote Server Options Control Dialog may
flicker
 Project: Freeciv
Submitted by: chrisk
Submitted on: Fr 12 Aug 2016 14:58:39 CEST
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.5+ R33572
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 
 Contains string changes: None

___

Details:


Opening Game-->Options-->Remote Server, on start or in game, first tab, hover
mouse over GENERATOR text or TOPOLOGY text, make the (large) tool tip help
texts flicker, rather than show up, consuming some amounts of the CPU core
here

FWIW, parts of my desktop show up milliseconds wise, where the tool tip area
is expected.

Christian





___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7591] Merge ruledit_qt_setup(), ruledit_qt_run(), and ruledit_qt_close()

2016-08-12 Thread Marko Lindqvist 
Update of patch #7591 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6884] Server settings to scale map-size-related effects

2016-08-12 Thread Marko Lindqvist 
Update of patch #6884 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #3:

Setting for adjusting trade relative to world size.

(file #28271)
___

Additional Item Attachment:

File name: TradeWorldRelPct.patch Size:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24957] Segmentation faul in is_action_enabled.constprop

2016-08-12 Thread Marko Lindqvist 
Update of bug #24957 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24963] Colossus obsoleted by flight still active

2016-08-12 Thread Jacob Nevins 
Update of bug #24963 (project freeciv):

  Status:None => Invalid
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev