[Freeciv-Dev] [patch #7997] Add new function popup_combat_info

2016-11-15 Thread mir3x
URL:
  

 Summary: Add new function popup_combat_info
 Project: Freeciv
Submitted by: mir3x
Submitted on: Wed 16 Nov 2016 01:17:18 AM CET
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0
 Contains string changes: No

___

Details:

popup_combat_info sends detailed battle information to client, so it could be
shown in some pretty way or stored to some statistics.



___

File Attachments:


---
Date: Wed 16 Nov 2016 01:17:18 AM CET  Name: popup_combat_info.patch  Size:
9kB   By: mir3x


---
Date: Wed 16 Nov 2016 01:17:18 AM CET  Name: popup_combat_info-trunk.patch 
Size: 8kB   By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7987] Precious FREECIV_LABEL_FORCE

2016-11-15 Thread Marko Lindqvist
Update of patch #7987 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7984] Sandbox ruleset fortress and airbase hides units inside

2016-11-15 Thread Marko Lindqvist
Update of patch #7984 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7996] Extra help to say if extra hides units inside

2016-11-15 Thread Marko Lindqvist
URL:
  

 Summary: Extra help to say if extra hides units inside
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 15 Nov 2016 10:15:48 PM EET
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: None

___

Details:





___

File Attachments:


---
Date: Tue 15 Nov 2016 10:15:48 PM EET  Name: HidingExtraHelp.patch  Size: 604B
  By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #25284] gtk3 can't pillage ruins

2016-11-15 Thread wotan
Follow-up Comment #4, bug #25284 (project freeciv):

Ok now it does work for a Marines unit, but not for Engineer unit, where I
expected it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7995] Spaces around '!='

2016-11-15 Thread Marko Lindqvist
URL:
  

 Summary: Spaces around '!='
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 15 Nov 2016 09:50:41 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: None

___

Details:

Add spaces around '!=' where ever they were still missing.



___

File Attachments:


---
Date: Tue 15 Nov 2016 09:50:41 PM EET  Name: SpaceNotEqualSpace.patch  Size:
3kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #25284] gtk3 can't pillage ruins

2016-11-15 Thread wotan
Follow-up Comment #3, bug #25284 (project freeciv):

patch doesn't work for me, does it work on savegames from before the patch?


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7986] Spaces around '=='

2016-11-15 Thread Marko Lindqvist
Update of patch #7986 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #25306] Theme installed to wrong directory

2016-11-15 Thread Marko Lindqvist
URL:
  

 Summary: Theme installed to wrong directory
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 15 Nov 2016 09:38:27 PM EET
Category: client-gtk-3.22
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0
 Contains string changes: None

___

Details:

Gtk3.22-client theme is being installed as gtk3x-client theme.

Fix attached.



___

File Attachments:


---
Date: Tue 15 Nov 2016 09:38:27 PM EET  Name: Gtk322ThemeInstallDir.patch 
Size: 14kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7758] [Metaticket] gtk3.22-client for S2_6

2016-11-15 Thread Marko Lindqvist
Update of patch #7758 (project freeciv):

  Status:None => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #25294] Flight units does not return automatically (sometimes)

2016-11-15 Thread mir3x
Update of bug #25294 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.5.6  

___

Follow-up Comment #2:

OK I got it, seems unit stopped bc it encountered city which is next tile from
starting position :D.
Targetting 2.5 only for now, that example didnt failed in 2.6, but code looks
the same, so not sure.


patch attached.

(file #29404)
___

Additional Item Attachment:

File name: serv_fail_return.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #25284] gtk3 can't pillage ruins

2016-11-15 Thread Marko Lindqvist
Update of bug #25284 (project freeciv):

Category:  client-gtk-3.0 => general
  Status:None => Ready For Test 
 Planned Release: => 2.6.0, 3.0.0   

___

Follow-up Comment #2:

Ruins was recently changed to have no "cause". Bug is that no extra with no
cause can be pillaged. Fix attached.

(file #29403)
___

Additional Item Attachment:

File name: PillageECNone.patchSize:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #25294] Flight units does not return automatically (sometimes)

2016-11-15 Thread mir3x
Follow-up Comment #1, bug #25294 (project freeciv):

I couldnt figure whats wrong but:
server finds path and refuel point
but unit doesnt move to refuel point.

It dossnt happen in 2.6.

Something wrong might be here:
alive = adv_follow_path(punit, path, ptile);

Alive is returned ok, but unit doesnt move to ptile and soon is wiped.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7994] Qt client - ported popup_musicset_suggestion_dialog()

2016-11-15 Thread mir3x
URL:
  

 Summary: Qt client - ported
popup_musicset_suggestion_dialog()
 Project: Freeciv
Submitted by: mir3x
Submitted on: Tue 15 Nov 2016 05:23:13 PM CET
Category: client-qt
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0
 Contains string changes: Yes

___

Details:

Patch attached



___

File Attachments:


---
Date: Tue 15 Nov 2016 05:23:13 PM CET  Name: qt_popup_musicset_sugg.patch 
Size: 1kB   By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7993] Qt client - ported popup_soundset_suggestion_dialog()

2016-11-15 Thread mir3x
URL:
  

 Summary: Qt client - ported
popup_soundset_suggestion_dialog()
 Project: Freeciv
Submitted by: mir3x
Submitted on: Tue 15 Nov 2016 05:15:56 PM CET
Category: client-qt
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0
 Contains string changes: Yes

___

Details:

Patch attached



___

File Attachments:


---
Date: Tue 15 Nov 2016 05:15:56 PM CET  Name: qt_popup_soundset_sugg.patch 
Size: 1kB   By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7091] Implement popup_tileset_suggestion_dialog()

2016-11-15 Thread mir3x
Update of patch #7091 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => mir3x  
 Planned Release:   3.0.0 => 2.6, 3.0.0 
 Contains string changes:None => Yes

___

Follow-up Comment #2:

Patch attached.

(file #29400)
___

Additional Item Attachment:

File name: qt_popup_tileset_sugg.patchSize:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7992] Remove base_index()

2016-11-15 Thread Marko Lindqvist
URL:
  

 Summary: Remove base_index()
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 15 Nov 2016 03:34:10 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0
 Contains string changes: None

___

Details:

As FIXME comment says, base_index() as a function makes no sense since bases
are no longer in an array. Remove the function. Callers are made to use
base_number() instead.



___

File Attachments:


---
Date: Tue 15 Nov 2016 03:34:10 PM EET  Name: BaseIndexRm.patch  Size: 5kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #25134] Request for server-side CMA for Freeciv-web

2016-11-15 Thread Marko Lindqvist
Follow-up Comment #2, bug #25134 (project freeciv):

> CMA/governors are server side.

No, they are not. They are (the only) kind of client agents.

However, much of the code governor uses is in common/aicore/ (it's also used
by the server for AI players).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #25134] Request for server-side CMA for Freeciv-web

2016-11-15 Thread mir3x
Follow-up Comment #1, bug #25134 (project freeciv):

CMA/governors are server side.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #25302] SC_LOCK namespace conflict

2016-11-15 Thread Marko Lindqvist
URL:
  

 Summary: SC_LOCK namespace conflict
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 15 Nov 2016 01:39:19 PM EET
Category: client-qt
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0
 Contains string changes: None

___

Details:

Build on msys2 fails due to redefinition of SC_LOCK - also system headers have
something by that name.

Fix attached.



___

File Attachments:


---
Date: Tue 15 Nov 2016 01:39:19 PM EET  Name: ScIfaceLock.patch  Size: 2kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7528] Qt client act sel dlg: switch target unit

2016-11-15 Thread mir3x
Update of patch #7528 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => mir3x  
 Contains string changes:None => No 

___

Follow-up Comment #1:

Patch attached

(file #29394)
___

Additional Item Attachment:

File name: qt_switch_target.patch Size:9 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #7985] Optimise autoattack transport depth check

2016-11-15 Thread Jacob Nevins
Update of patch #7985 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev