Re: [Freeciv-Dev] (PR#39515) struct req_source to struct universal
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39515 On Fri, 10 Aug 2007, William Allen Simpson wrote: Marko Lindqvist wrote: While I have not looked this particular patch, and probably have nothing against it, you should reread http://freeciv.wikia.com/wiki/Commit_rules and what it says about allowing time for comments... Note that it presumes there are managers doing code review. Since nobody was reviewing my patches, even when I gave *weeks* and sent individual messages to various folks, I've not bothered anymore. Just because nobody is saying anything, does not mean nobody is reading it. I try to give patches a quick look when I have the time to see if I can catch something obvious, especially if the patch touches code I've written or touched in the past. - Per ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39515) struct req_source to struct universal
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39515 Marko Lindqvist wrote: While I have not looked this particular patch, and probably have nothing against it, you should reread http://freeciv.wikia.com/wiki/Commit_rules and what it says about allowing time for comments... Note that it presumes there are managers doing code review. Since nobody was reviewing my patches, even when I gave *weeks* and sent individual messages to various folks, I've not bothered anymore. It's just list noise, sending the proposed patch and then the final patch. I've only been sending the final lately But based on your interest, take a look at today's that uses this one, and I'll wait until tomorrow to commit. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39515) struct req_source to struct universal
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39515 Committed trunk revision 13219. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39515) struct req_source to struct universal
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39515 On 09/08/07, William Allen Simpson [EMAIL PROTECTED] wrote: Committed trunk revision 13219. While I have not looked this particular patch, and probably have nothing against it, you should reread http://freeciv.wikia.com/wiki/Commit_rules and what it says about allowing time for comments... - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
