[Freeciv-Dev] [bug #13583] [patch] shield2gold_basics (was PR#40761)
Update of bug #13583 (project freeciv): Status: In Progress = Confirmed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?13583 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13583] [patch] shield2gold_basics (was PR#40761)
Follow-up Comment #2, bug #13583 (project freeciv): Thanks for looking at the patch! changes in version2: - fix all the basic stuff - remove ruleset changes - add documentation (file #5836) ___ Additional Item Attachment: File name: version2-gold3.patch.diff Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?13583 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13583] [patch] shield2gold_basics (was PR#40761)
URL: http://gna.org/bugs/?13583 Summary: [patch] shield2gold_basics (was PR#40761) Project: Freeciv Submitted by: syntron Submitted on: Donnerstag 28.05.2009 um 11:53 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: This patch adds an effect which changes shield upkeep to gold upkeep. It gives the conversion ratio in percent. As example an effect is added which is activated if 'The Corporation' is researched. depends on 13580, 13581, 13582 remarks: - The effect can be activated by buildings or researched techs. Therefore corresponding calls to the function /common/city.c:city_units_upkeep should be added if a new tech is found, an improvement is build or destroyed. ___ File Attachments: --- Date: Donnerstag 28.05.2009 um 11:53 Name: gold3.patch.diff Size: 5kB By: syntron http://gna.org/bugs/download.php?file_id=5823 ___ Reply to this item at: http://gna.org/bugs/?13583 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13583] [patch] shield2gold_basics (was PR#40761)
Update of bug #13583 (project freeciv): Status:None = In Progress Assigned to:None = mbook ___ Follow-up Comment #1: Alright some basic stuff to fix for this patch: - Try to avoid purely whitespace changes in the future (a little is ok I guess, but keep it in mind). - Fix the typo 'teach' which should be 'tech' in the comment for city_unit_upkeep(). - Fix the typo 'shild' which should be 'shield' in the comment in utype_upkeep_cost(). - Try to avoid asking questions in comments in the code that really should be asked in the patch submission or on freeciv-dev. Use a FIXME: or TODO: if you feel it should be left for another later patch. - Fix incorrect spelling 'fallthru' which should be 'fall through'. The above is really minor stuff, but my main objection is the change to the default ruleset. I don't think this should be done; if you want to make it easier for us to test the new effect, provide a custom ruleset and savegame. 諸君、これ以上です。 ___ Reply to this item at: http://gna.org/bugs/?13583 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
