[Freeciv-Dev] [bug #16676] unused variables in struct player_ai
Update of bug #16676 (project freeciv): Status: In Progress = Ready For Test Planned Release: = 2.3.0 ___ Follow-up Comment #5: Patch with corrected ai_calc_data() attached. ___ Reply to this item at: http://gna.org/bugs/?16676 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16676] unused variables in struct player_ai
Additional Item Attachment, bug #16676 (project freeciv): File name: trunk_remove_player_ai_est_upkeep.diff Size:7 KB ___ Reply to this item at: http://gna.org/bugs/?16676 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16676] unused variables in struct player_ai
Update of bug #16676 (project freeciv): Status: Ready For Test = In Progress ___ Follow-up Comment #4: ai_calc_data() does not have effect because it computes the pointers instead of the _trade_ and 'expenses' values. ___ Reply to this item at: http://gna.org/bugs/?16676 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16676] unused variables in struct player_ai
Follow-up Comment #3, bug #16676 (project freeciv): two patches to remove both variables: * prev_gold: not used anywhere * est_upkeep: used in the two mentioned files but nowhere calculated; add aihand.c:ai_calc_data() to calculate the expenses and use this value. I will update bug #16677 once this one is submitted. (file #10330, file #10331) ___ Additional Item Attachment: File name: 20100913-09-trunk-remove-struct-player_ai-prev_gold.patch Size:1 KB File name: 20100913-10-trunk-remove-struct-player_ai-est_upkeep.patch Size:8 KB ___ Reply to this item at: http://gna.org/bugs/?16676 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16676] unused variables in struct player_ai
Update of bug #16676 (project freeciv): Status:None = Ready For Test Assigned to:None = pepeto ___ Reply to this item at: http://gna.org/bugs/?16676 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16676] unused variables in struct player_ai
Follow-up Comment #2, bug #16676 (project freeciv): _est_upkeep_ is still used in aicity.c and aidiplomat.c, but not sure it has been computed somewhere. ___ Reply to this item at: http://gna.org/bugs/?16676 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16676] unused variables in struct player_ai
URL: http://gna.org/bugs/?16676 Summary: unused variables in struct player_ai Project: Freeciv Submitted by: syntron Submitted on: Freitag 10.09.2010 um 21:35 Category: general Severity: 3 - Normal Priority: 1 - Later Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: the struct player_ai (player.h) contains the following variables which are never set (undefined values; = 0 due to the use of calloc()): int prev_gold; int est_upkeep; Should they are removed? Does somebody knows that they are for? ___ Reply to this item at: http://gna.org/bugs/?16676 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16676] unused variables in struct player_ai
Follow-up Comment #1, bug #16676 (project freeciv): They looks like old fields. _prev_gold_ has been added in initial revision (rev #77), and _est_upkeep_ at revision #1821. I guess we can remove them. ___ Reply to this item at: http://gna.org/bugs/?16676 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
