[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault

[Marko Lindqvist]

Update of bug #17439 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault

[Marko Lindqvist]

Update of bug #17439 (project freeciv):

  Status:   Need Info => Ready For Test 
 Planned Release:   2.3.0 => 2.3.0, 2.4.0   

___

Follow-up Comment #12:

I tried to find out where that queued real_players_dialog_update() might come
from. And I think I know the server side problem.

in plrhand.c:split_player():1739 info about new player (newly used slot) is
sent first time. Nation for that nation is set only after that at line 1742.
It's the nature of the client side gui update being queued by gtk_idle_add()
that this bug is not always reproducible. Often client handles updated player
info packet with nation in it before going to that idle handling.

Untested fix attached.

(file #13122)
___

Additional Item Attachment:

File name: NationSetBeforeSend_17439.diff Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault

[Jacob Nevins]

Follow-up Comment #11, bug #17439 (project freeciv):

The backtrace in bug #18185 has a bit more debug info than the one in comment
#6, but I'm not sure it helps narrow it down.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault

[Marko Lindqvist]

Follow-up Comment #10, bug #17439 (project freeciv):

> Dubious client data structures after a civil war.

I assumed this to happen *during* civil war updates (handling of earlier
packet would require information that comes only in later packet), not
*after*, but from the information provided it could be either way.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault

[anonymous]

Follow-up Comment #9, bug #17439 (project freeciv):

Hmm. Dubious client data structures after a civil war. Could this perhaps be
tied up with our lost-city troubles in bug #17990 et al?

-- jtn

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault

[Marko Lindqvist]

Follow-up Comment #8, bug #17439 (project freeciv):

See also bug #18185

Though it's not yet specifically mentioned in this ticket, creation of new AI
player (seen in original report) happens only when there is civil war.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault

[Jacob Nevins]

Follow-up Comment #7, bug #17439 (project freeciv):

Looking at the code, I'd guess that nation_of_player(pplayer) is returning
NULL for some reason. No idea how that can happen, though.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault

[Jordi Negrevernis i Font]

Follow-up Comment #6, bug #17439 (project freeciv):

(gdb) run -a
Starting program: /home/jorneg/freeciv/S2_3/freeciv-2.3/client/freeciv-gtk2
-a
[Thread debugging using libthread_db enabled]
[New Thread 0xb6c18a90 (LWP 9409)]
2: No está presente un controlador real de audio.
2: Se prosigue con el sonido desactivado.
2: Para el soporte de sonido, instala SDL_mixer
2: http://www.libsdl.org/projects/SDL_mixer/index.html
1: in nation_index() [nation.c::483]: assertion '((void *)0) != pnation'
failed.
1: Por favor, informa de este mensaje a http://gna.org/projects/freeciv/

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0xb6c18a90 (LWP 9409)]
0x08070d4e in sprite_get_mask ()
Current language:  auto; currently asm
(gdb) bt full
#0  0x08070d4e in sprite_get_mask ()
No locals.
#1  0x080708dd in sprite_get_bounding_box ()
No locals.
#2  0x0806bf2b in get_flag ()
No locals.
#3  0x0806c1c5 in fill_row ()
No locals.
#4  0x0806c4c6 in real_players_dialog_update ()
No locals.
#5  0x080e9836 in update_unqueue ()
No locals.
#6  0x0805a709 in idle_callback_wrapper ()
No locals.
#7  0xb6f7d101 in ?? () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#8  0xb6f7ecf6 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#9  0xb6f820b3 in ?? () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#10 0xb6f82497 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
No symbol table info available.
#11 0xb74cb264 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
---Type  to continue, or q  to quit---
No symbol table info available.
#12 0x08059f76 in ui_main ()
No locals.
#13 0x08095d9e in client_main ()
No locals.
#14 0x0805986d in main ()
No locals.
(gdb) 

But has no symbols?!


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault

[Jacob Nevins]

Follow-up Comment #5, bug #17439 (project freeciv):

I tried playing a few turns of the savegame with S2_3 r19438 and couldn't
reproduce the problem. (I did see bug #17805, though; I doubt it's related.)

Is it possible for you to run with coredumps enabled and -F, so that you can
get a stack backtrace (as described here
) when you run into
problems like this? Backtraces often lead us straight to the bug.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pnation' assertion failed, and segfault

[Jacob Nevins]

Update of bug #17439 (project freeciv):

 Summary: S2_3: '((void *)0) != pgenlist', '((void *)0) !=
pnation' assertions failed, and segfault => S2_3: '((void *)0) != pnation'
assertion failed, and segfault


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pgenlist', '((void *)0) != pnation' assertions failed, and segfault

[Jordi Negrevernis i Font]

Follow-up Comment #4, bug #17439 (project freeciv):

This is with S2_3 branch.

Today I've got another occurrence of that bug.

On the server I have:
Player 'Kurush II' now has difficulty 'Hard'.
Game saved in freeciv-T0238-Y01690-auto.sav.gz
> 
2: connection cut: jorneg in localhost (lagging connection) (player Jordi el
Pilós).
> 

And then the client crashed:
1: in nation_index() [nation.c::483]: assertion '((void *)0) != pnation'
failed.
1: Please, report this message to http://gna.org/projects/freeciv/
Segmentation Fault


Only crashes the client...

I attach the savegame if the previous turn.


(file #12599)
___

Additional Item Attachment:

File name: freeciv-T0237-Y01685-auto.sav.gz Size:191 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pgenlist', '((void *)0) != pnation' assertions failed, and segfault

[Jordi Negrevernis i Font]

Follow-up Comment #3, bug #17439 (project freeciv):

Yes, the problem with 'genlist_remove() [genlist.c::358]: assertion '((void
*)0)' seems gone but the other i don't know.

I'll keep on trying...


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pgenlist', '((void *)0) != pnation' assertions failed, and segfault

[Matthias Pfafferodt]

Update of bug #17439 (project freeciv):

  Status:None => Need Info  

___

Follow-up Comment #2:

> On the server console there a lot of ... 
> 1: in genlist_remove() [genlist.c::358]: assertion '((void *)0)
> != pgenlist' failed. 

This seems to be bug #17465

> 1: in nation_index() [nation.c::483]: assertion '((void *)0) !=
> pnation' failed. 
> 1: Por favor, informa de este mensaje a
> http://gna.org/projects/freeciv/ 
> Fallo de segmentación 

but the nation code is unrelated - thus, the crash is due to a different bug.
Without a backtrace it will be hard to find the reason ...

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pgenlist', '((void *)0) != pnation' assertions failed, and segfault

[Jacob Nevins]

Update of bug #17439 (project freeciv):

 Planned Release: => 2.3.0  

___

Follow-up Comment #1:

The '((void *)0) != pgenlist' sounds like bug #17465, which was fixed by
patch #2344. Don't know whether '((void *)0) != pnation' and the segfault
could be a knock-on effect?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3: '((void *)0) != pgenlist', '((void *)0) != pnation' assertions failed, and segfault

[Jacob Nevins]

Update of bug #17439 (project freeciv):

 Summary:   S2_3  => S2_3: '((void *)0) !=
pgenlist', '((void *)0) != pnation' assertions failed, and segfault


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #17439] S2_3

[Jordi Negrevernis i Font]

URL:
  

 Summary: S2_3 
 Project: Freeciv
Submitted by: jorneg
Submitted on: dom 09 ene 2011 00:45:40 GMT
Category: client-gtk-2.0
Severity: 5 - Blocker
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

jor...@ubuntu:~/freeciv/S2_3/freeciv-2.3$ ./civ -a
Unable to find client executable: freeciv
Searching for freeciv clients ...
... using ./client/freeciv-gtk2
Running ./client/freeciv-gtk2
2: No está presente un controlador real de audio.
2: Se prosigue con el sonido desactivado.
2: Para el soporte de sonido, instala SDL_mixer
2: http://www.libsdl.org/projects/SDL_mixer/index.html
1: in nation_index() [nation.c::483]: assertion '((void *)0) != pnation'
failed.
1: Por favor, informa de este mensaje a http://gna.org/projects/freeciv/
Fallo de segmentación
jor...@ubuntu:~/freeciv/S2_3/freeciv-2.3$ 

-> Segmentation Fault...

On the server console there a lot of ...
1: in genlist_remove() [genlist.c::358]: assertion '((void *)0) != pgenlist'
failed.


Until that a new AI player is created...

> 
El jugador 'Karađorđe Petrović' ahora juega según la dificultad
'Difícil'.
Partida salvada en el fichero freeciv-T0087-Y-0325-auto.sav.gz
> 
2: Se ha cortado la conexión: jorneg de localhost (conexión con retraso)
(jugador Jordi el Gran).

I don't attach the savegame because i can't reproduce...





___

Reply to this item at:

  

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev