[Freeciv-Dev] [bug #17508] Loading savegames for Britain/Europe scenarios gives many errors and server segfault

2011-01-19 Thread Matthias Pfafferodt

Update of bug #17508 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?17508

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17508] Loading savegames for Britain/Europe scenarios gives many errors and server segfault

2011-01-17 Thread Matthias Pfafferodt

Update of bug #17508 (project freeciv):

 Assigned to:None = syntron
 Planned Release:   2.3.0 = 2.3.0, 2.4.0   

___

Follow-up Comment #1:

Here is a small patch which prevents this crash by reseting the server if
there is a error loading the savegame. I will do further checks if the
requirement of even map sizes is needed for scenarios.

___

Reply to this item at:

  http://gna.org/bugs/?17508

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17508] Loading savegames for Britain/Europe scenarios gives many errors and server segfault

2011-01-17 Thread Matthias Pfafferodt

Additional Item Attachment, bug #17508 (project freeciv):

File name: 20110117-reset-game-after-failure-while-game-loading.patch Size:0
KB


___

Reply to this item at:

  http://gna.org/bugs/?17508

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17508] Loading savegames for Britain/Europe scenarios gives many errors and server segfault

2011-01-17 Thread Matthias Pfafferodt

Update of bug #17508 (project freeciv):

  Status:None = Ready For Test 

___

Follow-up Comment #2:

allow odd width and height

* the check were added due to a comment in mapgen_topology.c that the
generator needs even values
* test showed that the current generator works also with odd values

(file #11934)
___

Additional Item Attachment:

File name: 20110117-allow-odd-width-and-height.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?17508

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #17508] Loading savegames for Britain/Europe scenarios gives many errors and server segfault

2011-01-16 Thread Jacob Nevins

URL:
  http://gna.org/bugs/?17508

 Summary: Loading savegames for Britain/Europe scenarios
gives many errors and server segfault
 Project: Freeciv
Submitted by: jtn
Submitted on: Sun Jan 16 22:43:19 2011
Category: None
Severity: 4 - Important
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:

Split out from bug #17459, where roywephy originally reported it:

Trunk and S2_3 (r18960), and reportedly trunk r18867, give lots of errors and
crash when loading savegames created from the bundled
british-isles-85x80-v2.80 (73x81) and europe-200x100-v2 (177x100) scenarios.

roywephy suggests https://gna.org/bugs/?17459#comment2 that this is
correlated with an odd width (and/or possibly height). I notice that I not
allowed to manually set odd width or height via xsize/ysize server settings
(The map width must be an even value), but I don't know why that is.

If the map width/height is required to be even for some reason, do we need to
tweak the bundled scenarios, and possibly add assertions/errors on scenario
and savefile load to catch odd widths/heights? Are there any valid
savegames/scenarios that we'd refuse to load as a result? (I note that the
relevant scenarios have the same proportions on S2_2, so the answer is
probably yes.)

Here are the errors and backtrace I get for S2_3 r18958 on the attached
europe.sav.bz2.


Encodings: Data=UTF-8, Local=UTF-8, Internal=UTF-8
This is the server for Freeciv version 2.3.0-beta1+ (beta version)
You can learn a lot about Freeciv at http://www.freeciv.org/

THIS IS A BETA VERSION
Freeciv 2.3.0 will be released in March, at http://www.freeciv.org/

2: Loading rulesets.
2: AI*1 has been added as Easy level AI-controlled player.
2: AI*2 has been added as Easy level AI-controlled player.
2: AI*3 has been added as Easy level AI-controlled player.
2: AI*4 has been added as Easy level AI-controlled player.
2: AI*5 has been added as Easy level AI-controlled player.
1: Error restoring 'xsize': The map width must be an even value.
1: Error restoring 'generator': You cannot disable the map generator.
1: Error restoring 'onsetbarbs': Value out of range: -2000 (min: 0; max:
32767).
2: Removing player AI*1.
2: Removing player AI*2.
2: Removing player AI*3.
2: Removing player AI*4.
2: Removing player AI*5.
1: Saved game contains incomplete map data. This can happen with old saved
games, or it may indicate an invalid saved game file. Proceed at your own
risk.
1: Start position native coordinates (66, 29) do not exist in this map.
Skipping
...
1: Start position native coordinates (78, 55) do not exist in this map.
Skipping...
1: Start position native coordinates (88, 33) do not exist in this map.
Skipping...
1: Start position native coordinates (72, 54) do not exist in this map.
Skipping...
1: Start position native coordinates (120, 24) do not exist in this map.
Skipping...
1: Start position native coordinates (76, 50) do not exist in this map.
Skipping...
1: Start position native coordinates (88, 67) do not exist in this map.
Skipping...
1: Start position native coordinates (113, 44) do not exist in this map.
Skipping...
1: Start position native coordinates (81, 70) do not exist in this map.
Skipping...
1: Start position native coordinates (73, 40) do not exist in this map.
Skipping...
1: Start position native coordinates (109, 59) do not exist in this map.
Skipping...
1: Start position native coordinates (97, 65) do not exist in this map.
Skipping...
1: Start position native coordinates (134, 95) do not exist in this map.
Skipping...
1: Start position native coordinates (97, 20) do not exist in this map.
Skipping...
1: Start position native coordinates (77, 62) do not exist in this map.
Skipping...
1: Start position native coordinates (101, 87) do not exist in this map.
Skipping...
1: Start position native coordinates (155, 84) do not exist in this map.
Skipping...
1: Start position native coordinates (121, 80) do not exist in this map.
Skipping...
1: Start position native coordinates (89, 42) do not exist in this map.
Skipping...
1: Start position native coordinates (94, 26) do not exist in this map.
Skipping...
1: Start position native coordinates (85, 53) do not exist in this map.
Skipping...
1: Start position native coordinates (86, 58) do not exist in this map.
Skipping...
1: Start position native coordinates (80, 67) do not exist in this map.
Skipping...
1: Start position native coordinates (71, 76) do not exist in this map.
Skipping...
1: Start position native coordinates (92, 13) do not exist in this map.
Skipping...
1: Start position native coordinates (78, 20) do not exist in this map.
Skipping...