[Freeciv-Dev] [bug #20000] Initial state of chatline toolbar is wrong
Update of bug #2 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?2 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20000] Initial state of chatline toolbar is wrong
Follow-up Comment #2, bug #2 (project freeciv): - Updated against current svn / only relevant part (file #16840) ___ Additional Item Attachment: File name: ChatToolsInitState.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?2 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20000] Initial state of chatline toolbar is wrong
Update of bug #2 (project freeciv): Status:None = Ready For Test ___ Reply to this item at: http://gna.org/bugs/?2 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20000] Initial state of chatline toolbar is wrong
URL: http://gna.org/bugs/?2 Summary: Initial state of chatline toolbar is wrong Project: Freeciv Submitted by: jtn Submitted on: Sun Jul 29 11:55:24 2012 Category: client-gtk-3.0 Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: S2_4 r21637 Discussion Lock: Any Operating System: GNU/Linux Planned Release: 2.4.0,2.5.0 ___ Details: The Chat tools button starts in the deactivated state (popped out), but the toolbar (bold, strikethrough, etc) is nevertheless shown. (In the Gtk2 client it's initially hidden.) The first time the tools button is pressed, nothing happens other than that the button goes in. After that it behaves as designed. I haven't spotted an obvious mistake in chatline.c. I'm not sure what sets the initial hidden state in gtk2 -- probably the set_toolbar_visibility() callback connected to expose-event. In gtk3 this is connected to map; perhaps that makes things happen in the wrong order? ___ Reply to this item at: http://gna.org/bugs/?2 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20000] Initial state of chatline toolbar is wrong
Follow-up Comment #1, bug #2 (project freeciv): I suspect the only mistake could be relying on some side effect of running in expose-event. Attaching something that seems to fix the problem. The second block is just a minor gtk3 cleanup. (file #16233) ___ Additional Item Attachment: File name: fix-chat-toolbar-visibility.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?2 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
