[Freeciv-Dev] [bug #20478] Featured text crash when reconnecting server
Update of bug #20478 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20478 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20478] Featured text crash when reconnecting server
URL: http://gna.org/bugs/?20478 Summary: Featured text crash when reconnecting server Project: Freeciv Submitted by: cazfi Submitted on: Mon 04 Feb 2013 03:13:17 PM EET Category: client Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: My client crashes when I try to connect server. It seems that featured text tags list passed real_output_window_append() contains NULL tag. Crash happens when parsing chatmessage I've written myself - this could be related that I'm still the same player, but my connection id has changed (handle_even() wants to highlight my player name if some other connection has mentioned it) ___ Reply to this item at: http://gna.org/bugs/?20478 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20478] Featured text crash when reconnecting server
Follow-up Comment #1, bug #20478 (project freeciv): NULL tag is created for highlight_user_name tags creation. Presumably becase my .freeciv-client-rc-2.5 has: highlight_our_names.foreground= highlight_our_names.background= There is check for ft_color_requested(highlight_our_name) guarding that block of code, but for some reason it's not preventing execution of the code path. I try to debug this as much as possible as long as I have the reproduction case available (server running and in such a state that it can be tested against) ___ Reply to this item at: http://gna.org/bugs/?20478 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20478] Featured text crash when reconnecting server
Follow-up Comment #2, bug #20478 (project freeciv): It being my own message is relevant in that as message is prefixed by sender name, there's always my name to attempt highlighting of. ___ Reply to this item at: http://gna.org/bugs/?20478 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20478] Featured text crash when reconnecting server
Update of bug #20478 (project freeciv): Status:None = Ready For Test Planned Release: = 2.3.4, 2.4.0, 2.5.0 ___ Follow-up Comment #3: The main problem was that ft_color_requested() didn't really check against empty strings at all, but against NULL pointer twice. In addition to fixing fc_color_requested() attached patch makes creation of highlight tags more robust by makeing them to check against NULL return value. It's still fc_asserted against, but unless asserts are set fatal, it won't crash any more when NULL pointer is received. (file #17122) ___ Additional Item Attachment: File name: EmptyColorFix.patchSize:2 KB ___ Reply to this item at: http://gna.org/bugs/?20478 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
