[Freeciv-Dev] [bug #20490] Player owner reconnecting to player while delegate user attached => server assertion failures, crash

[Jacob Nevins]

Follow-up Comment #6, bug #20490 (project freeciv):

Oh, I see. This crash only occurred if 'pamcakes' was completely detached at
'/delegate take' time, I guess -- if they were an observer (or player), all
would be fine.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20490] Player owner reconnecting to player while delegate user attached => server assertion failures, crash

[pepeto]

Update of bug #20490 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20490] Player owner reconnecting to player while delegate user attached => server assertion failures, crash

[pepeto]

Update of bug #20490 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20490] Player owner reconnecting to player while delegate user attached => server assertion failures, crash

[pepeto]

Update of bug #20490 (project freeciv):

Category:None => general
  Status:   Confirmed => Ready For Test 

___

Follow-up Comment #3:

I think the backtrace attached was after herp reconnect. Attached patch that
fix both way to reproduce these "bad things".


(file #17238)
___

Additional Item Attachment:

File name: connection_delegate_restore.diff Size:0 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20490] Player owner reconnecting to player while delegate user attached => server assertion failures, crash

[Jacob Nevins]

Follow-up Comment #2, bug #20490 (project freeciv):

Oops, I missed the vital step in my description! Should have been
* ...
* pamcakes: /delegate take Ur-Nammu [herp's player]
* *herp rejoins*
* bad things happen to server
This is the scenario the backtraces come from.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20490] Player owner reconnecting to player while delegate user attached => server assertion failures, crash

[pepeto]

Update of bug #20490 (project freeciv):

  Status:None => Confirmed  

___

Follow-up Comment #1:

I can confirm, but it needs a step more :
* pamcakes: /delegate restore


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20490] Player owner reconnecting to player while delegate user attached => server assertion failures, crash

[Marko Lindqvist]

Update of bug #20490 (project freeciv):

Severity:  3 - Normal => 5 - Blocker


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20490] Player owner reconnecting to player while delegate user attached => server assertion failures, crash

[Jacob Nevins]

URL:
  

 Summary: Player owner reconnecting to player while delegate
user attached => server assertion failures, crash
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Feb  9 21:39:12 2013
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_4 r22316
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 2.4.0,2.5.0

___

Details:

* Two users initially: herp, derp, each with a player
* Game started
* herp: /delegate to pamcakes
* herp leaves
* pamcakes joins (not attached to player intitially)
* pamcakes: /delegate take Ur-Nammu [herp's player]
* bad things happen to server

"Bad things" include many many assertion failures and eventually a crash.

With -F, the first server assertion failure:


0: in dbv_isset() [bitvector.c::120]: assertion 'pdbv->vec != ((void *)0)'
failed.

#0  0x7f76e90c07bb in raise (sig=)
at ../nptl/sysdeps/unix/sysv/linux/pt-raise.c:42
No locals.
#1  0x005e5f8c in fc_assert_fail (file=0x68436d "bitvector.c", 
function=0x6844be "dbv_isset", line=120, assertion=,

message=0x680e85 "nologmsg:%s") at log.c:520
level = LOG_FATAL
#2  0x005fc8d5 in dbv_isset (pdbv=, 
bit=) at bitvector.c:120
__FUNCTION__ = "dbv_isset"
#3  0x0048c931 in map_is_known_and_seen (ptile=0x5126, pplayer=0x5126,

vlayer=6) at maphand.c:749
No locals.
#4  0x0048cb97 in send_tile_info (dest=, 
ptile=0x354f2d0, send_unknown=false) at maphand.c:422
pplayer = 0x1f9ede0
pconn_iter = 
pconn = 0x8c1970
info = {tile = 0, continent = 0, known = 6107115, owner = 0, 
  worked = 0, terrain = 0, resource = 33156576, special = {false, 
false, false, false, 80, 236, false, true, false, false, false}, 
  bases = {vec = "\000\375MI"}, 
  spec_sprite = '\000' ,
"\n\025]\000\000\000\000\000P\354\370\001\000\000\000\000\bOI", '\000'
, 
  label = '\000' "\205,
&o\213|\213\206\220\205u\001", '\000' ,
"p\031\214\000\000\000\000\000\320\363\025"}
owner = 
__FUNCTION__ = "send_tile_info"
#5  0x0048d193 in send_all_known_tiles (dest=0x1750580)
at maphand.c:364
tiles_sent = 
#6  0x0043b673 in send_all_info (dest=0x1750580) at srv_main.c:555
__FUNCTION__ = "send_all_info"
#7  0x004816a9 in connection_attach_real (pconn=0x8c1970, 
pplayer=0x1f9ede0, observing=false, connecting=false) at
connecthand.c:622
__FUNCTION__ = "connection_attach_real"
#8  0x0048198a in connection_delegate_restore (pconn=0x8c1970)
at connecthand.c:822
pplayer = 
__FUNCTION__ = "connection_delegate_restore"
#9  0x00481e77 in establish_new_connection (pconn=0x8c20a0)
at connecthand.c:189
pdelegate = 
dest = 0x17505d0
pplayer = 
packet = {you_can_join = true, 
  message = "herp
Welcome\000\000\000\000\000\000\000\004\000\000\000L\315]\351v\177\000\000\340/h\000\000\000\000\000x\365\025\066\377\177\000\000\200\365\025\066\377\177\000\000\210\365\025\066\377\177\000\000p\365\025\066\377\177\000\000\320\365\025\066\377\177\000\000\345\334a\000\000\000\000\000\000\020\000\000\000\000\000\000G\030\251\000\000\000\000\000\063\347\326\347v\177\000\000\331\017\000\000\000\000\000\000\200\247\a\350v\177\000\000&\000\000\000\000\000\000\000\000@]\351v\177\000\000\000\000\000\000\000\000\000\000\205\375\326\347v\177\000\000
\030\251\000\000\000\000\000
\030\251\000\000\000\000\000&\000\000\000\000\000\000\000\200\247\a\350v\177\000\000\000\000\000\000\000\000\000\000\236\343\326\347v\177\000\000\060\060\060\060\060\060\060\060\200\247\a\350v\177\000\000
\030\251\000\000\000\000\000&", '\000' , "@\022"..., 
  capability = "+Freeciv-2.4-network rules_finished
trademindist_size\000\000(\211\322\347v\177\000\000en_GB.UT\000\205&o\213|\213\206\004\000\000\000\000\000\000\000o\374\025\066\377\177\000\000\002\000\000\000\000\000\000\000\240\374\025\066\377\177\000\000\300\031\214\000\000\000\000\000\350\355\371\001\000\000\000\000\340\355\371\001\000\000\000\000u\362C\000\000\000\000\000\060\000\000\000\060\000\000\000\200\374\025\066\377\177\000\000\300\373\025\066\377\177\000\000\000\205&o\000\000\000\000@\370t\001\000\000\000\000ěE\000\005\000\000\000\070\374\025\066\377\177\000\000
\373\025\066\377\177\000\000\300\031\214\000\000\000\000\000\350\355\371\001\000\000\000\000@\370t\001\000\000\000\000@\276\a\350v\177\000\000\001\000\000\000\000\000\000\000"...,

  challenge_file =
"challenge_5556_4\000\000\000\000\000\000\000\310JC\000\000\000\000\000
\000\000\000\060\000\000\000\020\376\025\066\3