[Freeciv-Dev] [bug #20519] Unloading problem in release builds

2013-02-20 Thread Marko Lindqvist 
Update of bug #20519 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20519

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20519] Unloading problem in release builds

2013-02-17 Thread Marko Lindqvist 
URL:
  http://gna.org/bugs/?20519

 Summary: Unloading problem in release builds
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 17 Feb 2013 12:02:26 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0, 2.5.0

___

Details:

Functionality to remove cargo from the list of transporter's transported units
is inside fc_assert() so it won't happen at all when asserts are disabled.

Fix attached

I'm worried. The fact that there's some such cases of functionality inside
fc_assert() indicates that someone has not been aware of its dangers and could
have made same mistake in many places.
I'll see if CodingStyle needs updating in this respect.



___

File Attachments:


---
Date: Sun 17 Feb 2013 12:02:26 PM EET  Name: ReleaseTransportedList.patch 
Size: 904B   By: cazfi

http://gna.org/bugs/download.php?file_id=17234

___

Reply to this item at:

  http://gna.org/bugs/?20519

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20519] Unloading problem in release builds

2013-02-17 Thread Jacob Nevins 
Follow-up Comment #1, bug #20519 (project freeciv):

(Bug #20084 was a previous, very similar instance of this problem.)

___

Reply to this item at:

  http://gna.org/bugs/?20519

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20519] Unloading problem in release builds

2013-02-17 Thread pepeto 
Follow-up Comment #2, bug #20519 (project freeciv):

It looks like fc_assert_ret() isn't disabled in NDEBUG builts.


___

Reply to this item at:

  http://gna.org/bugs/?20519

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20519] Unloading problem in release builds

2013-02-17 Thread pepeto 
Follow-up Comment #4, bug #20519 (project freeciv):

I agree with you.


___

Reply to this item at:

  http://gna.org/bugs/?20519

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev