[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame
Update of bug #20538 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?20538 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame
Update of bug #20538 (project freeciv): Status:None = Ready For Test Planned Release:2.5.0, 2.6.0 = 2.4.3, 2.5.0-beta1, 2.6.0 ___ Follow-up Comment #7: Original report was about savegame.c problem (as version was 20105). My speculation about problems in savegame2.c when nationality has been enabled in a ruleset post-2.4 should go to new ticket if there really is such an bug (to be confirmed) Attached is a fix for the bug of this ticket. (file #21453, file #21454) ___ Additional Item Attachment: File name: SavegameCNationalityFixIt.patch Size:1 KB File name: SavegameCNationalityFixIt-S2_4.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?20538 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame
Follow-up Comment #8, bug #20538 (project freeciv): The other bug, now confirmed, in bug #22360 ___ Reply to this item at: http://gna.org/bugs/?20538 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame
Follow-up Comment #6, bug #20538 (project freeciv): Still happens with trunk/S2_5 r25592. This is a little different than bug #22350, since it's a pre-savegame2 savegame. Guessing that lack of nationality isn't handled as cleanly in savegame.c as savegame2.c? ___ Reply to this item at: http://gna.org/bugs/?20538 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame
Update of bug #20538 (project freeciv): Category:None = general Severity: 3 - Normal = 5 - Blocker Planned Release: = 2.5.0, 2.6.0 ___ Reply to this item at: http://gna.org/bugs/?20538 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame
Follow-up Comment #5, bug #20538 (project freeciv): See also bug #22350. ___ Reply to this item at: http://gna.org/bugs/?20538 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame
Follow-up Comment #4, bug #20538 (project freeciv): 2.4 / experimental ruleset is *not* affected as nationality as new feature in 2.4 is handled by 2.3 to 2.4 savegame format compatibility function. So, the problem is only rulesets that have no nationality in 2.4, but enable it in later versions, such as classic ruleset in 2.5 ___ Reply to this item at: http://gna.org/bugs/?20538 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame
Follow-up Comment #3, bug #20538 (project freeciv): If it really is about ruleset having nationality enabled savegame loading time, but not when it was saved, classic ruleset will be affected only beginning in 2.5, but it might affect other rulesets in 2.4 already (if they enable nationality) - such as experimental ruleset. ___ Reply to this item at: http://gna.org/bugs/?20538 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame
URL: http://gna.org/bugs/?20538 Summary: Numerous assertion failures when loading an old savegame Project: Freeciv Submitted by: pepeto Submitted on: mer. 20 févr. 2013 11:58:33 CET Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: trunk r22403 Discussion Lock: Any Operating System: Any Planned Release: ___ Details: I tried to load file #7060 for testing bug #16643. I got on server side: in citizens_nation_get() [citizens.c::83]: assertion 'pcity-nationality != ((void *)0)' failed. in citizens_nation_get() [citizens.c::83]: assertion 'pcity-nationality != ((void *)0)' failed. in citizens_nation_get() [citizens.c::83]: assertion 'pcity-nationality != ((void *)0)' failed. [...] in package_city() [citytools.c::2019]: assertion 'cit == packet-size' failed. On client side: 1: in handle_city_info() [packhand.c::670]: assertion 'citizens_count(pcity) == city_size_get(pcity)' failed. 1: in handle_city_info() [packhand.c::670]: assertion 'citizens_count(pcity) == city_size_get(pcity)' failed. 1: in handle_city_info() [packhand.c::670]: assertion 'citizens_count(pcity) == city_size_get(pcity)' failed. [...] ___ Reply to this item at: http://gna.org/bugs/?20538 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame
Follow-up Comment #1, bug #20538 (project freeciv): Is that classic ruleset? Nationality got enabled in that ruleset recently, so presumably savegame was created when ruleset has no nationality, but at loading time it has. ___ Reply to this item at: http://gna.org/bugs/?20538 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20538] Numerous assertion failures when loading an old savegame
Follow-up Comment #2, bug #20538 (project freeciv): Is that classic ruleset? Nationality got enabled in that ruleset recently, so presumably savegame was created when ruleset has no nationality, but at loading time it has. Yes, savegame says version=20105, rulesetdir=default. ___ Reply to this item at: http://gna.org/bugs/?20538 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
