[Freeciv-Dev] [bug #20641] punit-activity_count incremented needlessly for sentried units

2013-03-25 Thread Jacob Nevins
Update of bug #20641 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?20641

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20641] punit-activity_count incremented needlessly for sentried units

2013-03-23 Thread Jacob Nevins
URL:
  http://gna.org/bugs/?20641

 Summary: punit-activity_count incremented needlessly for
sentried units
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat Mar 23 22:20:34 2013
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.3.4,2.4.0-beta1
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.3.5,2.4.0,2.5.0

___

Details:

Split out from bug #20495:

Since r5333 http://svn.gna.org/viewcvs/freeciv?view=revisionrevision=5333,
activity_count has been incremented for units doing ACTIVITY_SENTRY, even
though it's not used and shouldn't be. This leads to really huge
activity_counts.

On trunk, patch #3688 combined with the limited range of the activity_count
field on the network makes this really obvious. However, it's not actually
causing a bug, as the client only uses activity_count for certain activities,
not including ACTIVITY_SENTRY.




___

Reply to this item at:

  http://gna.org/bugs/?20641

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #20641] punit-activity_count incremented needlessly for sentried units

2013-03-23 Thread Jacob Nevins
Update of bug #20641 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #1:

In addition to pepeto's patch (file #17263), this one zeroes activity_count in
savefiles for ACTIVITY_SENTRY.

(file #17526, file #17527)
___

Additional Item Attachment:

File name: trunk-update-unit-activity-sentry-bis.patch Size:2 KB
File name: S2_4-S2_3-update-unit-activity-sentry-bis.patch Size:2 KB


___

Reply to this item at:

  http://gna.org/bugs/?20641

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev