[Freeciv-Dev] [bug #21625] Mapgenerator crash if no category Irrigation or Mine extra
Update of bug #21625 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?21625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21625] Mapgenerator crash if no category Irrigation or Mine extra
Update of bug #21625 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #1: Patch attached: - Startpos evaluation considers Irrigation and Mine activity only if it will add an extra. 1) Terrain transformations are considered too much work in the beginning of the game for getting startpos improved. 2) Ruleset must have such an extra - tile_irrigate() and tile_mine() check against NULL target extra, especially as I think they can still legally end up there. (file #20114) ___ Additional Item Attachment: File name: StartposExtras.patch Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?21625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21625] Mapgenerator crash if no category Irrigation or Mine extra
URL: http://gna.org/bugs/?21625 Summary: Mapgenerator crash if no category Irrigation or Mine extra Project: Freeciv Submitted by: cazfi Submitted on: Sun 09 Feb 2014 08:13:08 AM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: In Progress Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: Noticed while fixing another bug: Startpos selection code in mapgenerator tries to place Irrigation and Mine to virtual tile to see how such an improvement would help player. It doesn't check that there actually is suitable extra in the ruleset, but happily passes NULL extra to tile_apply_activity() - tile_mine() / tile_irrigate(). ___ Reply to this item at: http://gna.org/bugs/?21625 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
