[Freeciv-Dev] [bug #22468] key_unit_diplomat_actions() may drop legal actions

2014-08-14 Thread Sveinung Kvilhaugsvik
Update of bug #22468 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22468

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22468] key_unit_diplomat_actions() may drop legal actions

2014-08-13 Thread Sveinung Kvilhaugsvik
URL:
  http://gna.org/bugs/?22468

 Summary: key_unit_diplomat_actions() may drop legal actions
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 13 Aug 2014 12:05:46 PM UTC
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Release: TRUNK
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

A rule may enable/disable an action based on data the player, and therefore
the client, can't see.

Since key_unit_diplomat_actions() anyway will ask the server about what
actions are enabled the test can safely be removed. Attached patch removes it.



___

File Attachments:


---
Date: Wed 13 Aug 2014 12:05:46 PM UTC  Name:
0001-Don-t-ask-if-any-action-is-possible-with-client-data.patch  Size: 1kB  
By: sveinung

http://gna.org/bugs/download.php?file_id=21707

___

Reply to this item at:

  http://gna.org/bugs/?22468

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev