[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Update of bug #23093 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Update of bug #23093 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #13: The original posted patch for S2_4 should stabilize this branch. ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Update of bug #23093 (project freeciv): Status: Ready For Test = In Progress Assigned to: cazfi = pepeto ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Follow-up Comment #10, bug #23093 (project freeciv): As for S2_5: Probably all we need to do to backport this to S2_5 is that we wait for patch #5632 to get committed first. After that the TRUNK version should apply cleanly. ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Follow-up Comment #9, bug #23093 (project freeciv): I have made the version of the patch only for trunk currently. Then I'll commit it to trunk only tomorrow, and leave the ticket open for handling the stable branches ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Follow-up Comment #8, bug #23093 (project freeciv): I have made the version of the patch only for trunk currently. I won't be able to backport it to older branches (but the bug may be present there too). ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Follow-up Comment #5, bug #23093 (project freeciv): startpos_hash_replace() is called into a startpos_hash_iterate loop. But startpos_hash_replace() is actually genhash_replace() and it calls genhash_maybe_expand() which can cause the hash table to be resized (but the iterator keeps invalid data). So, instead of using startpos_hash_replace() to update the counter, I have made the hash table using integer pointers as data (instead of plain integers). ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Follow-up Comment #6, bug #23093 (project freeciv): Attached another approch: resize the genhash only when the entry number will be changed. It may replace previous one, but both can be applied too. (file #23302) ___ Additional Item Attachment: File name: trunk_genhash_resize.patch Size:3 KB ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Follow-up Comment #4, bug #23093 (project freeciv): Could you explain a bit what is the root cause of the crash, and how this patch fixes it. ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Update of bug #23093 (project freeciv): Category: freeciv-web = general Status:None = Ready For Test Planned Release: = 2.4.5, 2.5.0, 2.6.0 ___ Follow-up Comment #3: This patch should solve the issue. Unfortunately, I won't be back to commit for a while. Anyone can take care of this item. (file #23261, file #23262, file #23263) ___ Additional Item Attachment: File name: trunk_generate_players.patch Size:3 KB File name: S2_5_generate_players.patchSize:3 KB File name: S2_4_generate_players.patchSize:3 KB ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Update of bug #23093 (project freeciv): Severity: 3 - Normal = 4 - Important ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Follow-up Comment #2, bug #23093 (project freeciv): I get the same crash using normal Freeciv with the regular GTK2 client. ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
URL: http://gna.org/bugs/?23093 Summary: Segmentation fault in generate_players loading earth-160x90-v2.sav Project: Freeciv Submitted by: andreasr Submitted on: Wed 17 Dec 2014 08:44:19 PM UTC Category: freeciv-web Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: I get the following segmentation fault loading the recently updated earth-160x90-v2.sav in svn trunk. The crash did not occur in SVN revision 27281, but it occurs in svn revision 27334. The is on Freeciv-web running on Vagrant, but I think it is a fault in the Freeciv server. #0 0x0056e654 in genhash_iter_key ( genhash_iter=genhash_iter@entry=0x7fff9c74b308) at genhash.c:802 iter = 0x7fff9c74b308 #1 0x0040c850 in generate_players () at srv_main.c:2292 psp = optimized out c = optimized out MY_mem_MY_iter = 0x7fff9c74b308 @\347V MY_it_MY_iter = 0x7fff9c74b308 pplayer = optimized out _pslot = 0x24f3ee0 picked = 0x2fc37c0 c = optimized out i = 39 max = 0 min = 0 nations_to_assign = 31 #2 srv_ready () at srv_main.c:2696 __FUNCTION__ = srv_ready #3 0x0040cddd in srv_main () at srv_main.c:3004 __FUNCTION__ = srv_main #4 0x00405689 in main (argc=20, argv=0x7fff9c74b868) at civserver.c:459 inx = 20 showhelp = optimized out showvers = optimized out option = optimized out __FUNCTION__ = main ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23093] Segmentation fault in generate_players loading earth-160x90-v2.sav
Follow-up Comment #1, bug #23093 (project freeciv): I suspect startpos_hash_replace() to be used in a startpos_hash_iterate loop. ___ Reply to this item at: http://gna.org/bugs/?23093 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
