[Freeciv-Dev] [bug #23430] Fixing Freeciv-web master branch
Update of bug #23430 (project freeciv): Status:None = Ready For Test Assigned to:None = sveinung Open/Closed:Open = Closed ___ Follow-up Comment #3: Fixed in commit c53a9e6f7c081f5b7fe3b5aa5dee2a842a111a38 in Freeciv-web's git. (Andreas: I pushed it from test to master after your testing) ___ Reply to this item at: http://gna.org/bugs/?23430 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23430] Fixing Freeciv-web master branch
Follow-up Comment #2, bug #23430 (project freeciv): Thanks for all the details, Sveinung. I think the first step for fixing this should be to implement Json arrays in patch #5955. Then we can go on fixing Freeciv-web after that. ___ Reply to this item at: http://gna.org/bugs/?23430 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23430] Fixing Freeciv-web master branch
Update of bug #23430 (project freeciv): Depends on: = patch #5955 ___ Reply to this item at: http://gna.org/bugs/?23430 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23430] Fixing Freeciv-web master branch
URL: http://gna.org/bugs/?23430 Summary: Fixing Freeciv-web master branch Project: Freeciv Submitted by: andreasr Submitted on: Sun 29 Mar 2015 08:39:56 PM UTC Category: freeciv-web Severity: 4 - Important Priority: 7 - High Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Any Planned Release: ___ Details: I would really appreciate some help from Marko and Sveinung with fixing the Freeciv-web master branch: https://github.com/freeciv/freeciv-web/commits/master In Freeciv patch #5955, there seems to be consensus that Json protocol arrays should be Json arrays as defined in the Json spec on json.org. So I guess that patch #5937 should be reverted in Freeciv-web. I think I need some help from you to review the commits from you after March 19, and update or revert changes so Json arrays are treated like Json arrays. Thanks! ___ Reply to this item at: http://gna.org/bugs/?23430 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23430] Fixing Freeciv-web master branch
Follow-up Comment #1, bug #23430 (project freeciv): I'll have a closer look tomorrow. I'll also try to set up an environment where I can test Freeciv-web again. _I think I need some help from you to review the commits from you after March 19_ Pure ports from Json to the new system: * 92bf3f79907e55969c8745f4564a10fc7d7e3c2f * 5e829e5e03ba60f2c1ba0d15024dd111671a58dc Uses the new system but has other code as well: * 518a7ac64d38b55e32cfd4c4ac3adeac9449f47d * bcb122466136a4903d1f908649dfe64f9487ec6c The pure ports can be reverted. The users of the new system is only use it to send. Before patch #5937 Freeciv-web was unable to send an array from client to server. 518a7ac64d38b55e32cfd4c4ac3adeac9449f47d can go back to the work around I used (in a local branch) before patch #5937: sending the single element without wrapping it in an array. bcb122466136a4903d1f908649dfe64f9487ec6c, and the work based on it, is something I don't have a solution for. Would it be easy to only revert it in the server to client direction? I don't know if implementing patch #5955 would be less work than reverting patch #5937 and working around the issues that would pop up. ___ Reply to this item at: http://gna.org/bugs/?23430 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
