[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Marko Lindqvist]

Update of bug #23708 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Marko Lindqvist]

Follow-up Comment #9, bug #23708 (project freeciv):

Next turn the citydlg shows the correct tradepartner names, and find city
dialog lists and finds them.
Probably irrelevant, but those partner cities seem to be founded to places
that I already 'know' (probably via trading maps), but that are fogged.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Marko Lindqvist]

Follow-up Comment #8, bug #23708 (project freeciv):

In a running game (TRUNK r29041 + a lot of fixes backported) number of
traderoutes were just established to my cities. gtk3-client citydlg shows them
currently as: "+13: Trade route with (unknown)". The event messages about the
trade routes told the name of the partner city, and those cities are not in
the list of "Find City" dialog (-> presumably I don't about them yet)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Marko Lindqvist]

Follow-up Comment #7, bug #23708 (project freeciv):

> Untested patch for S2_5 attached

Surprisingly that same patch applies to all branches despite them trade system
changes between them.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Marko Lindqvist]

Update of bug #23708 (project freeciv):

  Status:None => Ready For Test 
 Planned Release:   3.0.0 => 2.5.4, 2.6.0, 3.0.0

___

Follow-up Comment #6:

First commented to bug #24072, but this ticket is even more involved:
"It could be that the other end of the traderoute has just been destroyed
(removed from the game) but the traderoute has not yet been removed from the
client end. I see nothing sending city info about trade partner cities, only
textual events, before city gets removed."

Untested patch for S2_5 attached.

(file #26908)
___

Additional Item Attachment:

File name: PartnerInfoOnRouteRemoval-S2_5.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Jacob Nevins]

Follow-up Comment #5, bug #23708 (project freeciv):

This doesn't look like bug #24072, where both city pointers seem valid (here
one is NULL).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Jacob Nevins]

Update of bug #23708 (project freeciv):

 Summary: Segmentation fault in cities_trade_route_type =>
Segmentation fault in cities_trade_route_type during server_quit()

___

Follow-up Comment #4:

I'm going to assume that the report in comment #0 has been resolved by the fix
for bug #23614. It seems consistent on a quick look.

Repurposing ticket for the remaining report, comment #1, of something similar
in server_quit(). Suspect the solution is similar: suspect city refresh during
teardown.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type

[Jacob Nevins]

Update of bug #23708 (project freeciv):

 Planned Release: = 3.0.0  

___

Follow-up Comment #3:

Re comment #0, see also bug #23614.

___

Reply to this item at:

  http://gna.org/bugs/?23708

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type

[Andreas Røsdal]

Follow-up Comment #2, bug #23708 (project freeciv):

This patch has resolved the segmentation faults for the Freeciv server running
on Freeciv-web production server:

https://github.com/freeciv/freeciv-web/blob/91b6b810d25f16a4464b7f2b8ab46e5dd203849f/freeciv/patches/city_traderoute_hotfix.patch

It is not a proper fix, just a short-term solution to prevent the server from
crashing. 

___

Reply to this item at:

  http://gna.org/bugs/?23708

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type

[Andreas Røsdal]

URL:
  http://gna.org/bugs/?23708

 Summary: Segmentation fault in cities_trade_route_type
 Project: Freeciv
Submitted by: andreasr
Submitted on: Wed 22 Jul 2015 07:59:59 PM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

The following segmentation fault occurred in the Freeciv server of Freeciv-web
today.  I pushed the current github master version to production today, which
is based on the Freeciv server svn revision 29233 (trunk).


Core was generated by `freeciv-web --debug=1 --port 6029 -q 20 --Announce none
-e -m -M http://localho'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
1074  return pcity-tile;
Traceback (most recent call last):
  File
/usr/share/gdb/auto-load/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19-gdb.py,
line 63, in module
from libstdcxx.v6.printers import register_libstdcxx_printers
ImportError: No module named 'libstdcxx'
(gdb) bt full
#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
No locals.
#1  0x0059a515 in cities_trade_route_type
(pcity1=pcity1@entry=0x2b86080,
pcity2=pcity2@entry=0x0) at traderoutes.c:66
ds = 0x0
plr1 = optimized out
plr2 = optimized out
__FUNCTION__ = cities_trade_route_type
#2  0x0051f5bb in set_city_production (pcity=0x2b86080) at
city.c:2612
type = optimized out
settings = optimized out
tcity = 0x0
can_trade = optimized out
proute_iter = 0x2b8a020
proute = 0x2b89fc0
#3  city_refresh_from_main_map (pcity=pcity@entry=0x2b86080,
workers_map=workers_map@entry=0x0)
at city.c:2785
No locals.
#4  0x0045d209 in city_refresh (pcity=pcity@entry=0x2b86080) at
cityturn.c:154
retval = false
#5  0x0049866f in sg_load_player_cities
(loading=loading@entry=0x2835490,
plr=plr@entry=0x4a6f1b0) at savegame3.c:4069
buf =
player0.c5\000ceship\000\000\377\000\000\000\000\200I\000\000\000\000\000
pcity = 0x2b86080
ncities = 8
i = 5
plrno = 0
tasks_handled = optimized out
__FUNCTION__ = sg_load_player_cities
#6  0x0049f634 in sg_load_players (loading=loading@entry=0x2835490) at
savegame3.c:3220
pplayer = 0x4a6f1b0
_pslot = 0x251bf30
__FUNCTION__ = sg_load_players
#7  0x004a1926 in savegame3_load_real (file=optimized out) at
savegame3.c:520
loading = 0x2835490
was_send_city_suppressed = false
was_send_tile_suppressed = false
__FUNCTION__ = savegame3_load_real
#8  0x00418193 in load_command (caller=caller@entry=0x8a0e20
connections,
filename=filename@entry=0x7ffe1e057940 liberty, check=check@entry=false)
at stdinhand.c:3648
loadtimer = 0x32cbb80
uloadtimer = 0x24cc950
file = 0x2519900
arg =
/home/freeciv/freeciv-web/freeciv-web/resin/webapps/ROOT/savegames/liberty.sav.xz,
'\000' repeats 63 times, \377\377\377\377, '\000' repeats 44 times,
\377\377\377\377\377\377\377\377...
__FUNCTION__ = load_command
#9  0x00419fd4 in handle_stdin_input_real
(caller=caller@entry=0x8a0e20 connections,
str=optimized out, str@entry=0x7ffe1e058470 /load liberty,
check=check@entry=false,
read_recursion=read_recursion@entry=0) at stdinhand.c:4228
full_command = load liberty\000\177\000\000`{\005\036\376\177,
'\000' repeats 42 times, \377\377\377\377\377\377\377\377, '\000' repeats
14 times,  \000\000\000\000\000\000\000\000\000N\000\000\000\376\177,
'\000' repeats 34 times,
\001\000\000\000\000\000\000\000\377\377\377\377\377\377\377\377N, '\000'
repeats 11 times, \376\177
\000\000\000\000\000\000\000\000\000\320w\005\036\376\177\000\000\303Kb\000\000\000\000\000\002\000\000\000\000\000\000\000...
command =
load\000\000\000\000\000P\370i\240\177\000\000\070*d\000\000\000\000\000`\305\v\004\0


and


#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
#1  0x0059a515 in cities_trade_route_type
(pcity1=pcity1@entry=0x2765880,
pcity2=pcity2@entry=0x0) at traderoutes.c:66
#2  0x0051f5bb in set_city_production (pcity=0x2765880) at
city.c:2612
#3  city_refresh_from_main_map (pcity=pcity@entry=0x2765880,
workers_map=workers_map@entry=0x0)
at city.c:2785
#4  0x0045d209 in city_refresh (pcity=pcity@entry=0x2765880) at
cityturn.c:154
#5  0x0049866f in sg_load_player_cities
(loading=loading@entry=0x2414ca0,
plr=plr@entry=0x46500d0) at savegame3.c:4069
#6  0x0049f634 in sg_load_players (loading=loading@entry=0x2414ca0) 

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type

[Andreas Røsdal]

Follow-up Comment #1, bug #23708 (project freeciv):

Another backtrace generated from a core. It seems that when server_quit() is
called, soem city tile is null?

Core was generated by `freeciv-web --debug=1 --port 6038 -q 20 --Announce none
-e -m -M http://localho'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
1074  return pcity-tile;
Traceback (most recent call last):
  File
/usr/share/gdb/auto-load/usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.19-gdb.py,
line 63, in module
from libstdcxx.v6.printers import register_libstdcxx_printers
ImportError: No module named 'libstdcxx'
(gdb) bt
#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
#1  0x0059a515 in cities_trade_route_type
(pcity1=pcity1@entry=0x2194670,
pcity2=pcity2@entry=0x0) at traderoutes.c:66
#2  0x0051f5bb in set_city_production (pcity=0x2194670) at
city.c:2612
#3  city_refresh_from_main_map (pcity=pcity@entry=0x2194670,
workers_map=workers_map@entry=0x0)
at city.c:2785
#4  0x0045d209 in city_refresh (pcity=0x2194670) at cityturn.c:154
#5  0x0045d9dc in city_refresh_queue_processing () at cityturn.c:208
#6  0x0047546e in server_remove_player (pplayer=0x1a7db50) at
plrhand.c:1649
#7  0x0040cee5 in server_game_free () at srv_main.c:3056
#8  0x0040d038 in server_quit () at srv_main.c:1574
#9  0x004a9c05 in server_sniff_all_input () at sernet.c:575
#10 0x0040d88d in srv_running () at srv_main.c:2574
#11 srv_main () at srv_main.c:3102
#12 0x00405485 in main (argc=20, argv=0x7ffdf71fec08) at
civserver.c:459



(gdb) bt full
#0  city_tile (pcity=pcity@entry=0x0) at city.c:1074
No locals.
#1  0x0059a515 in cities_trade_route_type
(pcity1=pcity1@entry=0x2194670,
pcity2=pcity2@entry=0x0) at traderoutes.c:66
ds = 0x0
plr1 = optimized out
plr2 = optimized out
__FUNCTION__ = cities_trade_route_type
#2  0x0051f5bb in set_city_production (pcity=0x2194670) at
city.c:2612
type = optimized out
settings = optimized out
tcity = 0x0
can_trade = optimized out
proute_iter = 0x0
proute = 0x22a1eb0
#3  city_refresh_from_main_map (pcity=pcity@entry=0x2194670,
workers_map=workers_map@entry=0x0)
at city.c:2785
No locals.
#4  0x0045d209 in city_refresh (pcity=0x2194670) at cityturn.c:154
retval = false
#5  0x0045d9dc in city_refresh_queue_processing () at cityturn.c:208
pcity_iter = 0x0
..

___

Reply to this item at:

  http://gna.org/bugs/?23708

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev