[Freeciv-Dev] [bug #23844] Settings locked by the ruleset always saved

[Marko Lindqvist]

Update of bug #23844 (project freeciv):

Category:None => general
  Status:None => Ready For Test 

___

Follow-up Comment #1:

Fix

(file #25060)
___

Additional Item Attachment:

File name: SettingIsFreeToChange.patchSize:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23844] Settings locked by the ruleset always saved

[Marko Lindqvist]

URL:
  

 Summary: Settings locked by the ruleset always saved
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 02 Sep 2015 12:15:21 AM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0

___

Details:

While testing patch #6310 I noticed that the logic that is supposed to save
just those settings that would not work if changed later (like change to map
generator parameters when map has already been generated) catches many false
positives.
It relies on setting_is_changeable(), but setting can be unchangeable by user
for reasons not applicable for the case of saving them. Most notably setting
locked by a ruleset gets saved though the intent there is obviously that the
ruleset, even if updated to version with different value, wants to control.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev