[Freeciv-Dev] [bug #24086] pf_fuel_map_create_segment: warning: comparison is always true due to limited range of data typee

[Marko Lindqvist]

Update of bug #24086 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24086] pf_fuel_map_create_segment: warning: comparison is always true due to limited range of data typee

[Marko Lindqvist]

Update of bug #24086 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #1:

Simply remove the assert as something that is already asserted at the compiler
level.

(file #25761)
___

Additional Item Attachment:

File name: Assert8bitsLessThan256Rm.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24086] pf_fuel_map_create_segment: warning: comparison is always true due to limited range of data typee

[Marko Lindqvist]

URL:
  

 Summary: pf_fuel_map_create_segment: warning: comparison is
always true due to limited range of data typee
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 15 Nov 2015 06:57:49 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: S2_5
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.2

___

Details:

common/aicore/path_finding.c: In function 'pf_fuel_map_create_segment':
common/aicore/path_finding.c:2186: warning: comparison is always true due to
limited range of data type

It certainly is and the code in question is an assert about it:

fc_assert(256 > node1->size_alloc); /* node1->size_alloc has only 8 bits. */





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev