[Freeciv-Dev] [bug #24468] Commandline option parameters allocated with get_option_malloc() not freed

[Marko Lindqvist]

Update of bug #24468 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24468] Commandline option parameters allocated with get_option_malloc() not freed

[Marko Lindqvist]

Follow-up Comment #4, bug #24468 (project freeciv):

TRUNK & S2_6 versions updated against svn

(file #27678, file #27679)
___

Additional Item Attachment:

File name: FreeGetOptionsMallocResults-2.patch Size:23 KB
File name: FreeGetOptionsMallocResults-S2_6-2.patch Size:22 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24468] Commandline option parameters allocated with get_option_malloc() not freed

[Marko Lindqvist]

Follow-up Comment #2, bug #24468 (project freeciv):

TRUNK/S2_6 patches that adds bookkeeping of the allocated option values when
they are not handled by the calling side, and frees them on exit.

(file #27629, file #27630)
___

Additional Item Attachment:

File name: FreeGetOptionsMallocResults.patch Size:23 KB
File name: FreeGetOptionsMallocResults-S2_6.patch Size:22 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24468] Commandline option parameters allocated with get_option_malloc() not freed

[Marko Lindqvist]

Update of bug #24468 (project freeciv):

  Status:None => Ready For Test 
 Planned Release:2.6.0, 3.0.0 => 2.5.5, 2.6.0, 3.0.0

___

Follow-up Comment #1:

Patch for S2_5 that frees the couple of values from get_option_malloc() that
are not needed later but are not yet freed immediately.
For S2_6/TRUNK I'm working on full patches to make them valgrind clean.

(file #27628)
___

Additional Item Attachment:

File name: FreeOptions-S2_5.patch Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24468] Commandline option parameters allocated with get_option_malloc() not freed

[Marko Lindqvist]

URL:
  

 Summary: Commandline option parameters allocated with
get_option_malloc() not freed
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 26 Feb 2016 09:49:34 PM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0

___

Details:

There might be exceptions, but generally we never free what we get from
get_option_malloc(). This is harmless enough that I've not been reworking S2_5
to fix this (can consider backporting when implemented). It's a tiny amount of
memory, and in most cases they are anyway needed until we shut down the
program. So fixing this is mostly about getting valgrind reports clean. Goal
is server-side to get clean valgrind reports in 2.6.0.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev