[Freeciv-Dev] [bug #25341] Qt client doesn't build with Qt <5.5

[Jacob Nevins]

Update of bug #25341 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #5:

I've committed this minimal patch, and raised bug #25343 for the wider issue
of reducing / documenting our Qt dependencies.
I haven't raised a bug explicitly about nicer QWheelEvent handling.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25341] Qt client doesn't build with Qt <5.5

[Marko Lindqvist]

Follow-up Comment #2, bug #25341 (project freeciv):

> I'm not sure what the minimum Qt5 version we notionally support is.

I don't remember any discussion about bumping the minimum requirement, nor has
such a thing been documented (S2_6 compared to S2_5, in
S2_6/doc/README.packaging)

As far as I know we still namely support 5.0.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25341] Qt client doesn't build with Qt <5.5

[Jacob Nevins]

Update of bug #25341 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Attached a minimal patch which removes the 'source' argument from QWheelEvent
constructors, restoring ability to compile with Qt 5.2(.1).

The Qt client itself doesn't seem to use the 'source' information, but maybe
it passes the events on to built-in widgets which do. So the result might be
slightly wrong for new Qt installations.

There's probably a better solution that involves copying and modifying the
object rather than constructing a new one. This would be less
version-dependent (for instance there's an 'inverted' property added in 5.7,
and we still use 'phase' which imposes a minimum of 5.2).

If anyone has a better patch, feel free to take over this ticket. Otherwise
I'll be committing this one soon, as the issue is in my way.

(file #29517)
___

Additional Item Attachment:

File name: trunk-S2_6-qtwheel.patch   Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #25341] Qt client doesn't build with Qt <5.5

[Jacob Nevins]

URL:
  

 Summary: Qt client doesn't build with Qt <5.5
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 26 Nov 2016 11:17:37 AM UTC
Category: client-qt
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0-beta1, 3.0.0
 Contains string changes: None

___

Details:

Recently the Qt client has started referencing 
QWheelEvent::source() , which
wasn't added until Qt 5.5. So it no longer compiles on Qt 5.2.1 that ships
with Ubuntu 14.04 (which I use).

I'm not sure what the minimum Qt5 version we notionally support is.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev