[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Vijay Kiran Kamuju]

Follow-up Comment #16, patch #2061 (project freeciv):

its failing on the latest trunk
update the patch so i can test with xaw client

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Matthias Pfafferodt]

Update of patch #2061 (project freeciv):

 Planned Release:   2.3.0 => 2.4.0  

___

Follow-up Comment #15:

update target to freeciv 2.4.0

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Matthias Pfafferodt]

Follow-up Comment #14, patch #2061 (project freeciv):

small update:

* fix color in the sdl-client (wrong maps)

(file #10918)
___

Additional Item Attachment:

File name: 20101024-05-trunk-define-player-colors-in-the-ruleset.patch
Size:62 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Matthias Pfafferodt]

Follow-up Comment #13, patch #2061 (project freeciv):

> Sometimes, using LANG=C allow the client to launch, but it
> usually crash very often due to the unmaintained state of it. 

Lang=C does not help ...


#> LANG=C
#> ./civ --gui xaw
Running ./client/freeciv-xaw
Encodings: Data=UTF-8, Local=ISO-8859-1, Internal=ISO-8859-1
1: Unimplemented set_city_names_font_sizes.
1: last message repeated 2 times
1: last message repeated 2 times (total 4 repeats)
1: last message repeated 2 times (total 6 repeats)
2: Using fallback resources - which is OK
X Error of failed request:  BadDrawable (invalid Pixmap or Window parameter)
  Major opcode of failed request:  62 (X_CopyArea)
  Resource id in failed request:  0x14
  Serial number of failed request:  3408
  Current serial number in output stream:  15374


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Marko Lindqvist]

Follow-up Comment #12, patch #2061 (project freeciv):

Rulesets definitely are incompatible with S2_2 rulesets, and probably also
tilesets. So they definitely should have different capstr in S2_3. I think
tileset capstrs used to be kept updated when ever incompatibilities were
added in the past, but ruleset ones not.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[pepeto]

Follow-up Comment #11, patch #2061 (project freeciv):

> At a related notw, it would be great if we could publish release
> notes for each new tileset format in the future.

That's a good idea. What support do you suggest to do that?


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Daniel Markstedt]

Follow-up Comment #10, patch #2061 (project freeciv):

I'm liking this idea a lot, too. At a related notw, it would be great if we
could publish release notes for each new tileset format in the future. Up
until now getting a tileset (or modpack) updated for a new version of Freeciv
has been pretty much a matter of blind trial and error. I know of at least two
tileset authors who gave up maintaining their tilesets because of this.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Matthias Pfafferodt]

Follow-up Comment #9, patch #2061 (project freeciv):

> I guess that in trunk, it should looks like our network
> capability string: "+Freeciv.Devel." 

... using the date of the last change. At the time of a new release it could
be changed to +Freeciv2.3" or something similar.

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[pepeto]

Follow-up Comment #8, patch #2061 (project freeciv):

> Should the current ruleset/tileset files be updated as
> '+freeciv2.3'?

I guess that in trunk, it should looks like our network capability string:
"+Freeciv.Devel."


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[pepeto]

Follow-up Comment #7, patch #2061 (project freeciv):

> The log for the xaw client shows the following but no core dump
> is created.

Sometimes, using _LANG=C_ allow the client to launch, but it usually crash
very often due to the unmaintained state of it. Where is our xaw maintainer?


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[pepeto]

Follow-up Comment #6, patch #2061 (project freeciv):

>> For the future, I would propose that we set as capability the
>> version number (like +2.3) for every related file to this
>> version. It would also be very clearer in the compatibility of
>> the files.
>
> I think this is a good idea. So each major version step (2.3.x,
> 2.4.x) needs a revised ruleset and tileset and within the
> version no changes are allowed (similar to the network
> protocol). Should the current ruleset/tileset files be updated
> as '+freeciv2.3'?

It would be nice to have at least Jacob advice or Marko's one about it. Also,
note that savegame could have exactly the same, instead of saving many times
the savegame version.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Matthias Pfafferodt]

Follow-up Comment #5, patch #2061 (project freeciv):

The log for the xaw client shows the following but no core dump is created.


#> ./civ --gui xaw -F
Running ./client/freeciv-xaw
Encodings: Data=UTF-8, Local=UTF-8, Internal=UTF-8
1: Unimplemented set_city_names_font_sizes.
1: last message repeated 2 times
1: last message repeated 2 times (total 4 repeats)
1: last message repeated 2 times (total 6 repeats)
2: Using fallback resources - which is OK
1: Font for charset KSC5601.1987-0 is lacking
1: Font for charset GB2312.1980-0 is lacking
1: Font for charset KSC5601.1987-0 is lacking
1: Font for charset GB2312.1980-0 is lacking
Warning: Missing charsets in String to FontSet conversion
X Error of failed request:  BadDrawable (invalid Pixmap or Window parameter)
  Major opcode of failed request:  62 (X_CopyArea)
  Resource id in failed request:  0x0
  Serial number of failed request:  4587
  Current serial number in output stream:  16409


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Matthias Pfafferodt]

Follow-up Comment #4, patch #2061 (project freeciv):

This patch is mandatory for the mapimg patch series. It implements a gui
dependend function which creates the sprites needed for the player colors on
the fly. I did code this function for the gtk client (and it seems to work).
I did try to implement it for the other two supported clients - sdl and xaw -
but at least the xaw implementation crash the client. Any help with regard to
this client is welcome!

gtk client (working): client/gui-gtk-2.0/sprite.c:118:create_sprite()
sdl client (working; but bug #16865):
client/gui-sdl/sprite.c:119:create_sprite()
xaw client (not working): client/gui-xaw/graphics.c:222:create_sprite()

(file #10765)
___

Additional Item Attachment:

File name: 20101013-05-trunk-define-player-colors-in-the-ruleset.patch
Size:62 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Matthias Pfafferodt]

Follow-up Comment #3, patch #2061 (project freeciv):

> For the future, I would propose that we set as capability the
> version number (like +2.3) for every related file to this
> version. It would also be very clearer in the compatibility of
> the files. 

I think this is a good idea. So each major version step (2.3.x, 2.4.x) needs
a revised ruleset and tileset and within the version no changes are allowed
(similar to the network protocol). Should the current ruleset/tileset files
be updated as '+freeciv2.3'?

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[pepeto]

Follow-up Comment #2, patch #2061 (project freeciv):

I am not answering about tileset capabilities only, but also ruleset ones. I
doubt we really use the advantage of them. Sometimes, the definitions has
changed and we never updated the capability string of it.

For the future, I would propose that we set as capability the version number
(like +2.3) for every related file to this version. It would also be very
clearer in the compatibility of the files.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Matthias Pfafferodt]

Follow-up Comment #1, patch #2061 (project freeciv):

This patch removes colors.misc and changes colors.tilespec - does this
requires an updated capability string for the tileset files? (see also patch
#2060)

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #2061] [mapimg] define player colors in the ruleset

[Matthias Pfafferodt]

URL:
  

 Summary: [mapimg] define player colors in the ruleset
 Project: Freeciv
Submitted by: syntron
Submitted on: Dienstag 12.10.2010 um 15:07
Category: general
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:

* use game.ruleset
* automatically generate the sprites needed
* changes to the network protocol

Please check (and if possible fix) the function create_sprite() in the sdl
client (sprite.c) and xaw client (graphics.c). I did try to get them working
but these clients crash ...



___

File Attachments:


---
Date: Dienstag 12.10.2010 um 15:07  Name:
20101012-05-trunk-define-player-colors-in-the-ruleset.patch  Size: 60kB   By:
syntron



___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev