[Freeciv-Dev] [patch #2812] Fix modpack initialization
Update of patch #2812 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2812 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2812] Fix modpack initialization
Follow-up Comment #10, patch #2812 (project freeciv): Patch for S2_3 that uses PKG_CHECK_MODULES() there too. Applies on top of already committed patch. Compiles for both linux and MinGW, works on linux (I cannot test Windows) Jordi Negrevernis i Font reports that currently S2_3 does not compile for him and I assume this to fix it. So committing this immediately as compilation fix. (file #13680) ___ Additional Item Attachment: File name: GthreadPcCheck_2812-S2_3.diff Size:0 KB ___ Reply to this item at: http://gna.org/patch/?2812 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2812] Fix modpack initialization
Update of patch #2812 (project freeciv): Assigned to: jtn = cazfi ___ Follow-up Comment #8: My turn to steal this ticket in order to implement configure stuff with proper PKG_CHECK_MODULES() ___ Reply to this item at: http://gna.org/patch/?2812 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2812] Fix modpack initialization
Update of patch #2812 (project freeciv): Status: Need Info = Ready For Test ___ Follow-up Comment #9: This at least compiles for both linux and MinGW. (file #13617) ___ Additional Item Attachment: File name: GthreadInit_2812.diff Size:2 KB ___ Reply to this item at: http://gna.org/patch/?2812 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2812] Fix modpack initialization
Update of patch #2812 (project freeciv): Status:None = Need Info Assigned to:None = jtn Planned Release: 2.3.1,2.4.0 = 2.3.0,2.4.0 ___ Follow-up Comment #5: Thanks for the patch. Stealing and quick committing to S2_3 for 2.3.0. (Justification for breaking code freeze: this takes freeciv-modpack.exe from useless to useful, and looks to have a low risk of breaking anything else.) However, the configure.ac bit of the patch doesn't apply cleanly to trunk, so the ticket stays open. I can fix the Gtk2 case, but not the Gtk3 case: I don't know what to put in MP_gtk_LIBS where we have -lgthread2.0 in Gtk2, if anything. Any ideas? ___ Reply to this item at: http://gna.org/patch/?2812 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2812] Fix modpack initialization
Follow-up Comment #6, patch #2812 (project freeciv): I can fix the Gtk2 case, but not the Gtk3 case: I don't know what to put in MP_gtk_LIBS where we have -lgthread2.0 in Gtk2, if anything. Any ideas? gthreads are part of glib, not gtk, so it doesn't matter if we are building gtk2- or gtk3-version. AFAIK you should use same -lgthread2.0. ___ Reply to this item at: http://gna.org/patch/?2812 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2812] Fix modpack initialization
Follow-up Comment #7, patch #2812 (project freeciv): I have not (yet) looked the patch, but manually writing something like -lgthread2.0 sounds suspicious anyway. You should probably be using pkg-config. ___ Reply to this item at: http://gna.org/patch/?2812 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2812] Fix modpack initialization
Follow-up Comment #3, patch #2812 (project freeciv): NB, the patch attached here also includes the patch for bug #18354. ___ Reply to this item at: http://gna.org/patch/?2812 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2812] Fix modpack initialization
Update of patch #2812 (project freeciv): Planned Release: = 2.3.1,2.4.0 ___ Reply to this item at: http://gna.org/patch/?2812 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2812] Fix modpack initialization
Follow-up Comment #2, patch #2812 (project freeciv): (Oh, and freeciv-modpack launched fine from the start menu (thanks). Suggest it's called Freeciv modpack installer rather than just Freeciv Modpack.) ___ Reply to this item at: http://gna.org/patch/?2812 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2812] Fix modpack initialization
URL: http://gna.org/patch/?2812 Summary: Fix modpack initialization Project: Freeciv Submitted by: cproc Submitted on: So 17 Jul 2011 05:14:57 CEST Category: module installer Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: $subject + add libgthread dependency on Windows, where it is not already a dependency of GTK+ as on Linux. Modpack downloading seems to work now on Windows. Here's an S2_3 Windows package for testing: http://download.gna.org/freeciv/packages/windows/testing/Freeciv-S2_3-2011-07-17-win32-gtk2-setup.exe ___ File Attachments: --- Date: So 17 Jul 2011 05:14:57 CEST Name: modpack_initialization.diff Size: 1kB By: cproc http://gna.org/patch/download.php?file_id=13597 ___ Reply to this item at: http://gna.org/patch/?2812 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
