[Freeciv-Dev] [patch #3611] Ruleset setting about cancelling illegal traderoutes

[Marko Lindqvist]

Update of patch #3611 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3611] Ruleset setting about cancelling illegal traderoutes

[Marko Lindqvist]

Follow-up Comment #1, patch #3611 (project freeciv):

- Fixed keeping of traderoute over city owner change
- Get 0 trade from Inactive traderoute instead of "random" (uninitialized)
amount
- Set values in ruleset "Cancel" rather than "Active" as it turned out that
the old behavior was like that when city changes owner and traderoute turns
illegal

(file #17009)
___

Additional Item Attachment:

File name: TraderouteCancellingSetting-2.patch Size:17 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3611] Ruleset setting about cancelling illegal traderoutes

[Marko Lindqvist]

URL:
  

 Summary: Ruleset setting about cancelling illegal traderoutes
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 22 Jan 2013 11:03:11 PM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.0

___

Details:

So far only compile-tested patch, but posting already for discussion.

There's currently no handling of already established traderoutes turned
illegal. With most supplied rulesets such a thing could happen if city changes
owner and suddenly trading cities should be at least trademindist apart, but
are not. Civ2civ3 ruleset prohibits national traderoutes altogether.
Does anybody know how civ/2 handle this? In attached patch I've added only
TOOD comment to civ/2 rulesets that settings should be corrected.

Patch adds ruleset setting to control what happens to each kind (national,
intercontinental, international, inic) of illegal traderoutes. Possible values
are "Active" - traderoute is fully functional, "Inactive" - traderoute is not
functional, but remains in case it later turns back legal, and "Cancel" -
traderoute is removed.



___

File Attachments:


---
Date: Tue 22 Jan 2013 11:03:11 PM EET  Name: TraderouteCancellingSetting.patch
 Size: 17kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev