[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Update of patch #5955 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Update of patch #5955 (project freeciv): Status: In Progress = Ready For Test ___ Additional Item Attachment: File name: 0001-JSON-protocol-Send-and-receive-field-arrays-as-JSON-.patch Size:12 KB ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Follow-up Comment #8, patch #5955 (project freeciv): I have tested and reviewed this patch, and can gladly report that JSON arrays are now transferred correctly! Thanks a lot to Sveinung for resolving this complicated issue in a very good way, I don't think I could have done this myself! :) Andreas (Happy!) :) ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Update of patch #5955 (project freeciv): Planned Release: = 3.0.0 ___ Follow-up Comment #9: I have tested and reviewed this patch, and can gladly report that JSON arrays are now transferred correctly! Thank you for your review and your testing! It is great to have someone that knows where field arrays are used check that everything still works. While it is easy to see if a field array is transferred as a JSON array it is not easy to detect that an array element is missing or have the wrong type. Having someone that knows what the application well test has been a great help. Thanks a lot to Sveinung for resolving this complicated issue in a very good way You are welcome. ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Update of patch #5955 (project freeciv): Depends on: = patch #6028 ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Update of patch #5955 (project freeciv): Depends on: = patch #6017 ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Update of patch #5955 (project freeciv): Status:None = In Progress Assigned to:None = sveinung ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Follow-up Comment #6, patch #5955 (project freeciv): Thanks, Sveinung, I really encourage you to help find a good solution to this! ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Follow-up Comment #3, patch #5955 (project freeciv): To me it looks like we should split json addressing from reading/writing. If that isn't done we would have to create a new function in dataio_json for each combination of address type and data type combination in use. One way to separate addressing and reading/writing is to make generate_packets.py generate code (inside #ifdef FREECIV_JSON_CONNECTION) that handles addressing. Would anyone object to this approach? ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Follow-up Comment #4, patch #5955 (project freeciv): One way to separate addressing and reading/writing is to make generate_packets.py generate code (inside #ifdef FREECIV_JSON_CONNECTION) that handles addressing. Would anyone object to this approach? Can you do it so that in the future it can be extended to a case where both raw- and json-protocol are enabled at the same time? Having a lot of stuff added inside #ifdef FREECIV_JSON_CONNECTION does not sound like that. That's not necessarily a reason to reject your plan; it could be used as an temporary solution for now (no idea when I would have time to get into any dual-protocol setup anyway). Still, it's something to consider. ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Follow-up Comment #5, patch #5955 (project freeciv): One way to separate addressing and reading/writing is to make generate_packets.py generate code that handles addressing. Would anyone object to this approach? I don't object to this approach. My main objective here is that arrays in the JSON protocol should be actual JSON arrays as defined in the specification. The actual implementation of that in generate_packets.py and elsewhere can be refined and refactored over time. So I _definitively_ support any effort to resolve this. ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Follow-up Comment #2, patch #5955 (project freeciv): I would _really_ appreciate some help implementing json arrays correctly in Freeciv, so we can get Freeciv-web master working again. ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
URL: http://gna.org/patch/?5955 Summary: Json protocol arrays as json arrays Project: Freeciv Submitted by: cazfi Submitted on: Fri 27 Mar 2015 10:25:54 PM EET Category: freeciv-web Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: As said in patch #5937, arrays transmitted over our json protocol should use actual json arrays. ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5955] Json protocol arrays as json arrays
Update of patch #5955 (project freeciv): Priority: 5 - Normal = 7 - High ___ Follow-up Comment #1: This is important for Freeciv-web to work, and a resolution to this would be much appreciated. The definition of a json array is pretty clearly defined on http://json.org/ Thanks! ___ Reply to this item at: http://gna.org/patch/?5955 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
